From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: mike.leach@linaro.org, linux@armlinux.org.uk
Cc: linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org,
linux-kernel@vger.kernel.org, mathieu.poirier@linaro.org
Subject: Re: [RESEND PATCH v3 1/2] drivers: amba: Updates to component identification for driver matching.
Date: Fri, 11 Jan 2019 11:43:31 +0000 [thread overview]
Message-ID: <b492ca38-0bc9-ae7e-486a-e56023e369c7@arm.com> (raw)
In-Reply-To: <20181218215944.2444-2-mike.leach@linaro.org>
Hi Mike,
On 18/12/2018 21:59, Mike Leach wrote:
> The CoreSight specification (ARM IHI 0029E), updates the ID register
> requirements for components on an AMBA bus, to cover both traditional
> ARM Primecell type devices, and newer CoreSight and other components.
>
> The Peripheral ID (PID) / Component ID (CID) pair is extended in certain
> cases to uniquely identify components. CoreSight components related to
> a single function can share Peripheral ID values, and must be further
> identified using a Unique Component Identifier (UCI). e.g. the ETM, CTI,
> PMU and Debug hardware of the A35 all share the same PID.
>
> Bits 15:12 of the CID are defined to be the device class.
> Class 0xF remains for PrimeCell and legacy components.
> Class 0x9 defines the component as CoreSight (CORESIGHT_CID above)
> Class 0x0, 0x1, 0xB, 0xE define components that do not have driver support
> at present.
> Class 0x2-0x8,0xA and 0xD-0xD are presently reserved.
>
> The specification futher defines which classes of device use the standard
> CID/PID pair, and when additional ID registers are required.
>
> The patches provide an update of amba_device and matching code to handle
> the additional registers required for the Class 0x9 (CoreSight) UCI.
> The *data pointer in the amba_id is used by the driver to provide extended
> ID register values for matching.
>
> CoreSight components where PID/CID pair is currently sufficient for
> unique identification need not provide this additional information.
>
> Signed-off-by: Mike Leach <mike.leach@linaro.org>
> Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Looks like you missed my Reviewed tags on the previous version. Anyways,
Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-11 11:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 21:59 [RESEND PATCH v3 0/2] Update AMBA driver for enhanced component ID spec Mike Leach
2018-12-18 21:59 ` [RESEND PATCH v3 1/2] drivers: amba: Updates to component identification for driver matching Mike Leach
2019-01-11 11:43 ` Suzuki K Poulose [this message]
2019-01-25 7:20 ` Sai Prakash Ranjan
2019-01-25 10:37 ` Mike Leach
2019-01-25 10:42 ` Suzuki K Poulose
2018-12-18 21:59 ` [RESEND PATCH v3 2/2] coresight: etmv4: Update ID register table to add UCI support Mike Leach
2019-01-11 11:44 ` Suzuki K Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b492ca38-0bc9-ae7e-486a-e56023e369c7@arm.com \
--to=suzuki.poulose@arm.com \
--cc=coresight@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).