From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D66AC433E1 for ; Tue, 14 Jul 2020 11:59:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB93722224 for ; Tue, 14 Jul 2020 11:59:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="xXbp3Y7x"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="V/C4pNku" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB93722224 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+xqqeA9IS/gOQTdRQKoFja8HVPpE4M+2j+LycITHvf0=; b=xXbp3Y7xZPBzWDNsz/7AkAYu8 Coe+BCZIGYghj2PTBR0RMp8m9Qqkr692eKQuOSFdCaLZ1rHIKAD+hx2QNf7VYoP7VfVz3PQbUvIIx fvup3ntWqiwjzkDYAlt+nz80Zowp+O2THGTtVCmHqlgTv70dKcUL556aiKl11NoKx/y5TJU2WleAU JZ/jwKy3Qe6veEox23VUfr8V0+B+rzeA5eiVDkkNs6fVHAsxA/QeVPfsyjO9Q9lTyaivHMxDVHW4q Kso+KvbSzyzhEfw+EM+IP5LORW5tZHEdDsRsIMglRQ559lyOHmIuFqGpXn263M+bJ4D84CRI8A8UI jMdHW72Jg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvJZI-0004fs-Tk; Tue, 14 Jul 2020 11:57:52 +0000 Received: from mail-qk1-x744.google.com ([2607:f8b0:4864:20::744]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvJZF-0004fR-Hq for linux-arm-kernel@lists.infradead.org; Tue, 14 Jul 2020 11:57:50 +0000 Received: by mail-qk1-x744.google.com with SMTP id j80so15272344qke.0 for ; Tue, 14 Jul 2020 04:57:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=NkNVX1ZcJVS3e8biwrjQT6EacEX4r2OJ0VViQiJAn7w=; b=V/C4pNkuTi+dU58bJl2BxnDt0hIsnQA+mr3Wfha7q1quaLPoRuJ46wpvxLV4b1c29X DU4orQjYQzG+GuE+TnyK04MM4EJhfrWMO3LR7HbbflpyU82N+PGEE9z/iMVOJiS7DQ5L ZjXndOaj695wzeFSmH+3qLhk13MpEwdafxpXNXcc04rfAEFXbaUCRmHRQYbvGXKRxuvm idj02F3p1JeWIWCfFM2mQDVndfYGrg5GAiso/OogxLG3IcP16Q21pE4h4lsYOB2O66nM K1Hlvo2nSeCEDT06towuxos267LV3TzuVcLHYsWDbLhLxhYAoFrgGp9Y+DUtsHRW3OgD eWfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=NkNVX1ZcJVS3e8biwrjQT6EacEX4r2OJ0VViQiJAn7w=; b=HtznCERJkXzjHmAiWv3kCf4jXH6gFf1/wQj1QtXjWKJYXae10ib5m6Y+1iTaAjxDtM qMo3GJ6T8ndkyzCaPAm0N5UIgwn94Q+J/ieRocoEpAwVXD3RF5/ETg596E/kz37FurhF HGH+MDCGujuhI2+FVbBepUokTZRpbGlekqzYMvZSIGKz80vc/tJ1DLtN/r47k4D8TO/P fV0IppnQwWdEqHqyZoGzU1uzpf9xf5aD/lOHf+yX0Mqhbcm0jlwXEJ9hr+2M6B3ZR2Eb ruKIBuvxaTUhOIQRyTCK/wqeIkFiGm7uWFmW06oahcugwTNy2N2tvD/fGEcwCEtzzbAX LmOA== X-Gm-Message-State: AOAM533ZLrSG9V+e9Zz2ZSYVD6qWwYFMaGhMP3yNV5PK5Ioi2JmyjcLR XUeYfvaZEevss1XYBAbSWOkxGw== X-Google-Smtp-Source: ABdhPJxfMswfT9lRb6dbLLzX6SBKB7XFzm+C1eqftX4rYQgqnc4/co1qPIyDkxlhot68S9VYqjXT/A== X-Received: by 2002:a05:620a:120e:: with SMTP id u14mr4135723qkj.147.1594727865570; Tue, 14 Jul 2020 04:57:45 -0700 (PDT) Received: from ?IPv6:2804:7f0:8283:82c3:a8a5:db5f:c394:77a0? ([2804:7f0:8283:82c3:a8a5:db5f:c394:77a0]) by smtp.gmail.com with ESMTPSA id v134sm22435678qkb.60.2020.07.14.04.57.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jul 2020 04:57:45 -0700 (PDT) Subject: Re: [PATCH v3 0/7] arm64: Fix single-step handling and syscall tracing To: Will Deacon , linux-arm-kernel@lists.infradead.org References: <20200710130702.30658-1-will@kernel.org> From: Luis Machado Message-ID: Date: Tue, 14 Jul 2020 08:57:41 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200710130702.30658-1-will@kernel.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200714_075749_864603_063407D7 X-CRM114-Status: GOOD ( 26.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , catalin.marinas@arm.com, Keno Fischer , kernel-team@android.com, Kees Cook Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Will, On 7/10/20 10:06 AM, Will Deacon wrote: > Hi folks, > > This is version three of the patches I previous posted here: > > v1: https://lore.kernel.org/r/20200603151033.11512-1-will@kernel.org > v2: https://lore.kernel.org/r/20200702212618.17800-1-will@kernel.org > > This version includes some changes I've been hacking on in relation to > syscall entry/exit, as it seemed worth lumping all this together. I've > also reordered the series to put the fixes at the start. > > Luis -- did you manage to test v2? I'd quite like to queue some of this > soon. If you don't have time, how can I run the GDB testsuite myself? I > tried doing it a _long_ time ago but I remember there being a lot of > failures and flakey tests, so it wasn't very helpful. I have arm64 > hardware running Debian so it's just a question of which buttons to > press :) I didn't manage to test it yet. I was going to try v3 today. If you have hardware though, that would be best. You just need to build GDB from sources (configure and make) and give the testsuite a try (make check-gdb). I can look at the result/summary and OK it. There are still flakey tests unfortunately, but those shouldn't be a big problem. You can ping me on IRC if you want to address any issues you have with building/running the tests. I'll give it a try with QEMU anyway. > > Cheers, > > Will > > Cc: > Cc: Mark Rutland > Cc: Luis Machado > Cc: Keno Fischer > Cc: Kees Cook > > --->8 > > Will Deacon (7): > arm64: ptrace: Consistently use pseudo-singlestep exceptions > arm64: ptrace: Override SPSR.SS when single-stepping is enabled > arm64: compat: Ensure upper 32 bits of x0 are zero on syscall return > arm64: ptrace: Add a comment describing our syscall entry/exit trap > ABI > arm64: syscall: Expand the comment about ptrace and syscall(-1) > arm64: ptrace: Use NO_SYSCALL instead of -1 in syscall_trace_enter() > arm64: Use test_tsk_thread_flag() for checking TIF_SINGLESTEP > > arch/arm64/include/asm/debug-monitors.h | 2 + > arch/arm64/include/asm/syscall.h | 12 +++++- > arch/arm64/include/asm/thread_info.h | 1 + > arch/arm64/kernel/debug-monitors.c | 24 +++++++++--- > arch/arm64/kernel/ptrace.c | 49 +++++++++++++++++++------ > arch/arm64/kernel/signal.c | 11 +----- > arch/arm64/kernel/syscall.c | 21 ++++++++++- > 7 files changed, 90 insertions(+), 30 deletions(-) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel