From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D17FDC433ED for ; Wed, 12 May 2021 12:05:46 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 28D2B613FC for ; Wed, 12 May 2021 12:05:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 28D2B613FC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=foss.st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=K5ezsLMT47v1lWkpphwHQSW6mUuNHdgbERuePhVS9hU=; b=T9hvXH8D5l33x2JAXRUJoWezJ tetRbnoeLyhNTn94ufG9YmHPQUoXO5SCzMa/Arr+G8gDFUPijhMyzF/zliB6pL6ytb8uZ/ufTycUi Hr5qeF4t3p85d6hAXUNEG5iL+chaYC9bJh4ov84WFHGN0P96vZhUxSxnwJXniMYyCL4wqrm/2Y9/h SfPo+S1rOwNEzfzfCFHlZ4z5iQDw9YA8Su3Wlz07hmEIuXqaLgCHu7JsDoqpXCalncL01M+Xs0cdZ pUKxXsiC5FcyIhV6l5eJzhpxwODqqX5RR8lcIuvTx/tR08iDtSzeHdUyoWeYwUnCRZ0u1gJt2QZe7 oA9kPgvyw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgnaZ-002fqu-L9; Wed, 12 May 2021 12:03:43 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgnaX-002fqd-1Q for linux-arm-kernel@desiato.infradead.org; Wed, 12 May 2021 12:03:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:To: Subject:Sender:Reply-To:Cc:Content-ID:Content-Description; bh=3h4SZOKWINWrqofFVWPe+plSxjkAE9CcDog/F00FKbc=; b=GOy6udV1BfR8V4K18g5km371yH jSQ5ci5EYLNbw8XHen+QbnN8AZeZUXm6upqwsnMZDnJTGu+EtowDqKha2sQVlm2asiX+DaPnkWoxB /y6rwRoOxJgs6WO6wvnBST2AJkcWEritmuBz5i2OhFV286iGTECCypMSn0JcdFlpNsKS6WiWy4sNv jdpNY/guXfU7LEU/usR0xCoXD8KkGQ9HxY3qr0XsXBLo1GUmmk7dT18q6RWBJOoLah+i26qgn8ne8 MAyN5oit7iBg91Hg/ypi823JCp4xUBmnfpK9UhMH6eNfKpsmw9p2QF9hxwcy5Zw1rW4cCa/aVGhfC qOEMF6sA==; Received: from mx08-00178001.pphosted.com ([91.207.212.93] helo=mx07-00178001.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgnaT-00AKI7-8Y for linux-arm-kernel@lists.infradead.org; Wed, 12 May 2021 12:03:38 +0000 Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 14CBvo5o012498; Wed, 12 May 2021 14:03:17 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=3h4SZOKWINWrqofFVWPe+plSxjkAE9CcDog/F00FKbc=; b=AtvewbwZb4KneRv1Jft8aVkGZc71iqHfypKlafqu5ju1kPJgkd/bmL1Ns9eYwx8L3zTn 04MVlN1tj2gtSt2UWJ3FKQaTcfyrDSZb6+vvy7J/dYiEb70xacdS32AW2ONJCjCTYiqw AT9O8yb8Sj0gN82g2/VwaVDOUUMhMsBJ0MPRXZMV0FSefx5GvZDYLaQuzRakfafw6opp vtDQfXvmAmwvgNFQjB6X3DYjVbMkGM4QjiO+v/QuIOx+MzJllW11tdMARZA7TpPh9UxJ GLHxre+4ob8qabdDbNnAKYFhd3RSonIcOX66OT26wy4n+EhOW7x/9zz7cXUGulCyBIeg oQ== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 38fq9tq8mk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 12 May 2021 14:03:17 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id BDF4510002A; Wed, 12 May 2021 14:03:16 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id AEE3C221763; Wed, 12 May 2021 14:03:16 +0200 (CEST) Received: from lmecxl0912.lme.st.com (10.75.127.50) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 12 May 2021 14:03:15 +0200 Subject: Re: [PATCH 1/1] irqchip/stm32-exti: Remove redundant error printing in stm32_exti_probe() To: Zhen Lei , Thomas Gleixner , Marc Zyngier , Maxime Coquelin , linux-stm32 , linux-arm-kernel References: <20210511100409.5103-1-thunder.leizhen@huawei.com> From: Alexandre TORGUE Message-ID: Date: Wed, 12 May 2021 14:03:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210511100409.5103-1-thunder.leizhen@huawei.com> Content-Language: en-US X-Originating-IP: [10.75.127.50] X-ClientProxiedBy: SFHDAG2NODE3.st.com (10.75.127.6) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-05-12_06:2021-05-12, 2021-05-12 signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210512_050337_789201_981540E0 X-CRM114-Status: GOOD ( 23.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/11/21 12:04 PM, Zhen Lei wrote: > When devm_ioremap_resource() fails, a clear enough error message will be > printed by its subfunction __devm_ioremap_resource(). The error > information contains the device name, failure cause, and possibly resource > information. > > Therefore, remove the error printing here to simplify code and reduce the > binary size. > > Reported-by: Hulk Robot > Signed-off-by: Zhen Lei > --- > drivers/irqchip/irq-stm32-exti.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/irqchip/irq-stm32-exti.c b/drivers/irqchip/irq-stm32-exti.c > index b9db90c4aa566f1..4704f2ee5797a1d 100644 > --- a/drivers/irqchip/irq-stm32-exti.c > +++ b/drivers/irqchip/irq-stm32-exti.c > @@ -892,10 +892,8 @@ static int stm32_exti_probe(struct platform_device *pdev) > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > host_data->base = devm_ioremap_resource(dev, res); > - if (IS_ERR(host_data->base)) { > - dev_err(dev, "Unable to map registers\n"); > + if (IS_ERR(host_data->base)) > return PTR_ERR(host_data->base); > - } > > for (i = 0; i < drv_data->bank_nr; i++) > stm32_exti_chip_init(host_data, i, np); > Acked-by: Alexandre TORGUE thanks alex _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel