From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E12C5C433EF for ; Sun, 29 May 2022 03:47:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:Subject:From:References:Cc:To: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Bk2JNW5CFDgdpIllrAHXPL4ekKhf2trKflgfm4tVMkc=; b=G/6QPqj6aQ6WJC x6IuZ6hUk5svdPNBR1l8sXeUzm07DdfQ1m6K2uQAHNphnJ7dL0fiThdigms8NEjBhCH8banKG8JTQ jJ5vUIhofcAiJ2+iKxi/YJ6HEFVliaoVCLeIbI5kSL2mMI1pCw+gT96PaVot+u+0r2TMFnXeL5aZ4 rcwOsJDeKcGV0LEiTzUMZtBlsj3NAdR4wdIuJjTyIxrKQ3KpPj0S94FsQlQXhj0nphSpskdqvMP1B GQUZXh2jKzl/RFZEB8Ni2n8hxS6IOiSbA9wuqi817xwIcGBPPztiUsppnPiXD9b18JBOMTu7SL4HG rfshV1dTQW3AldPnfoiA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nv9sS-003Bq7-LE; Sun, 29 May 2022 03:46:04 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nv9sN-003Bpe-VO; Sun, 29 May 2022 03:46:02 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id C9B773200754; Sat, 28 May 2022 23:45:57 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sat, 28 May 2022 23:45:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= tom-fitzhenry.me.uk; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1653795957; x=1653882357; bh=WK6kA6QrCw wKMLUCmNwj3NNYnGVd5SuQZRtDlGxvgIM=; b=jA656v1jz2FAxKtCWhmQrhi7cI bAlr3xV+m4/yfpqH2MGwddW3OBcq73ObzFN1yfiGSZV3VzQ7vBOM3ZigPWoHo9Gm UUyqsd/tjBYL9ql7Ft3qgWwAhu95z5JSE9M0DHniUYRm+mqcZ2vxiDgDWqe5AY4+ vHFJzEapzYMOifeE5mMuuvoy1SCebqWSSFbydpiFhD3IgsL8LVQp5lZXk+OF1w70 kswguQHn92Qm1oGHErimniOH/gmF/AMDnXofN7K8FBPFKtTbt4feFdw7MsMaYbAD 1XKn0/ezf+KVKRC7lCCiTEK23InyTkYK46GFtr35xD0ib+Az9x2ReSJX68DA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1653795957; x= 1653882357; bh=WK6kA6QrCwwKMLUCmNwj3NNYnGVd5SuQZRtDlGxvgIM=; b=f G6PDdLVbb8/GJ/ni9Z2Z8luv6q+mzoh37dh3c4jdnB6OxqEqQSPlEoKiE9dp6qrG 7XnGdColZLVXKCpjAY83AXoFdHy08lC59RoyVbdSeIffbb/ALOoXvWayT6ntHjs5 PuZXN7oyyu9jclhrJaMaGhRDyQ2AkmHD0TeDKcTIlIVMvJxUD87Hnn8AxDrBj6ck ksH+EEqNjxz0AIlYMzTt+ntf5mzUPh/ZCPYbaMUx9lYPwgvcKpoAuVHvGFZhPxlg PpBQI8qrytH5y4+MwoJ7nGIdOl6bUiqFLpO61PgnkrM9YsvHtmeV7jUd6ItfItRO Zqq7tzGm+uIlHEWxHEzLQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrkedvgdejfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfvvehfhffujggtgfesthejredttdefjeenucfhrhhomhepvfhomhcu hfhithiihhgvnhhrhicuoehtohhmsehtohhmqdhfihhtiihhvghnrhihrdhmvgdruhhkqe enucggtffrrghtthgvrhhnpefgfeelleeuteefjefgkeeuhfehgedvleeiheegjeegveei jedtudeludfggfefjeenucffohhmrghinhepghhithhlrggsrdgtohhmnecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhomhesthhomhdqfhhi thiihhgvnhhrhidrmhgvrdhukh X-ME-Proxy: Feedback-ID: iefc945ae:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 28 May 2022 23:45:53 -0400 (EDT) Message-ID: Date: Sun, 29 May 2022 13:45:52 +1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Content-Language: en-US To: Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , linux-rockchip@lists.infradead.org Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Samuel Holland , Ondrej Jirman , Martijn Braam References: <20220529031705.278631-1-tom@tom-fitzhenry.me.uk> <20220529031705.278631-3-tom@tom-fitzhenry.me.uk> From: Tom Fitzhenry Subject: Re: [PATCH 2/2] arm64: dts: rockchip: Add initial support for Pine64 PinePhone Pro In-Reply-To: <20220529031705.278631-3-tom@tom-fitzhenry.me.uk> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220528_204600_092020_11DFB743 X-CRM114-Status: UNSURE ( 9.96 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org I've sent this DT for early feedback. I've commented below on the parts I'm unsure about, and would appreciate any feedback. On 29/5/22 13:17, Tom Fitzhenry wrote: > + cluster1_opp_ppp: opp-table1b { I don't know which OPP should be used. Per https://gitlab.com/pine64-org/linux/-/merge_requests/36/diffs?commit_id=dcf78ea8ad6f0b1c6e3279d8d752ca68d6d05756, using the regular RK3399 OPP table exceeds operating conditions. Perhaps this should depend on an OPP for RK3399-T (which would need to be added, as the linked merge request proposes). > + // Per "TYPE-C", page 23. > + fusb0: typec-portc@22 { > + compatible = "fcs,fusb302"; > + reg = <0x22>; > + interrupt-parent = <&gpio1>; > + interrupts = ; > + pinctrl-names = "default"; > + pinctrl-0 = <&fusb0_int>; > + vbus-supply = <&vcc5v0_typec>; This is the node many PinePhone Pro users have been using for >1 month, but I don't understand the USB subsystem well enough yet to understand the node. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel