From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3273FC433F5 for ; Fri, 30 Sep 2022 21:36:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UDe/SWOoogFrR6gJq/W0DZCWIcyPRj1Uu5rko8GrY7Y=; b=vv5ihl4xEsRrJR TEgfnarSkqwkFqjXbH/fj06TvDlm4X3GtRAmiStstBs4DQAKiUOIDbbn6UzNEaYDqvUa/FhX/jKSR l+iH9ThxRhpyMyW+XrzYSXzCjWGf7s24DmvXHHMXmQS3+YK+vnMYER0ZikQhI46n+ITqwjHA1/vqj A36TQVns+CvmO+WhftZsB0AmFN3gnx+Ea03ZIoxhOubAH+gwcQxj49l27+yOfFNzWiNaih0RQ6ZBE spbMzgFBwq6/h8QCqRCvREtmMXRZYwdcD/jIF/J1+2ADhzPrPM25D1hz8QYvOdy4zaBCYPLxo8rTA qW4/QeparHVLbjQRxTRg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oeNf7-00BeIG-Ni; Fri, 30 Sep 2022 21:35:13 +0000 Received: from mail-qt1-x82d.google.com ([2607:f8b0:4864:20::82d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oeNey-00BeE1-Bc for linux-arm-kernel@lists.infradead.org; Fri, 30 Sep 2022 21:35:05 +0000 Received: by mail-qt1-x82d.google.com with SMTP id y2so3466222qtv.5 for ; Fri, 30 Sep 2022 14:35:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=zTs6fvHbkyLzG2YUopzzW4E7mGdZIU1mET/bYxmp2kQ=; b=klemS+egUTYXRtKd1VvIqVdeSIPx0TtpsxzY9VtGzf1+sNVxK9g3UNViSxvvf1IlcY S3jrJtJ3NV7TJvEgh/mwBwZgNFVP66SBMHsZ4VA8KRZB1FOWj4wgmTwcijdHI8Ds8ovS F75885wMo6zqEnnnzyflOQEo5mmXOtbNyvu2DssatZBsQJyGjC3tjPstsLQx/9r0chZh vZxgEaI06QwQiPREVkD53PLfsuekxZqsmaQXF6N6mPmZEtvjuAfdJCiwwcW7wYBKs00l RTqe4TJ6bO4eSnTjNjULlsT6yiYPFnsGiGIwyPG1xx91e8eSgtv8t2U8UAnt9h/hT4rv AHRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=zTs6fvHbkyLzG2YUopzzW4E7mGdZIU1mET/bYxmp2kQ=; b=ZK3KZPETOzUDhdWerNQU3jibdGNcUhz1CumSJ26pCHoQDqBhGKw79CtEXyuqN00c5Y 5sadVd3ZaDe/qMwkB/ZuX5HAWtm89Xs3ICBw4eOllZ2gfyZHyLcPcx4s6/mJgyhTZ85J ALba19lo5SqOaQuEdueQZuukKxWDMQuz+sfVsOBG0YOBypCz0/Z1JI+oexyei9S6CiOd EP/0GJ/wM1YFyiRd6vqn1EAfE/cVBxGXzFMWN5fBjL2WyPMYrTZmXOsapMzYShF3iSUP FzxzaoqeRQb46Ohzd9KcXc0RBUBLgWTZa81L1xddwxmj841/gIwRUui1g2qPZCGQ6GZO 5jwg== X-Gm-Message-State: ACrzQf2j/yz6T23ySgy+kpmo2P7ev7gT9pBDraF6hOo5WREPLKNBHmZC w6D7pWQaZXlW8isszXK86YE= X-Google-Smtp-Source: AMsMyM6KczG9OopdDrJnlYq3saTTts1izUmcmTm9VwQgyszvDx7xG9c///0FGY9T4L7sylDptBRjnA== X-Received: by 2002:ac8:5c8f:0:b0:35c:c6b5:9179 with SMTP id r15-20020ac85c8f000000b0035cc6b59179mr8801713qta.10.1664573701410; Fri, 30 Sep 2022 14:35:01 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id 1-20020ac85901000000b0035cf5edefa6sm3081614qty.56.2022.09.30.14.34.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Sep 2022 14:35:00 -0700 (PDT) Message-ID: Date: Fri, 30 Sep 2022 14:34:53 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] ARM: ubsan: select ARCH_HAS_UBSAN_SANITIZE_ALL Content-Language: en-US To: Kees Cook , William Zhang Cc: Ard Biesheuvel , linux-arm-kernel@lists.infradead.org, Seung-Woo Kim , Russell King , Arnd Bergmann , Linus Walleij , "Russell King (Oracle)" , "Steven Rostedt (Google)" , Nick Hawkins , John Crispin , Masahiro Yamada , Nicolas Schier , Nick Desaulniers , open list , bcm-kernel-feedback-list@broadcom.com, anand.gore@broadcom.com References: <20220928174739.802806-1-f.fainelli@gmail.com> <202209281100.5311EE081B@keescook> <729030b4-c341-966f-05ed-3754122cb4f7@gmail.com> <986bea84-7cc3-9c40-733c-0c766f7a9ebc@broadcom.com> <202209290110.024DC2FE@keescook> From: Florian Fainelli In-Reply-To: <202209290110.024DC2FE@keescook> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220930_143504_472175_3CFA0B01 X-CRM114-Status: GOOD ( 18.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/29/22 01:10, Kees Cook wrote: > On Wed, Sep 28, 2022 at 05:33:14PM -0700, William Zhang wrote: >> >> >> On 09/28/2022 04:06 PM, Florian Fainelli wrote: >>> On 9/28/22 11:01, Kees Cook wrote: >>>> On Wed, Sep 28, 2022 at 10:47:39AM -0700, Florian Fainelli wrote: >>>>> From: Seung-Woo Kim >>>>> >>>>> To enable UBSAN on ARM, this patch enables ARCH_HAS_UBSAN_SANITIZE_ALL >>>>> from arm confiuration. Basic kernel bootup test is passed on arm with >>>>> CONFIG_UBSAN_SANITIZE_ALL enabled. >>>>> >>>>> Signed-off-by: Seung-Woo Kim >>>>> [florian: rebased against v6.0-rc7] >>>>> Signed-off-by: Florian Fainelli >>>> >>>> Ah-ha, thanks for testing this. What devices did you check this on? I >>>> know boot-up on arm32 can be very device-specific. >>> >>> This was tested on an ARCH_BRCMSTB system which is using an ARMv8 CPU >>> booted in AArch32 mode, so virtually equivalent to armv7l. A raspberry >>> Pi 4B is also happily booting with it. >>> >>>> >>>> Which UBSAN configs did you try? >>> >>> All CONFIG_UBSAN_* work with the exception of CONFIG_UBSAN_ALIGNMENT on >>> my ARCH_BRCMSTB system, however it works fine on the Raspberry Pi 4B. >>> Florian >> >> I also tested on a BCM63138 board (ARM A9) under ARCH_BCMBCA using the >> multi_v7_defconfig with all the UBSAN configs enabled except UBSAN_ALIGNMENT >> and board boots up fine. Turning on UBSAN_ALIGNMENT results in flood of >> false positive misaligned-access warnings. This is fine as ARM supports >> unaligned access. >> >> It did catch an out-of-band bug in mach-sunxi smp code. I will submit a >> separate patch to fix that bug. > > Yay! :) Move coverage is great. :) > >> >> Tested-by: William Zhang Submitted to the patch tracker: https://www.armlinux.org.uk/developer/patches/viewpatch.php?id=9253/1 -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel