From: Marc Gonzalez <marc.w.gonzalez@free.fr>
To: Peng Fan <peng.fan@nxp.com>
Cc: Stephen Boyd <sboyd@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
linux-clk <linux-clk@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] clk: imx: pll14xx: initialize flags to 0
Date: Tue, 5 Nov 2019 11:28:42 +0100 [thread overview]
Message-ID: <b6eb44dd-253a-9c85-92dd-dcf1f545e4ec@free.fr> (raw)
In-Reply-To: <AM0PR04MB4481010CA9D3672F55208092887E0@AM0PR04MB4481.eurprd04.prod.outlook.com>
On 05/11/2019 11:04, Peng Fan wrote:
> The patch was initially try to address what [1] did.
> In [1], static was discarded and moved to a common place.
> So I thought flags should be initialized as 0.
A small additional (pedantic) note :-)
Actually, in your case, imx_1443x_pll has "static storage duration".
The "static" keyword ("storage-class specifier") merely limits the
symbol's visibility outside a compilation unit.
Basically, static => "static storage duration"
But the reverse is not true, see 6.2.4p3
https://port70.net/~nsz/c/c11/n1570.html#6.2.4
6.2.4 Storage durations of objects
Regards.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-05 10:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 7:21 [PATCH] clk: imx: pll14xx: initialize flags to 0 Peng Fan
2019-11-05 9:47 ` Marc Gonzalez
2019-11-05 10:04 ` Peng Fan
2019-11-05 10:28 ` Marc Gonzalez [this message]
2019-11-05 11:39 ` Abel Vesa
2019-11-05 12:59 ` Ahmad Fatoum
2019-11-06 1:18 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6eb44dd-253a-9c85-92dd-dcf1f545e4ec@free.fr \
--to=marc.w.gonzalez@free.fr \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).