From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00033C433EF for ; Wed, 29 Jun 2022 05:58:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GStTD3WRzu5zyGv7gcqbyxX8HeOAvfFQmRlTf1c9oIA=; b=4XHZrQu4FsqPwE YdSCtubK7FeLa5gg2uSqt9LNVe56UEENEnGvIude8O5xyoS0ewKQm/FE1zNjk++gfB39iySqLparz dPj8Ym6gxv4onaj00No7XrO7sQudyyTvC1JL4Sj7MX48yR+6tEil/qzM1jDVlaFPjGSmll0QbD5KM IsH8n1yGWJkBFZBnRFkb43FndAK+lG7rS2Gsx0q4HlMw2GtvmVtK1l3Om9iuvTPNKgZJxE6eA8GT4 oykum1/q1sljwEHp172xzMXNAzNF4b7zsE5Jj4/+Bb+cAhCGQ2f8pu1dlR5CKzNV6JzSWpctlVgGW VX5YnsSfA+Uhb/DlBSjQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6Qhx-009gAW-1v; Wed, 29 Jun 2022 05:57:49 +0000 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6Qht-009g9E-Jq for linux-arm-kernel@lists.infradead.org; Wed, 29 Jun 2022 05:57:46 +0000 Received: by mail-ej1-x62a.google.com with SMTP id q6so30262372eji.13 for ; Tue, 28 Jun 2022 22:57:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=1WfdVfNcXkp3OxFuJuEQhMM39v5eC68bY2ADm6rLKI0=; b=JkUoMSVHOd8FXIU1nP7mHg39NA+HAkmXOBLZHIkIRWjuF2QXpez6vuJMIWGUWFHEby 5o4bGCiXixkuKlUlu2olkq0QLN2UOIntPX6lG3+7PbXV+avqVfJ253cahNkw20GGXPeA MHvSKO3EVsTxg+HQtXEwBaZzsvry24d4BvkcEdAr5jVs9aGqW6Xuvyy663JNPBbkngxL ek6xf1/RqwKb2cDwtZy8lrOxsp43tHw2dRO21IpABqGEytjhcHxUraOi/YMWnoRgDrmq fIbCX7sv+Ga3+sPyzf/OYbX6uTY+nt3ooO/FRKAj9IUFTzcd83VY9OMyTF/rzwkUp2rw iYkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=1WfdVfNcXkp3OxFuJuEQhMM39v5eC68bY2ADm6rLKI0=; b=xNveHpeyYgniEtpxJHvHnzwh+hJDlm1TBoLQmipGmuPOFX/Xj1G+oS2/vNyhtozrM8 W0UFM/7ujCisBC+bhOZqTDGbcpreH9l0ylmWAJ7cMaoptIX7Wd30Rn07otjV5oON9rp/ nWM7EP5XKNQsqKEq0MQJSzTY1P3oCS45gJb/nVi1WakVV3jVzZ0V8KAASaRfa2KEWb6f UhY6hFyYgMfg6Qwtssix3Ca5t5glww+x8EIpky9oXFca0D5TvDmIukQBSfygscwYNjQ9 Gs2OzxUxk1nhq/NyM5yy2rfs+Oj9A7MYF/G6mMFDQYIDOkoBdr7MQedSgOLAgnmh0+cg /zcQ== X-Gm-Message-State: AJIora9/Q6b3dHq8m60dBce0wP915OEmbeYYpw30NpBYxnKLlxRzlpzV 57nGabMZB0gg4mIF0yWoM09Z/g== X-Google-Smtp-Source: AGRyM1tKY3/ufkVIb0NqXcBrOPVDKBLhqSVvGuyqn+dsBxeoxntoXm1sQv41p5v8Kn71T36sBhLAmA== X-Received: by 2002:a17:907:7213:b0:726:9f27:8fc8 with SMTP id dr19-20020a170907721300b007269f278fc8mr1551543ejc.523.1656482262769; Tue, 28 Jun 2022 22:57:42 -0700 (PDT) Received: from [192.168.0.181] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id d20-20020aa7ce14000000b00435d4179bbdsm10892308edv.4.2022.06.28.22.57.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Jun 2022 22:57:42 -0700 (PDT) Message-ID: Date: Wed, 29 Jun 2022 07:57:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v5 2/5] dt-bindings: clock: Add AST2500/AST2600 HACE reset definition Content-Language: en-US To: Neal Liu , Corentin Labbe , Christophe JAILLET , Randy Dunlap , Herbert Xu , "David S . Miller" , Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , Dhananjay Phadke , Johnny Huang Cc: linux-aspeed@lists.ozlabs.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, BMC-SW@aspeedtech.com References: <20220629032008.1579899-1-neal_liu@aspeedtech.com> <20220629032008.1579899-3-neal_liu@aspeedtech.com> From: Krzysztof Kozlowski In-Reply-To: <20220629032008.1579899-3-neal_liu@aspeedtech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220628_225745_734241_8D09E736 X-CRM114-Status: GOOD ( 15.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 29/06/2022 05:20, Neal Liu wrote: > Add HACE reset bit definition for AST2500/AST2600. > > Signed-off-by: Neal Liu > Signed-off-by: Johnny Huang > Acked-by: Krzysztof Kozlowski > --- > include/dt-bindings/clock/aspeed-clock.h | 3 ++- > include/dt-bindings/clock/ast2600-clock.h | 1 + > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/include/dt-bindings/clock/aspeed-clock.h b/include/dt-bindings/clock/aspeed-clock.h > index 9ff4f6e4558c..6e040f7c3426 100644 > --- a/include/dt-bindings/clock/aspeed-clock.h > +++ b/include/dt-bindings/clock/aspeed-clock.h > @@ -46,11 +46,12 @@ > #define ASPEED_RESET_MCTP 1 > #define ASPEED_RESET_ADC 2 > #define ASPEED_RESET_JTAG_MASTER 3 > -#define ASPEED_RESET_MIC 4 > +#define ASPEED_RESET_HACE 4 I did not ack such change. This is a significant change from previous version, invalidating my previous ack. This breaks the ABI, so NAK without proper explanation why ABI break is accepted. > #define ASPEED_RESET_PWM 5 > #define ASPEED_RESET_PECI 6 > #define ASPEED_RESET_I2C 7 > #define ASPEED_RESET_AHB 8 > #define ASPEED_RESET_CRT1 9 > +#define ASPEED_RESET_MIC 18 > > #endif > diff --git a/include/dt-bindings/clock/ast2600-clock.h b/include/dt-bindings/clock/ast2600-clock.h > index 62b9520a00fd..d8b0db2f7a7d 100644 > --- a/include/dt-bindings/clock/ast2600-clock.h > +++ b/include/dt-bindings/clock/ast2600-clock.h > @@ -111,6 +111,7 @@ > #define ASPEED_RESET_PCIE_RC_O 19 > #define ASPEED_RESET_PCIE_RC_OEN 18 > #define ASPEED_RESET_PCI_DP 5 > +#define ASPEED_RESET_HACE 4 > #define ASPEED_RESET_AHB 1 > #define ASPEED_RESET_SDRAM 0 > Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel