linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Stefan Wahren <wahrenst@gmx.net>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	Florian Fainelli <f.fainelli@gmail.com>,
	Scott Branden <sbranden@broadcom.com>,
	Ray Jui <rjui@broadcom.com>, Eric Anholt <eric@anholt.net>,
	Rob Herring <robh+dt@kernel.org>,
	bcm-kernel-feedback-list@broadcom.com,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V3 7/8] ARM: dts: Add minimal Raspberry Pi 4 support
Date: Sun, 29 Sep 2019 12:25:19 +0100	[thread overview]
Message-ID: <b75876e1b3c46297142c052e1c6ea0a2@www.loen.fr> (raw)
In-Reply-To: <1569672435-19823-8-git-send-email-wahrenst@gmx.net>

On 2019-09-28 13:07, Stefan Wahren wrote:
> This adds minimal support for the new Raspberry Pi 4 without the
> fancy stuff like GENET, PCIe, xHCI, 40 bit DMA and V3D. The RPi 4 is
> available in 3 different variants (1, 2 and 4 GB RAM), so leave the 
> memory
> size to zero and let the bootloader take care of it. The DWC2 is 
> still
> usable as peripheral via the USB-C port.
>
> Other differences to the Raspberry Pi 3:
> - additional GIC 400 Interrupt controller
> - new thermal IP and HWRNG
> - additional MMC interface (emmc2)
> - additional UART, I2C, SPI and PWM interfaces
> - clock stretching bug in I2C IP has been fixed
>
> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
> Acked-by: Eric Anholt <eric@anholt.net>

[...]

> +	timer {
> +		compatible = "arm,armv8-timer";
> +		interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) |
> +					  IRQ_TYPE_LEVEL_LOW)>,
> +			     <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(4) |
> +					  IRQ_TYPE_LEVEL_LOW)>,
> +			     <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(4) |
> +					  IRQ_TYPE_LEVEL_LOW)>,
> +			     <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(4) |
> +					  IRQ_TYPE_LEVEL_LOW)>;
> +		/* This only applies to the ARMv7 stub */
> +		arm,cpu-registers-not-fw-configured;
> +
> +		/* The ARM cores doesn't enter deep enough states */
> +		always-on;

I already commented on this. The A72 not entering a deep enough sleep 
state to
lose its comparator seems dubious at best. The right way to do this is 
to have
a global timer, which you said the platform has.

Please drop this.

         M.
-- 
Jazz is not dead. It just smells funny...

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-09-29 11:25 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-28 12:07 [PATCH V3 0/8] ARM: Add minimal Raspberry Pi 4 support Stefan Wahren
2019-09-28 12:07 ` [PATCH V3 1/8] ARM: dts: bcm283x: Remove simple-bus from fixed clocks Stefan Wahren
2019-09-28 12:07 ` [PATCH V3 2/8] ARM: dts: bcm283x: Remove brcm, bcm2835-pl011 compatible Stefan Wahren
2019-09-28 12:07 ` [PATCH V3 3/8] ARM: dts: bcm283x: Move BCM2835/6/7 specific to bcm2835-common.dtsi Stefan Wahren
2019-09-28 12:07 ` [PATCH V3 4/8] dt-bindings: arm: Convert BCM2835 board/soc bindings to json-schema Stefan Wahren
2019-10-01 13:46   ` Rob Herring
2019-09-28 12:07 ` [PATCH V3 5/8] dt-bindings: arm: bcm2835: Add Raspberry Pi 4 to DT schema Stefan Wahren
2019-10-01 13:46   ` Rob Herring
2019-09-28 12:07 ` [PATCH V3 6/8] ARM: bcm: Add support for BCM2711 SoC Stefan Wahren
2019-09-28 19:16   ` Florian Fainelli
2019-09-28 23:09     ` Stefan Wahren
2019-09-30  8:21       ` Nicolas Saenz Julienne
2019-09-28 12:07 ` [PATCH V3 7/8] ARM: dts: Add minimal Raspberry Pi 4 support Stefan Wahren
2019-09-28 19:58   ` Florian Fainelli
2019-10-02 16:24     ` Stefan Wahren
2019-10-02 16:43       ` Florian Fainelli
2019-10-06 13:28         ` Stefan Wahren
2019-09-29 11:25   ` Marc Zyngier [this message]
2019-09-28 12:07 ` [PATCH V3 8/8] MAINTAINERS: Add BCM2711 to BCM2835 ARCH Stefan Wahren
2019-09-28 20:01 ` [PATCH V3 0/8] ARM: Add minimal Raspberry Pi 4 support Florian Fainelli
2019-10-03 17:09 ` Nicolas Saenz Julienne
2019-10-03 17:24   ` Stefan Wahren
2019-10-03 22:42     ` Matthias Brugger
2019-10-04  1:03       ` Stefan Wahren
2019-10-04  5:11         ` Matthias Brugger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b75876e1b3c46297142c052e1c6ea0a2@www.loen.fr \
    --to=maz@kernel.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=eric@anholt.net \
    --cc=f.fainelli@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=rjui@broadcom.com \
    --cc=robh+dt@kernel.org \
    --cc=sbranden@broadcom.com \
    --cc=wahrenst@gmx.net \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).