From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00AB0C433EF for ; Wed, 8 Dec 2021 08:52:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EqRqSaxClG30OtgC/iUIibqc6LMuykRLW6RJmFyrILo=; b=HQ5szc5oz/I8rj cQzhUwefe4sSbW21kN1sHZ48Ogna/hhIF4OPrpbJMWT8h7kIWtf9a/ChyQh7Bc8R6gSeERqW7+aL+ umJ+aPh/SV8erKzVgN073wCMaMloX1lFOE5k5XgcR8E1dJQqVb8RwoRFa9kbxBj2MPJ8FtIscUpbX xxHZ/T5Ip5G/sYAlC7GFCIqeOWY+YeIS3gzoFspwo75BtZa7ldOYVftto2OYuqZEpjnzm4ApYNtVu 9BFqGzwRtn7bsu2hbDo82RreWmycLUASWa0DUAiqdGthPeh1i0SA9sNAzkS5f9Bcf+n4Ky68oOlth wpSpNezRa65xh3nUJiFg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1muses-00BmdE-Dk; Wed, 08 Dec 2021 08:50:38 +0000 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1museo-00Bmci-NJ for linux-arm-kernel@lists.infradead.org; Wed, 08 Dec 2021 08:50:36 +0000 Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 0C18F40059 for ; Wed, 8 Dec 2021 08:50:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1638953425; bh=R8HBwd4TyGLCA760Ss3CKjibTlYQFYE0uO0PD5BwZvw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TK0WCa9J9IFlY7mzQvHVgfMZXFEnQ54MInc2YbNefqh0iGz+VidrMOTxFuhBB1hd2 uQPjtEFcjyU6qb08brxPtkMYTUSSCMxRJ/X+hTaZz1Ia1pUE8ZYpcP1ki7YEWQ4z/E al2ry8hDQMK84PCKznnRFQWCfXWedb4BH5a5SnSKIsDgTJsQczkQ44mRLIHVHBidxk OTjOZa2RQQoh7uP6NPmd3nBCofroaFuXBQYss9960rC4UAvsKV1XBe6SNOZiczNEXl nRGWV8/lHglkGGgXdBFz4jn+PINV7UxuCaMOJhqqHJjxm5/e9K/T3pjq7pFzjE2PcS hCTvdEHZFegAw== Received: by mail-lf1-f72.google.com with SMTP id n18-20020a0565120ad200b004036c43a0ddso819910lfu.2 for ; Wed, 08 Dec 2021 00:50:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=R8HBwd4TyGLCA760Ss3CKjibTlYQFYE0uO0PD5BwZvw=; b=Qc63EjAKz5tTduN9Q2q/O1TdrJb2NpUj+fFksXMREsRUBaAn9QjZE8S9XjxtxGuvVZ uesBPGbWqEuSFpjYmdtPXFjAWbuRQ9BHe86ds47+q08AaoZj7Pbn10nY4AO/6YOrj/Hs XlqSaeYGz2kA31fsXfimNJUhG2t7eLrAYX607VjfDXbDueitmkoZl1bPtGf3JADDGkFW D1XkOtAY5ObohQ8Uslt4+AxOAswjzLPztWZFTx8/BoxMc7hShzotoKllr9ui+OP+stAc 7vnkvpuqWhzmn3cWOhmd7IBkcfNMqiRqKs+GAAFxWCBbOo3BPdJlM3ZT3GLyst9jyUAj ho0Q== X-Gm-Message-State: AOAM530ndvyF/Q4rGoQTCs4pTror/cpot6wf2ZjmtPxjRXL/Y5ebjE/a 2JJWXRfKzxrt8ziGYivoaQMQPhMA298zM2s99sL5aeHdrPy1ftlEAo4x5sK8FIlSRXsUSrpYeL+ ykhIKgi6hjRspJi1baHYil6vaOtERdblwewQAHNi1WoJ8VJyt3IQb X-Received: by 2002:a05:651c:1788:: with SMTP id bn8mr47211487ljb.521.1638953424458; Wed, 08 Dec 2021 00:50:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJzzfdCt+FdQcXzsA+ZSP+aXR+YS39/y+RSedwOythLdxan/1Eq+7ijqqQmxhwnxOGZyrtJWww== X-Received: by 2002:a05:651c:1788:: with SMTP id bn8mr47211452ljb.521.1638953424236; Wed, 08 Dec 2021 00:50:24 -0800 (PST) Received: from [192.168.3.67] (89-77-68-124.dynamic.chello.pl. [89.77.68.124]) by smtp.gmail.com with ESMTPSA id k14sm207087ljk.57.2021.12.08.00.50.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Dec 2021 00:50:23 -0800 (PST) Message-ID: Date: Wed, 8 Dec 2021 09:50:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: Re: [PATCH v4 5/7] clk: samsung: clk-pll: Add support for pll1417x Content-Language: en-US To: Sam Protsenko , David Virag Cc: Rob Herring , Sylwester Nawrocki , Tomasz Figa , Chanwoo Choi , Michael Turquette , Stephen Boyd , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org References: <20211206153124.427102-1-virag.david003@gmail.com> <20211206153124.427102-6-virag.david003@gmail.com> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211208_005034_959862_27D84A78 X-CRM114-Status: GOOD ( 21.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 07/12/2021 20:00, Sam Protsenko wrote: > On Mon, 6 Dec 2021 at 17:32, David Virag wrote: >> >> pll1417x is used in Exynos7885 SoC for top-level integer PLLs. >> It is similar enough to pll0822x that practically the same code can >> handle both. The difference that's to be noted is that when defining a >> pl1417x PLL, the "con" parameter of the PLL macro should be set to the >> CON1 register instead of CON3, like this: >> >> PLL(pll_1417x, CLK_FOUT_SHARED0_PLL, "fout_shared0_pll", "oscclk", >> PLL_LOCKTIME_PLL_SHARED0, PLL_CON0_PLL_SHARED0, >> NULL), >> >> Reviewed-by: Krzysztof Kozlowski >> Signed-off-by: David Virag >> --- >> Changes in v2: >> - Nothing >> >> Changes in v3: >> - Nothing >> >> Changes in v4: >> - Added R-b tag by Krzysztof Kozlowski >> >> drivers/clk/samsung/clk-pll.c | 1 + >> drivers/clk/samsung/clk-pll.h | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/drivers/clk/samsung/clk-pll.c b/drivers/clk/samsung/clk-pll.c >> index 83d1b03647db..70cdc87f714e 100644 >> --- a/drivers/clk/samsung/clk-pll.c >> +++ b/drivers/clk/samsung/clk-pll.c >> @@ -1476,6 +1476,7 @@ static void __init _samsung_clk_register_pll(struct samsung_clk_provider *ctx, >> else >> init.ops = &samsung_pll35xx_clk_ops; >> break; >> + case pll_1417x: > > I wonder why this switch have a bunch of fall through cases, but none > marked with "fallthrough;" line, and both checkpatch and "make" turn > blind eye on that? Anyway, I guess it's ok as is, just an observation. > I think the fallthrough is needed for non-obvious cases where one case has some code and misses a break. Something like: switch () { case a: case b: case c: foobar(); } is obvious/explicit and does not need fallthrough. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel