From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47DA5C31E5B for ; Tue, 18 Jun 2019 19:22:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E7FE2064A for ; Tue, 18 Jun 2019 19:22:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lfjHmUbZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E7FE2064A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sipsolutions.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=S5Sfepgvs2k2cQPstOg+c9sIzWYgJucbmCbn7mkPQzE=; b=lfjHmUbZ6jlkAC OIbf2glGfLqn+W89OpQU7CejVG24D2zHiDvRNhW8hxSPscQBvvwlORwqXPQF+Mbex1AyGvqbxErVl SWCyuQVNlQeuEr6RfhhF+CcHevV8ObBhJpsrxgVyltjj3QTRPvvux11jPQ9wgdq+fJqGQK35soZgH adQ0NnVSTjO793ruYDVC+vFypoWoWQ/K0KXnjoNiUMeembKBLU5oMo863F9FfTl/ku46nYOxN7bUF tkdEmFsPNKda4VCbMpvqMWFRhSmoMBTk0BbIZPf6V3CxKM0q8B9T6mIUNgXkzs9Rt1fuag1/lrHFm PtIjtg9hKbxTAX94DJ1w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hdJgb-0003GI-L4; Tue, 18 Jun 2019 19:22:29 +0000 Received: from s3.sipsolutions.net ([2a01:4f8:191:4433::2] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hdJgY-0003Fm-Uc for linux-arm-kernel@lists.infradead.org; Tue, 18 Jun 2019 19:22:28 +0000 Received: by sipsolutions.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1hdJgO-0005LX-Ie; Tue, 18 Jun 2019 21:22:16 +0200 Message-ID: Subject: Re: [PATCH v2 00/17] net: introduce Qualcomm IPA driver From: Johannes Berg To: Alex Elder , Arnd Bergmann Date: Tue, 18 Jun 2019 21:22:14 +0200 In-Reply-To: <31c2c94c-c6d3-595b-c138-faa54d0bfc00@linaro.org> (sfid-20190618_160100_881541_6AD64A3C) References: <380a6185-7ad1-6be0-060b-e6e5d4126917@linaro.org> <583907409fad854bd3c18be688ec2724ad7a60e9.camel@sipsolutions.net> <31c2c94c-c6d3-595b-c138-faa54d0bfc00@linaro.org> (sfid-20190618_160100_881541_6AD64A3C) X-Mailer: Evolution 3.28.5 (3.28.5-2.fc28) Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190618_122226_980948_C6823C30 X-CRM114-Status: GOOD ( 16.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: DTML , syadagir@codeaurora.org, Eric Caruso , Dan Williams , linux-arm-msm@vger.kernel.org, abhishek.esse@gmail.com, Linux Kernel Mailing List , evgreen@chromium.org, Bjorn Andersson , Ilias Apalodimas , Linux ARM , Networking , Subash Abhinov Kasiviswanathan , linux-soc@vger.kernel.org, David Miller , cpratapa@codeaurora.org, Ben Chan Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2019-06-18 at 09:00 -0500, Alex Elder wrote: > Deaggregation is a connection property, not a channel property. That'd make sense, yes. > And it looks like that's exactly how it's used in the rmnet > driver. Yeah, I think you're right. I got confused by the whole use of "port" there, but it seems like "port" actually refers to the underlying netdev. Which is really strange too, btw, because you configure the "port" to agg/non-agg when you add a new channel to it ... So it seems like it's part of the channel configuration, when it's not! Anyway, I think for now we could probably live with not having this configurable for the IPA driver, and if it *does* need to be configurable, it seems like it should be a driver configuration, not a channel configuration - so something like a debugfs hook if you really just need to play with it for performance testing, or a module parameter, or something else? Or even, in the WWAN framework, a knob that we provide there for the WWAN device, rather than for the (newly created) channel. > The hardware is capable of aggregating QMAP packets > arriving on a connection into a single buffer, so this provides > a way of requesting it do that. > > > > #define RMNET_FLAGS_INGRESS_MAP_COMMANDS (1U << 1) > > > > Similar here? If you have flow control you probably want to use it? > > I agree with that, though perhaps there are cases where it > is pointless, or can't be supported, so one might want to > simply *not* implement/advertise the feature. I don't know. Sure, but then that's likely something the driver would need to know, not necessarily userspace? johannes _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel