From: Auger Eric <eric.auger@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>, kvm@vger.kernel.org
Cc: shashi.mallela@linaro.org, alexandru.elisei@arm.com,
qemu-arm@nongnu.org, linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, christoffer.dall@arm.com,
maz@kernel.org
Subject: Re: [kvm-unit-tests PATCH v2 2/4] scripts/arch-run: don't use deprecated server/nowait options
Date: Wed, 26 May 2021 17:05:59 +0200 [thread overview]
Message-ID: <b99b2c07-33e9-7f18-5a43-8ece655fe594@redhat.com> (raw)
In-Reply-To: <20210525172628.2088-3-alex.bennee@linaro.org>
Hi Alex,
On 5/25/21 7:26 PM, Alex Bennée wrote:
> The very fact that QEMU drops the deprecation warning while running is
> enough to confuse the its-migration test into failing. The boolean
> options server and wait have accepted the long form options for a long
> time.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: Shashi Mallela <shashi.mallela@linaro.org>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Eric
> ---
> scripts/arch-run.bash | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/arch-run.bash b/scripts/arch-run.bash
> index 5997e38..70693f2 100644
> --- a/scripts/arch-run.bash
> +++ b/scripts/arch-run.bash
> @@ -122,14 +122,14 @@ run_migration ()
> trap 'kill 0; exit 2' INT TERM
> trap 'rm -f ${migout1} ${migsock} ${qmp1} ${qmp2} ${fifo}' RETURN EXIT
>
> - eval "$@" -chardev socket,id=mon1,path=${qmp1},server,nowait \
> + eval "$@" -chardev socket,id=mon1,path=${qmp1},server=on,wait=off \
> -mon chardev=mon1,mode=control | tee ${migout1} &
>
> # We have to use cat to open the named FIFO, because named FIFO's, unlike
> # pipes, will block on open() until the other end is also opened, and that
> # totally breaks QEMU...
> mkfifo ${fifo}
> - eval "$@" -chardev socket,id=mon2,path=${qmp2},server,nowait \
> + eval "$@" -chardev socket,id=mon2,path=${qmp2},server=on,wait=off \
> -mon chardev=mon2,mode=control -incoming unix:${migsock} < <(cat ${fifo}) &
> incoming_pid=`jobs -l %+ | awk '{print$2}'`
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-26 16:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 17:26 [kvm-unit-tests PATCH v2 0/4] enable LPI and ITS for TCG Alex Bennée
2021-05-25 17:26 ` [kvm-unit-tests PATCH v2 1/4] arm64: remove invalid check from its-trigger test Alex Bennée
2021-05-26 15:06 ` Auger Eric
2021-05-25 17:26 ` [kvm-unit-tests PATCH v2 2/4] scripts/arch-run: don't use deprecated server/nowait options Alex Bennée
2021-05-26 14:23 ` Zenghui Yu
2021-05-26 15:05 ` Auger Eric [this message]
2021-06-01 12:27 ` Andrew Jones
2021-07-13 20:47 ` Andrew Jones
2021-05-25 17:26 ` [kvm-unit-tests PATCH v2 3/4] arm64: enable its-migration tests for TCG Alex Bennée
2021-05-26 15:05 ` Auger Eric
2021-06-01 13:23 ` Andrew Jones
2021-05-25 17:26 ` [kvm-unit-tests PATCH v2 4/4] arm64: split its-migrate-unmapped-collection into KVM and TCG variants Alex Bennée
2021-05-26 16:33 ` Auger Eric
2021-06-01 16:49 ` Alex Bennée
2021-06-01 19:46 ` Andrew Jones
2021-06-01 21:50 ` Alex Bennée
2021-06-01 13:21 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b99b2c07-33e9-7f18-5a43-8ece655fe594@redhat.com \
--to=eric.auger@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=alexandru.elisei@arm.com \
--cc=christoffer.dall@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maz@kernel.org \
--cc=qemu-arm@nongnu.org \
--cc=shashi.mallela@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).