From: Shenming Lu <lushenming@huawei.com>
To: Marc Zyngier <maz@kernel.org>, Eric Auger <eric.auger@redhat.com>,
"Will Deacon" <will@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<kvmarm@lists.cs.columbia.edu>, <kvm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: Alex Williamson <alex.williamson@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
<wanghaibin.wang@huawei.com>, <yuzenghui@huawei.com>
Subject: Re: [PATCH v3 0/4] KVM: arm64: Add VLPI migration support on GICv4.1
Date: Thu, 11 Mar 2021 15:03:21 +0800 [thread overview]
Message-ID: <ba9511e7-a23f-f644-e310-f0bf1bce835a@huawei.com> (raw)
In-Reply-To: <4c2fdcc3-4189-6515-3a68-7bdf26e31973@huawei.com>
Hi,
Sorry to bother again, I am really hoping a response for this series. :-)
Thanks,
Shenming
On 2021/2/26 16:58, Shenming Lu wrote:
> Hi Marc,
>
> Gentle ping. Does this series need any further modification? Wish you can pick it up. :-)
>
> Thanks,
> Shenming
>
> On 2021/1/27 20:13, Shenming Lu wrote:
>> Hi Marc, sorry for the late commit.
>>
>> In GICv4.1, migration has been supported except for (directly-injected)
>> VLPI. And GICv4.1 Spec explicitly gives a way to get the VLPI's pending
>> state (which was crucially missing in GICv4.0). So we make VLPI migration
>> capable on GICv4.1 in this patch set.
>>
>> In order to support VLPI migration, we need to save and restore all
>> required configuration information and pending states of VLPIs. But
>> in fact, the configuration information of VLPIs has already been saved
>> (or will be reallocated on the dst host...) in vgic(kvm) migration.
>> So we only have to migrate the pending states of VLPIs specially.
>>
>> Below is the related workflow in migration.
>>
>> On the save path:
>> In migration completion:
>> pause all vCPUs
>> |
>> call each VM state change handler:
>> pause other devices (just keep from sending interrupts, and
>> such as VFIO migration protocol has already realized it [1])
>> |
>> flush ITS tables into guest RAM
>> |
>> flush RDIST pending tables (also flush VLPI state here)
>> |
>> ...
>> On the resume path:
>> load each device's state:
>> restore ITS tables (include pending tables) from guest RAM
>> |
>> for other (PCI) devices (paused), if configured to have VLPIs,
>> establish the forwarding paths of their VLPIs (and transfer
>> the pending states from kvm's vgic to VPT here)
>>
>> We have tested this series in VFIO migration, and found some related
>> issues in QEMU [2].
>>
>> Links:
>> [1] vfio: UAPI for migration interface for device state:
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a8a24f3f6e38103b77cf399c38eb54e1219d00d6
>> [2] vfio: Some fixes and optimizations for VFIO migration:
>> https://patchwork.ozlabs.org/cover/1413263/
>>
>> History:
>>
>> v2 -> v3
>> - Add the vgic initialized check to ensure that the allocation and enabling
>> of the doorbells have already been done before unmapping the vPEs.
>> - Check all get_vlpi_state related conditions in save_pending_tables in one place.
>> - Nit fixes.
>>
>> v1 -> v2:
>> - Get the VLPI state from the KVM side.
>> - Nit fixes.
>>
>> Thanks,
>> Shenming
>>
>>
>> Shenming Lu (3):
>> KVM: arm64: GICv4.1: Add function to get VLPI state
>> KVM: arm64: GICv4.1: Try to save hw pending state in
>> save_pending_tables
>> KVM: arm64: GICv4.1: Give a chance to save VLPI's pending state
>>
>> Zenghui Yu (1):
>> KVM: arm64: GICv4.1: Restore VLPI's pending state to physical side
>>
>> .../virt/kvm/devices/arm-vgic-its.rst | 2 +-
>> arch/arm64/kvm/vgic/vgic-its.c | 6 +-
>> arch/arm64/kvm/vgic/vgic-v3.c | 61 +++++++++++++++++--
>> arch/arm64/kvm/vgic/vgic-v4.c | 33 ++++++++++
>> arch/arm64/kvm/vgic/vgic.h | 1 +
>> 5 files changed, 93 insertions(+), 10 deletions(-)
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-11 7:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 12:13 [PATCH v3 0/4] KVM: arm64: Add VLPI migration support on GICv4.1 Shenming Lu
2021-01-27 12:13 ` [PATCH v3 1/4] KVM: arm64: GICv4.1: Add function to get VLPI state Shenming Lu
2021-03-11 8:57 ` Marc Zyngier
2021-03-11 12:26 ` Shenming Lu
2021-03-12 8:52 ` Marc Zyngier
2021-01-27 12:13 ` [PATCH v3 2/4] KVM: arm64: GICv4.1: Try to save hw pending state in save_pending_tables Shenming Lu
2021-03-11 9:09 ` Marc Zyngier
2021-03-11 12:31 ` Shenming Lu
2021-03-12 9:02 ` Marc Zyngier
2021-03-12 10:47 ` Shenming Lu
2021-01-27 12:13 ` [PATCH v3 3/4] KVM: arm64: GICv4.1: Restore VLPI's pending state to physical side Shenming Lu
2021-03-11 9:14 ` Marc Zyngier
2021-03-11 12:32 ` Shenming Lu
2021-03-12 9:05 ` Marc Zyngier
2021-03-12 10:48 ` Shenming Lu
2021-03-12 11:10 ` Marc Zyngier
2021-03-12 11:34 ` Shenming Lu
2021-03-12 12:02 ` Marc Zyngier
2021-03-12 12:31 ` Shenming Lu
2021-01-27 12:13 ` [PATCH v3 4/4] KVM: arm64: GICv4.1: Give a chance to save VLPI's pending state Shenming Lu
2021-02-26 8:58 ` [PATCH v3 0/4] KVM: arm64: Add VLPI migration support on GICv4.1 Shenming Lu
2021-03-11 7:03 ` Shenming Lu [this message]
2021-03-11 9:17 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba9511e7-a23f-f644-e310-f0bf1bce835a@huawei.com \
--to=lushenming@huawei.com \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=eric.auger@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=maz@kernel.org \
--cc=wanghaibin.wang@huawei.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).