From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90314C2D0A8 for ; Mon, 28 Sep 2020 11:17:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 432CC2080C for ; Mon, 28 Sep 2020 11:17:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YNWjLy48" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 432CC2080C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1YNPLFq1m9qpINgMRxw6/B6caO5y8fxfoGtnOwxuU2s=; b=YNWjLy48jR68BY6fUIk2wkg2s 00ifwsOXYZts8x9mO63WNagVANDjmYxAKf/2ikKlNW1HpprrfPL34FHItt34VQoNahSS9FLK00x+b gvlgmV9KVibNJaY0eqJ3e63rOHOlXWZGsb3MoQZlo+vvlU8NGZvaBD5MJckCIA5olMvH1wr5amH88 gg/ehAJijuz4PEo/MG7km4lwzXmlrH0wQikjkrn5D9GjfnF46lSSFhql7CUSFfQy3D6J52OE1DRtF MHBXxa/M9WGqO5seDu+/O+cTkpMFumTsWjl2CsXz88R7XP6dN9Rqv/nHxCqzIMZxqHXFAo9FX5k0B F9lfXI8hg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kMr8u-0000y2-Tf; Mon, 28 Sep 2020 11:16:28 +0000 Received: from szxga04-in.huawei.com ([45.249.212.190] helo=huawei.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kMr8s-0000xR-2k for linux-arm-kernel@lists.infradead.org; Mon, 28 Sep 2020 11:16:27 +0000 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 0CE04475641B164B3636; Mon, 28 Sep 2020 19:16:21 +0800 (CST) Received: from [127.0.0.1] (10.174.177.253) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.487.0; Mon, 28 Sep 2020 19:16:14 +0800 Subject: Re: [PATCH v3 10/21] dt-bindings: arm: hisilicon: convert hisilicon, pcie-sas-subctrl bindings to json-schema To: Jonathan Cameron References: <20200927062129.4573-1-thunder.leizhen@huawei.com> <20200927062129.4573-11-thunder.leizhen@huawei.com> <20200928104646.000073ce@Huawei.com> From: "Leizhen (ThunderTown)" Message-ID: Date: Mon, 28 Sep 2020 19:16:13 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20200928104646.000073ce@Huawei.com> Content-Language: en-US X-Originating-IP: [10.174.177.253] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200928_071626_424669_29CF2BAE X-CRM114-Status: GOOD ( 17.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Kefeng Wang , linux-kernel , Wei Xu , Rob Herring , Libin , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020/9/28 17:46, Jonathan Cameron wrote: > On Sun, 27 Sep 2020 14:21:18 +0800 > Zhen Lei wrote: > >> Convert the Hisilicon HiP05/HiP06 PCIe-SAS subsystem controller binding >> to DT schema format using json-schema. >> >> Signed-off-by: Zhen Lei > > One small thing inline to fix. > > Jonathan > >> --- >> .../controller/hisilicon,pcie-sas-subctrl.txt | 15 --------- >> .../controller/hisilicon,pcie-sas-subctrl.yaml | 37 ++++++++++++++++++++++ >> 2 files changed, 37 insertions(+), 15 deletions(-) >> delete mode 100644 Documentation/devicetree/bindings/arm/hisilicon/controller/hisilicon,pcie-sas-subctrl.txt >> create mode 100644 Documentation/devicetree/bindings/arm/hisilicon/controller/hisilicon,pcie-sas-subctrl.yaml >> >> diff --git a/Documentation/devicetree/bindings/arm/hisilicon/controller/hisilicon,pcie-sas-subctrl.txt b/Documentation/devicetree/bindings/arm/hisilicon/controller/hisilicon,pcie-sas-subctrl.txt >> deleted file mode 100644 >> index 43efdaf408f6fe1..000000000000000 >> --- a/Documentation/devicetree/bindings/arm/hisilicon/controller/hisilicon,pcie-sas-subctrl.txt >> +++ /dev/null >> @@ -1,15 +0,0 @@ >> -Hisilicon HiP05/HiP06 PCIe-SAS sub system controller >> - >> -Required properties: >> -- compatible : "hisilicon,pcie-sas-subctrl", "syscon"; >> -- reg : Register address and size >> - >> -The PCIe-SAS sub system controller is shared by PCIe and SAS controllers in >> -HiP05 or HiP06 Soc to implement some basic configurations. >> - >> -Example: >> - /* for HiP05 PCIe-SAS sub system */ >> - pcie_sas: system_controller@b0000000 { >> - compatible = "hisilicon,pcie-sas-subctrl", "syscon"; >> - reg = <0xb0000000 0x10000>; >> - }; >> \ No newline at end of file >> diff --git a/Documentation/devicetree/bindings/arm/hisilicon/controller/hisilicon,pcie-sas-subctrl.yaml b/Documentation/devicetree/bindings/arm/hisilicon/controller/hisilicon,pcie-sas-subctrl.yaml >> new file mode 100644 >> index 000000000000000..8d1341022de587d >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/arm/hisilicon/controller/hisilicon,pcie-sas-subctrl.yaml >> @@ -0,0 +1,37 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/arm/hisilicon/controller/hisilicon,pcie-sas-subctrl.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Hisilicon HiP05/HiP06 PCIe-SAS subsystem controller >> + >> +maintainers: >> + - Wei Xu >> + >> +description: | >> + The PCIe-SAS sub system controller is shared by PCIe and SAS controllers in >> + HiP05 or HiP06 Soc to implement some basic configurations. >> + >> +properties: >> + compatible: >> + items: >> + - const: hisilicon,pcie-sas-subctrl >> + - const: syscon >> + >> + reg: >> + description: Register address and size >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - reg >> + >> +examples: >> + - | >> + /* for HiP05 PCIe-SAS sub system */ >> + pcie_sas: system_controller@b0000000 { >> + compatible = "hisilicon,pcie-sas-subctrl", "syscon"; >> + reg = <0xb0000000 0x10000>; >> + }; >> +... >> \ No newline at end of file > > Trivial, but fix that by adding one. I think I can directly delete "\ No newline at end of file". I looked at some files and all of them did not add blank lines at the end. Whether there is a blank line at enf of file or not, the scripts/checkpatch does not report any warning. > > Jonathan > > > > . > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel