From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=ZaPV=RQ=lists.infradead.org=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS
	autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 182A9C43381
	for <infradead-linux-arm-kernel@archiver.kernel.org>; Wed, 13 Mar 2019 13:50:49 +0000 (UTC)
Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mail.kernel.org (Postfix) with ESMTPS id D9A502177E
	for <infradead-linux-arm-kernel@archiver.kernel.org>; Wed, 13 Mar 2019 13:50:48 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eLkjv47m";
	dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="ad/otPZ1"
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D9A502177E
Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:
	Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive:
	List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From:
	References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date:
	Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;
	 bh=Vc7SepVZgOvwk8qI49Yjsd0BbdJCIn/NX1Yk7b3ziCQ=; b=eLkjv47m5VgN4WAAKZlfdiiwL
	kjCUXbf9zQt7QIcP7xBtVlacj2v7DZXUAMs8WRXqa7u2Q4eCwiQhD2qJROurRlXirZ/9wwnQ1RJcK
	8mWKJ5/A3ZjeXXmbweEeKab9LMqCfp4hDOwRvOOOp8FJ0kEQpXqBuRGQD0qCiSuYx9gX+w5nmE5qB
	S46rt4qfDXJRVyGgWv7ClfLFX7P4J2fyiNnUzKVMQY5o5Ok5qBPacdiqLTUWWSkFaw0q+0XT6P98N
	JLwNVC3d8HvqI1PFYO3OXeEWIMCq3NT5cOmarqA9kOqFa/3wy1YyxxL5YzaBar6vYwwtTgrjaVbMQ
	uP6WphMRQ==;
Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org)
	by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux))
	id 1h44HI-0005E8-1e; Wed, 13 Mar 2019 13:50:40 +0000
Received: from hqemgate16.nvidia.com ([216.228.121.65])
 by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux))
 id 1h44HF-0005DR-Fh
 for linux-arm-kernel@lists.infradead.org; Wed, 13 Mar 2019 13:50:38 +0000
Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by
 hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
 id <B5c890aab0001>; Wed, 13 Mar 2019 06:50:35 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
 by hqpgpgate102.nvidia.com (PGP Universal service);
 Wed, 13 Mar 2019 06:50:36 -0700
X-PGP-Universal: processed;
 by hqpgpgate102.nvidia.com on Wed, 13 Mar 2019 06:50:36 -0700
Received: from [10.25.74.242] (10.124.1.5) by HQMAIL101.nvidia.com
 (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 13 Mar
 2019 13:50:28 +0000
Subject: Re: [PATCH 1/5] irqchip/gic-pm: add driver remove support
To: Marc Zyngier <marc.zyngier@arm.com>, <tglx@linutronix.de>,
 <jason@lakedaemon.net>, <catalin.marinas@arm.com>, <heiko@sntech.de>,
 <horms+renesas@verge.net.au>, <maxime.ripard@bootlin.com>,
 <andy.gross@linaro.org>, <olof@lixom.net>, <bjorn.andersson@linaro.org>,
 <jagan@amarulasolutions.com>, <enric.balletbo@collabora.com>,
 <stefan.wahren@i2se.com>, <ezequiel@collabora.com>,
 <marc.w.gonzalez@free.fr>, <christoffer.dall@arm.com>, <drjones@redhat.com>,
 <julien.thierry@arm.com>
References: <1552474956-25513-1-git-send-email-spujar@nvidia.com>
 <0cd78fb7-4bcb-b735-54ca-24a179b9ff72@arm.com>
From: Sameer Pujar <spujar@nvidia.com>
Message-ID: <bc00b804-2248-4f8b-1537-3e3db151d74d@nvidia.com>
Date: Wed, 13 Mar 2019 19:20:24 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.3
MIME-Version: 1.0
In-Reply-To: <0cd78fb7-4bcb-b735-54ca-24a179b9ff72@arm.com>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To
 HQMAIL101.nvidia.com (172.20.187.10)
Content-Language: en-GB
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
 t=1552485035; bh=3SwpHPghf1PqiRkFu6VgQya4xF3Yy7DP0MzigPG3dio=;
 h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date:
 User-Agent:MIME-Version:In-Reply-To:X-Originating-IP:
 X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding:
 Content-Language;
 b=ad/otPZ1oUlxT2cHsukFKIZALv39qKjqcA9njbns5fadavCS99yAgDjBckBtwy9dN
 TGzRjXd6V9izsLnxsnpAtLmqhRY/IrSTj2RP4oPlGQRN/7htED4JGoRUt+BJccJyd9
 0THPYzNGWqwJbxtM4jVXXr11sI/cLsIxKEA5pIZNXMB7HCeqADxm/JQxdxNFYGSYKq
 CqsUcPaHkYOYLVKEUGN1byAdKdhsIkoOMAYiNLl9Mt+dzAZIf1cLvW76h+H28qjvdZ
 zM6zyGj+P8U3QjbiqxmN6/3WjiU/1UCPsAaGqiarbEXDCdRIQdcSm+NW5Xksmq+RWH
 R2sSxPEKjwB2Q==
X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 
X-CRM114-CacheID: sfid-20190313_065037_539442_75585794 
X-CRM114-Status: GOOD (  11.19  )
X-BeenThere: linux-arm-kernel@lists.infradead.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: <linux-arm-kernel.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, 
 <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/>
List-Post: <mailto:linux-arm-kernel@lists.infradead.org>
List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, 
 <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>
Cc: will.deacon@arm.com, linux-kernel@vger.kernel.org, jonathanh@nvidia.com,
 linux-tegra@vger.kernel.org, treding@nvidia.com,
 linux-arm-kernel@lists.infradead.org
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org>
Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org


On 3/13/2019 4:52 PM, Marc Zyngier wrote:
> First things first:
>
> - Where is the cover letter?
> - This series should be flagged as v2, as it not the same as the one you
> sent last week.
I had the dilemma whether to name this series as v2 or not, thought the 
commits
in the series are different and v2 may not be necessary.
Also felt commit messages are descriptive enough and all belong to 
irq-gic-pm,
hence did not send cover letter.
If you suggest so, I will send a cover letter next patch version(v2)
>
> On 13/03/2019 11:02, Sameer Pujar wrote:
>> This is a preparatory patch for using irq-gic-pm driver as module and thus
>> implement remove() call for the driver. Details of remove() are as below,
>>
>>   * pm_runtime_force_suspend() is added to balance runtime PM, otherwise
>>     following is seen: "agic-controller: Unbalanced pm_runtime_enable!"
>>   * Function gic_teardown() is exported from gic driver and called in remove
>>     to perform io unmap.
>>   * pm_clk_destroy() to free clock resources
>>   * irq is unmapped and freed with irq_dispose_mapping()
>>
> Let's be clear, I have no desire to export any GIC symbol at all. Why
> should we do this? This "driver" is the tiniest thing, and making it
> modular doesn't get us anything.
>
> So what's the rational for doing so?
Reason for this was, the driver gets used for AGIC block and audio is not
boot critical and hence module option was preferred.

Thanks,
Sameer.

>
> Thanks,
>
> 	M.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel