From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8BACEC00144 for ; Mon, 1 Aug 2022 09:58:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3AjRqOkzfgqLUBybhckG27JEni48No39pVUU/49jxlo=; b=fGlGwK/It2tBr7 NwLtNsqdX4dzmkKpUqcczFEDi/AF21UepAv5mCFToA+bYSkAy0L0qTQ17IeLhAue7qICaioMwd+PP AJpn6LAc8rJmVj4OGb/Llk3Zy+2zV3e77eRxppVxLiFIcyW6hvZjHJzn1nxX6V2kr/yq3KPMPB/Zs 3yM8jOzGYJkUq4vH01VoIOtueLsvi1BB2m82zrQsHtz+h75W1V/KMGyJtH46UKVQI1cuz3CqTyV3z D5N96+maI15/DILscD0UyVOPYc6OWNyvp/SSNB8NsD9XfR7+wYttD/gEVf3wFx0ITo9RTurLK3FRh a+KTmRU9MZisaVfGK+/A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oISAU-004jHl-64; Mon, 01 Aug 2022 09:56:59 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oISAP-004jDi-Ex for linux-arm-kernel@lists.infradead.org; Mon, 01 Aug 2022 09:56:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1659347813; x=1690883813; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=4yoPPY+hp3gA4XjcSHsd1Ol8Kvyf5QOlGERbCu3UCOg=; b=AiHIR1Iwdfpj88baQ8hA1YGbrI/UrT5hDC+AEZP1YPodaoSyF+NiNNff Q8xRRehjSu6mkDYmOmfa/QASZBflWhu40S+HXV9f4i6jiOISzcCWjjOs/ EMntAyDkxlp41GEA7RabV2+EYPuZn4h31CxP+JNCQZDcZzUmitZx9dYis vc10kGxskXzyvlYGHSOXz2wWxghRtg6b984ozrIyutH6mGhHzcZOR6LF+ 1SHty5yHyeF2M5NdAf2VoJEyMo6d/KMBZHPYLjETWuVqcuGi3xWnE+Qki 07JDs9vn05c1EBw05BNw7X7Jbsx5jdywpwgWT1SW3nEfhJDg4c/kUr5sL A==; X-IronPort-AV: E=Sophos;i="5.93,206,1654585200"; d="scan'208";a="174562139" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 01 Aug 2022 02:56:48 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 1 Aug 2022 02:56:48 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17 via Frontend Transport; Mon, 1 Aug 2022 02:56:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HtfYA6CoPMEZy2YAa9xIyzDqEZisyNusuAd/aBk/C3PlWQCfUCZsILK0FLqJHZfOV/Zcjk6sM6419GLKy8RwplIPmaJ/paMV0zwKN1yzXekpka2KC5BM0SvC8ZRhNt/g8B1fFEqh88hdjilYIRStGIasJrHHX8zaSGRne2CMGwN2FxztAk+HCajjcOW6t+D6Yk8ZNrRYHLWcHf4Xgy5jLViP2Lp8Oh931rUzsTSMMERd/ETeEttyZmQYWOPKbKwH7iz61+cDpYaVMBzjkqOH9txhnoiK0M37AVf9T1o+QZGi321llDkhoEn0JMuLZ8HZFZkopmg2pMG2HRHDYr+vfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4yoPPY+hp3gA4XjcSHsd1Ol8Kvyf5QOlGERbCu3UCOg=; b=QhhW3FW3yrcRgzEiGQ8IRpuMlOjZKAW5lrjRgv0iRIAAoM++q4Vm6EDd3ggUi0BaIMcgl6lYkAedAK82mkZViPRdI/0szTnLkMDNRsVOisHXAETP9mZ6VcK8VpW7qsw6kgg5VdqNTOgJcEMgFAmrd1NFQgYF2xMJJpeeTGXu9DN6+gAJpzSQCDBkiR0LU46PaiPwKW5Yc/4snQViiwcDln4LCJ5nKdzZJD0q2R10RzqyCsh7KiIHHOK/DPypQyLKsBc9VdC1fCdHaqjHkK9lgBekVnplUaaHfNJqDJO87mgzt6Y3vCj1mh0+qddqHmZPuVAeKcEOMQZvKKI7mmGh7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4yoPPY+hp3gA4XjcSHsd1Ol8Kvyf5QOlGERbCu3UCOg=; b=A8xDQoF9WKpJ8BXxiKuHehuuuZpwsi3JFk+z5Q2YjuDVv9bkIWAcV8ZO+wwGt56HqA6Hs6G18ZIepuA7C5ctXsiP1L2U1H4SQNwkiC4OEPoGML6wYHnnt0sFDmtKwysNn3HrLT3/4uvXrnPZVpcVbgDPqUMC7lEVgbAEjvLkE6g= Received: from BN6PR11MB1953.namprd11.prod.outlook.com (2603:10b6:404:105::14) by BY5PR11MB4497.namprd11.prod.outlook.com (2603:10b6:a03:1cc::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.11; Mon, 1 Aug 2022 09:56:40 +0000 Received: from BN6PR11MB1953.namprd11.prod.outlook.com ([fe80::5c8c:c31f:454d:824c]) by BN6PR11MB1953.namprd11.prod.outlook.com ([fe80::5c8c:c31f:454d:824c%8]) with mapi id 15.20.5482.016; Mon, 1 Aug 2022 09:56:40 +0000 From: To: , , , , , , , CC: , , , , , Subject: Re: [PATCH v2 net-next 1/2] firmware: xilinx: add support for sd/gem config Thread-Topic: [PATCH v2 net-next 1/2] firmware: xilinx: add support for sd/gem config Thread-Index: AQHYpYz/w4ja8yXDQUmz9HznJF0suw== Date: Mon, 1 Aug 2022 09:56:40 +0000 Message-ID: References: <1659123350-10638-1-git-send-email-radhey.shyam.pandey@amd.com> <1659123350-10638-2-git-send-email-radhey.shyam.pandey@amd.com> In-Reply-To: <1659123350-10638-2-git-send-email-radhey.shyam.pandey@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microchip.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: aeb884c5-5b17-4ace-1a89-08da73a421f3 x-ms-traffictypediagnostic: BY5PR11MB4497:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /xRjNzgw0JV1iRGNEJsi5sONhkMVgaisobU0l2iJEpZfVoBy25qooIe2W6BgHcJBxCQT3O4wMmQyrCX5XcrmqN7pSyfBTX7lgmkLucscjl2WKpcAShZQ7vvIwamG0f6aMuH7Nq8P92FvTP1oogIDufDItUZzn7G1YKzkd5aOxknCFXK7GTp8OWgz71fkzUjdaBDLGa1BOhfXpXD9EUmL6E4iwbZYtEd+vN2JENl38uJOj71zJYUJARpTq+BuIPJAKqJI9DKzMSxw/xuV2LLplTVqBs5cHbia1eW8J0SSTslNGK9HOBsoqKTkaDd2RjK2tvhRowm/k/UC/A2Sye3DtUPwRdmXbeTwRL7v1XyStVlhMsvkuHFPCuC3HWV3Ra1kRDRDbuLHgLHIulegAfRNJwEGgdzZ61UzMJN8qX3RpT/jEsAKNxYZyCOCiT2jT1EjQIWWHTzHVYK6P3Pba94mn6Vazxu80SLPn0l4ShWVMTVCEzE5Urch9spYB8Ptsn2MFOVIFkTh/cZOK8TIH3aNcgL1Q0Qajpr9Q0aaTtf5slxV4Nrwx1amrxEIGZgoBQ9DZ1rXqlBHuF4oFbSUOioB99nXuxzvmh6+owSwMw5b2hnKCpPn9kP/6CiODGfd5LWEKWH+hS/15QMvpAtyGNokjLvI8HZzGF2W5oGp1Awfn7ic0CTyWpzkpdozViNXgKCqje5a0ME4tP920m6Orbkug8YpY8IrpRh3cwnL/hQieEpfkF9JY0VT7+DTCOlNg/m38vDgYeiON6qGbdfxI9L8XTtqDVPmeIeWmJTUMvZsPST/ipTXoPovsoBfhfkngghozXeBP6IRqfRQ2FtupZRYcT3dI6mfDFsUcO4ggaLslbRJlCd9R0Syye4ZehiFLswi x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB1953.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(396003)(39860400002)(376002)(366004)(136003)(6506007)(83380400001)(26005)(41300700001)(186003)(6512007)(2616005)(53546011)(38100700002)(38070700005)(122000001)(31696002)(5660300002)(7416002)(2906002)(8936002)(36756003)(478600001)(86362001)(71200400001)(6486002)(66946007)(76116006)(4326008)(8676002)(66556008)(66476007)(66446008)(64756008)(31686004)(316002)(91956017)(54906003)(110136005)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?c3pxamluUVJlWG9jUVNOTE8zbGZGQjhvYno5MUQ3SXQweUZZSWM0d2lMVGta?= =?utf-8?B?NXZxZ3NPTytZVFZobFdVVS8zR2YzWmQveE5zK2dTSXVSa3ZJajhlTGR0eVFY?= =?utf-8?B?SWJOWERrTFBsdnJiLys4c1dZb0c1anhobmRvMWhJdHdRUk1ZTGswYUR0TXZH?= =?utf-8?B?ZjV4bTBZb2FXRCs3bS9KVkx4cEJlWkgvUThwS1pQVWpVdUhhWWkrWmdrQW9V?= =?utf-8?B?bWNkVWJyb2J0TmdQM0JuMjQvekdvWUJUdVpjcklmUDRLU0hrY2dXRXpkaXBF?= =?utf-8?B?M290ZU44R0Y4OUowaENEeDZMcDEwa005ai9FcW5xaDNCM2ZpODEzQ1BoT3NJ?= =?utf-8?B?anFmb0Zxbk1oYVo0ZFVYalBreG5TaXcvcTdaSEN6OFovMHVLYmVQa2J1Tm8x?= =?utf-8?B?QTJjcGVIR2JkWnhYUFBiRlA0MGFYTk0ycllxQUxMQ05FZVJOcEx6WmFKU3VR?= =?utf-8?B?eXFXZ0kzL1lDZVQ2MUN0K0NobjRrSGdvQ25pVWpJK2dySll4czdScGFnL0Rx?= =?utf-8?B?NkhGc0c1M0RubEhMQ1hZY25GRmVUUitpYml5d29ZOWVjbXdtQTdWQjVrd2tR?= =?utf-8?B?MGRTYUsvUEFRc1VmQUJ6YUJQMElweHl6bmt3ZjVRRGE0WVhsUVUzcjJtdVJj?= =?utf-8?B?UU9kb1N1UDJEa0wvNDRNYzBZbmp6KytvUWdidXRqWnVCZTNMazBXTitPUkNT?= =?utf-8?B?cFhhaVBvVzU1QnAvK3VjWXBxcUw4VFQ1T2Zyek16ZGUwVnVoT1RWcDhkRVVi?= =?utf-8?B?R3g0K2EyQ2xmb3VpU2xBenpOZnVRQWlUOU1MNHF2NzdyZ0RtZEhwZUM0Sld1?= =?utf-8?B?ekVMSmVpcFRZZW4yaTVpZkc0cTl5Zm1ZcGxRcXZmdzQvbEN2U0JRaTZFMVNP?= =?utf-8?B?MHdpamJMU3NsTzZOTXc0bUcwekc4eEZBMHJWak82bjZxZXI2K05mZjhZMTJ1?= =?utf-8?B?cnJWbjMxU1lsTUhJZW5mbnQrSm4zdnAvcnJnTHFTaHQ5dXpDb0VnOU1xRTdI?= =?utf-8?B?T2RmMWR2ZjJad2xjeVp2azhBRWE4YTdienRHTnpjL2d3YkRkRm1RRWFEbW81?= =?utf-8?B?akZ1a2NJcFF6a1FBZ2g4TnQzUGlxUVJndFNlUGsyVFRYVWNkUkpoNy9OeVlQ?= =?utf-8?B?QU4yYlA4MStwNW9xUGs3SjcvRVZlSmU0ZUh1WUN5TVpIeTJZaUM3STkyUkR3?= =?utf-8?B?eXZFZk42R1dOcS9xVSsrMGdjejZ4N0FtUXd0Y2d5Ty9Vb05RUEhYRGFndEdu?= =?utf-8?B?OU4wN0tVQmpvdEw3aTdDdmsyRkFkOEVRaSsvVHVvdjBKY0VtMk9IOC8yTkkv?= =?utf-8?B?ZzVGTHQrZXg1WTRERzNtL3RsTzVMNHo0NnRiZjRVbzNneUNHcGo1T25IZllw?= =?utf-8?B?Tk9aSG1nR2pNQksyWUJSM3BiTGVyRDhMZWNlTXh3dnMwSU5JZzE3TXZMNXlF?= =?utf-8?B?ZGkyUEltQWxGSEFkUVdRbElDWnh4VzhrK2owV3JnakJ3cWFoNWZFeUJyazc2?= =?utf-8?B?blg4ZEk2TXoyM0RaYmxsNVRNdzlBNkdFYmlMZFUwOUN1aTg3VWFSY1NyZ01z?= =?utf-8?B?QXVJOU1ESG5rb0JpRDVQb1NSbDEwZ2pnTUVzdlVBYmRxaXVlTS9kZUNDTWJO?= =?utf-8?B?VjI0aTh5aWhKWldIdkhEQzJMVis2Rk84MjhKdmxOZVY4Y3lwam1mcVk0d1hZ?= =?utf-8?B?MTh2N0tqUnNrUGduU3dlalhZK1p1amkrK01CYk9STzR3SEpBUjFCVFIzOEla?= =?utf-8?B?M3ZBV0JEakJkWkw0VFNUVk0wQk5FWlIzUHRxME1sdHJKYkJ5WUk2dGswc1NM?= =?utf-8?B?NUdpYkZMVmRVQ2hXWS9iWE9zTFgySmEzbVFPL3JrZ2poSkFzUWY3WDFXUlNn?= =?utf-8?B?Vk1YYlRnMWc2RUR6aUlGWEJPS0RucU5ZblJoaGQySVRZU1REbUdJUlgybnlt?= =?utf-8?B?Uno3TExzaWhHQlE4RFJGUnlkRys3M0J3TW40SFkySlBUZWlVWm16ZmhzZDFU?= =?utf-8?B?dlJXazBiRDJMditReGMreFFGVFJMcVd6d1ZJVnpJaFpJUXB1M1hHbVZCaXM5?= =?utf-8?B?d2twbDh5VTR5d1ZZaGxZQ3ZCR3RwS2EweTlMVzVDb2ZVVGNHS2lxS29hOVNm?= =?utf-8?B?dGFJVnQ0WTNoaG9pVlFObzdUU0UvNVZrUG8wOU5PV1I0N0ZVU2taZmVhWVdJ?= =?utf-8?B?Q2c9PQ==?= Content-ID: <397651ABEEFD614DAB3ABBF919698EB7@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB1953.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: aeb884c5-5b17-4ace-1a89-08da73a421f3 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Aug 2022 09:56:40.7444 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: b2D01ncjHh4mekyz/OnTi2FPMCv8SxyKtlZQC5jeBIiPOTVR/TGJNvGcoe6wFbcMKyzTnjwasOTNOAJCjelq/WGZ3KdVWmjKdEig0XlQQfY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4497 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220801_025653_545939_ED6C1A07 X-CRM114-Status: GOOD ( 23.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 29.07.2022 22:35, Radhey Shyam Pandey wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > From: Ronak Jain > > Add new APIs in firmware to configure SD/GEM registers. Internally > it calls PM IOCTL for below SD/GEM register configuration: > - SD/EMMC select > - SD slot type > - SD base clock > - SD 8 bit support > - SD fixed config > - GEM SGMII Mode > - GEM fixed config > > Signed-off-by: Ronak Jain > Signed-off-by: Radhey Shyam Pandey > --- > Changes for v2: > - Use tab indent for zynqmp_pm_set_sd/gem_config return documentation. > --- > drivers/firmware/xilinx/zynqmp.c | 31 +++++++++++++++++++++++++++++++ > include/linux/firmware/xlnx-zynqmp.h | 33 +++++++++++++++++++++++++++++++++ > 2 files changed, 64 insertions(+) > > diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c > index 7977a494a651..44c44077dfc5 100644 > --- a/drivers/firmware/xilinx/zynqmp.c > +++ b/drivers/firmware/xilinx/zynqmp.c > @@ -1298,6 +1298,37 @@ int zynqmp_pm_get_feature_config(enum pm_feature_config_id id, > } > > /** > + * zynqmp_pm_set_sd_config - PM call to set value of SD config registers > + * @node: SD node ID > + * @config: The config type of SD registers > + * @value: Value to be set > + * > + * Return: Returns 0 on success or error value on failure. > + */ > +int zynqmp_pm_set_sd_config(u32 node, enum pm_sd_config_type config, u32 value) > +{ > + return zynqmp_pm_invoke_fn(PM_IOCTL, node, IOCTL_SET_SD_CONFIG, > + config, value, NULL); > +} > +EXPORT_SYMBOL_GPL(zynqmp_pm_set_sd_config); > + > +/** > + * zynqmp_pm_set_gem_config - PM call to set value of GEM config registers > + * @node: GEM node ID > + * @config: The config type of GEM registers > + * @value: Value to be set > + * > + * Return: Returns 0 on success or error value on failure. > + */ > +int zynqmp_pm_set_gem_config(u32 node, enum pm_gem_config_type config, > + u32 value) > +{ > + return zynqmp_pm_invoke_fn(PM_IOCTL, node, IOCTL_SET_GEM_CONFIG, > + config, value, NULL); > +} > +EXPORT_SYMBOL_GPL(zynqmp_pm_set_gem_config); > + > +/** > * struct zynqmp_pm_shutdown_scope - Struct for shutdown scope > * @subtype: Shutdown subtype > * @name: Matching string for scope argument > diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux/firmware/xlnx-zynqmp.h > index 1ec73d5352c3..063a93c133f1 100644 > --- a/include/linux/firmware/xlnx-zynqmp.h > +++ b/include/linux/firmware/xlnx-zynqmp.h > @@ -152,6 +152,9 @@ enum pm_ioctl_id { > /* Runtime feature configuration */ > IOCTL_SET_FEATURE_CONFIG = 26, > IOCTL_GET_FEATURE_CONFIG = 27, > + /* Dynamic SD/GEM configuration */ > + IOCTL_SET_SD_CONFIG = 30, > + IOCTL_SET_GEM_CONFIG = 31, > }; > > enum pm_query_id { > @@ -393,6 +396,18 @@ enum pm_feature_config_id { > PM_FEATURE_EXTWDT_VALUE = 4, > }; > > +enum pm_sd_config_type { > + SD_CONFIG_EMMC_SEL = 1, /* To set SD_EMMC_SEL in CTRL_REG_SD and SD_SLOTTYPE */ > + SD_CONFIG_BASECLK = 2, /* To set SD_BASECLK in SD_CONFIG_REG1 */ > + SD_CONFIG_8BIT = 3, /* To set SD_8BIT in SD_CONFIG_REG2 */ > + SD_CONFIG_FIXED = 4, /* To set fixed config registers */ > +}; > + > +enum pm_gem_config_type { > + GEM_CONFIG_SGMII_MODE = 1, /* To set GEM_SGMII_MODE in GEM_CLK_CTRL register */ > + GEM_CONFIG_FIXED = 2, /* To set fixed config registers */ > +}; As you adapted kernel style documentation for the rest of code added in this patch you can follow this rules for enums, too. > + > /** > * struct zynqmp_pm_query_data - PM query data > * @qid: query ID > @@ -468,6 +483,9 @@ int zynqmp_pm_feature(const u32 api_id); > int zynqmp_pm_is_function_supported(const u32 api_id, const u32 id); > int zynqmp_pm_set_feature_config(enum pm_feature_config_id id, u32 value); > int zynqmp_pm_get_feature_config(enum pm_feature_config_id id, u32 *payload); > +int zynqmp_pm_set_sd_config(u32 node, enum pm_sd_config_type config, u32 value); > +int zynqmp_pm_set_gem_config(u32 node, enum pm_gem_config_type config, > + u32 value); > #else > static inline int zynqmp_pm_get_api_version(u32 *version) > { > @@ -733,6 +751,21 @@ static inline int zynqmp_pm_get_feature_config(enum pm_feature_config_id id, > { > return -ENODEV; > } > + > +static inline int zynqmp_pm_set_sd_config(u32 node, > + enum pm_sd_config_type config, > + u32 value) > +{ > + return -ENODEV; > +} > + > +static inline int zynqmp_pm_set_gem_config(u32 node, > + enum pm_gem_config_type config, > + u32 value) > +{ > + return -ENODEV; > +} > + > #endif > > #endif /* __FIRMWARE_ZYNQMP_H__ */ > -- > 2.1.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel