From: Michal Simek <michal.simek@xilinx.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Rajan Vaja <rajan.vaja@xilinx.com>,
Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
linux-kernel@vger.kernel.org,
Michal Simek <michal.simek@xilinx.com>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 21/21] clk: zynqmp: divider: Add missing description for 'max_div'
Date: Tue, 26 Jan 2021 13:51:56 +0100 [thread overview]
Message-ID: <bceb3499-4b74-5773-961d-84c66835e13a@xilinx.com> (raw)
In-Reply-To: <20210126124540.3320214-22-lee.jones@linaro.org>
On 1/26/21 1:45 PM, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/clk/zynqmp/divider.c:46: warning: Function parameter or member 'max_div' not described in 'zynqmp_clk_divider'
>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Cc: Rajan Vaja <rajan.vaja@xilinx.com>
> Cc: linux-clk@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/clk/zynqmp/divider.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/zynqmp/divider.c b/drivers/clk/zynqmp/divider.c
> index 66da02b83d393..e9bf7958b8218 100644
> --- a/drivers/clk/zynqmp/divider.c
> +++ b/drivers/clk/zynqmp/divider.c
> @@ -35,6 +35,7 @@
> * @is_frac: The divider is a fractional divider
> * @clk_id: Id of clock
> * @div_type: divisor type (TYPE_DIV1 or TYPE_DIV2)
> + * @max_div: maximum supported divisor (fetched from firmware)
> */
> struct zynqmp_clk_divider {
> struct clk_hw hw;
>
In our soc tree we have
* @max_div: Maximum divisor value allowed
But your description should be also fine. Rajan please reply if I am
wrong. Otherwise:
Acked-by: Michal Simek <michal.simek@xilinx.com>
Thanks,
Michal
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-26 12:54 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 12:45 [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock Lee Jones
2021-01-26 12:45 ` [PATCH 01/21] clk: zynq: pll: Fix kernel-doc formatting in 'clk_register_zynq_pll's header Lee Jones
2021-01-26 12:58 ` Michal Simek
2021-02-11 19:54 ` Stephen Boyd
2021-01-26 12:45 ` [PATCH 05/21] clk: sunxi: clk-sun9i-core: Demote non-conformant kernel-doc headers Lee Jones
2021-01-26 12:45 ` [PATCH 06/21] clk: sunxi: clk-usb: Demote obvious kernel-doc abuse Lee Jones
2021-01-26 12:45 ` [PATCH 08/21] clk: clkdev: Ignore suggestion to use gnu_printf() as it's not appropriate here Lee Jones
2021-02-11 19:23 ` Stephen Boyd
2021-02-12 9:36 ` Lee Jones
2021-03-10 8:59 ` Lee Jones
2021-01-26 12:45 ` [PATCH 12/21] clk: sunxi: clk-sun6i-ar100: Demote non-conformant kernel-doc header Lee Jones
2021-01-26 15:54 ` Maxime Ripard
2021-01-26 16:54 ` Lee Jones
2021-02-03 9:27 ` Maxime Ripard
2021-02-03 10:09 ` Lee Jones
2021-01-26 12:45 ` [PATCH 19/21] clk: spear: Move prototype to accessible header Lee Jones
2021-01-27 4:36 ` Viresh Kumar
2021-02-11 19:58 ` Stephen Boyd
2021-01-26 12:45 ` [PATCH 20/21] clk: imx: Move 'imx6sl_set_wait_clk()'s prototype out " Lee Jones
2021-01-30 14:13 ` Shawn Guo
2021-01-26 12:45 ` [PATCH 21/21] clk: zynqmp: divider: Add missing description for 'max_div' Lee Jones
2021-01-26 12:51 ` Michal Simek [this message]
2021-02-11 19:58 ` Stephen Boyd
2021-02-03 8:31 ` [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock Lee Jones
2021-02-05 18:55 ` Stephen Boyd
2021-02-05 19:19 ` Lee Jones
2021-02-08 6:45 ` Tero Kristo
2021-02-11 20:47 ` Stephen Boyd
2021-02-11 21:10 ` Lee Jones
2021-02-12 3:07 ` Stephen Boyd
2021-02-12 9:20 ` Lee Jones
2021-02-12 21:02 ` Stephen Boyd
2021-02-12 21:25 ` Lee Jones
2021-02-12 21:26 ` Lee Jones
2021-02-12 22:05 ` Stephen Boyd
2021-02-12 22:37 ` Lee Jones
2021-02-13 0:06 ` Stephen Boyd
2021-02-13 16:04 ` Andrew Lunn
[not found] ` <161333644244.1254594.4498059850307971318@swboyd.mtv.corp.google.com>
2021-02-14 21:20 ` Andrew Lunn
2021-02-15 8:49 ` Lee Jones
2021-02-15 17:45 ` Jakub Kicinski
2021-02-16 8:20 ` Lee Jones
2021-02-17 18:08 ` Jakub Kicinski
2021-02-18 9:31 ` Lee Jones
2021-02-13 15:58 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bceb3499-4b74-5773-961d-84c66835e13a@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=rajan.vaja@xilinx.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).