From: Miaoqian Lin <linmq006@gmail.com>
To: Miles Chen <miles.chen@mediatek.com>
Cc: bhelgaas@google.com, jianjun.wang@mediatek.com, kw@linux.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-pci@vger.kernel.org, lorenzo.pieralisi@arm.com,
matthias.bgg@gmail.com, maz@kernel.org, robh@kernel.org,
ryder.lee@mediatek.com
Subject: Re: [PATCH] PCI: mediatek-gen3: Fix refcount leak in mtk_pcie_init_irq_domains
Date: Sat, 28 May 2022 17:19:38 +0800 [thread overview]
Message-ID: <bd03ca71-1875-2e94-8040-533034f76ee5@gmail.com> (raw)
In-Reply-To: <20220527084525.7170-1-miles.chen@mediatek.com>
Hi Miles,
On 2022/5/27 16:45, Miles Chen wrote:
> Hi Miaoqian,
>
>> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
>> ---
>> drivers/pci/controller/pcie-mediatek-gen3.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/controller/pcie-mediatek-gen3.c
>> index 3e8d70bfabc6..da8e9db0abdf 100644
>> --- a/drivers/pci/controller/pcie-mediatek-gen3.c
>> +++ b/drivers/pci/controller/pcie-mediatek-gen3.c
>> @@ -600,6 +600,7 @@ static int mtk_pcie_init_irq_domains(struct mtk_gen3_pcie *pcie)
>> &intx_domain_ops, pcie);
>> if (!pcie->intx_domain) {
>> dev_err(dev, "failed to create INTx IRQ domain\n");
>> + of_node_put(intc_node);
>> return -ENODEV;
>> }
> Thanks for doing this.
>
> I checked mtk_pcie_init_irq_domains() and there are multiple exit paths like
> err_msi_domain and err_msi_bottom_domain and the normal path which also
> need of_node_put(intc_node).
Thanks for your reply,
I didn't add of_node_put() in other paths because I am not sure if the reference passed through irq_domain_add_linear(), since intc_node is passed to irq_domain_add_linear().
__irq_domain_add() keeps &node->fwnode in the irq_domain structure.
and use fwnode_handle_get() to get the reference of fwnode, but I still uncertain.
If the reference don't needed anymore after irq_domain_add_linear(),
your suggestion looks fine, and I will submit v2.
> Maybe we can move the of_node_put(intc_node) to #54 below and cover
> all possible paths?
>
>
> cheers,
> Miles
>
> e.g.,
>
> static int mtk_pcie_init_irq_domains(struct mtk_gen3_pcie *pcie)
> {
> struct device *dev = pcie->dev;
> struct device_node *intc_node, *node = dev->of_node;
> int ret;
>
> raw_spin_lock_init(&pcie->irq_lock);
>
> /* Setup INTx */
> intc_node = of_get_child_by_name(node, "interrupt-controller");
> if (!intc_node) {
> dev_err(dev, "missing interrupt-controller node\n");
> return -ENODEV;
> }
>
> pcie->intx_domain = irq_domain_add_linear(intc_node, PCI_NUM_INTX,
> &intx_domain_ops, pcie);
> of_node_put(intc_node);
> if (!pcie->intx_domain) {
> dev_err(dev, "failed to create INTx IRQ domain\n");
> return -ENODEV;
> }
>
> /* Setup MSI */
> mutex_init(&pcie->lock);
>
> pcie->msi_bottom_domain = irq_domain_add_linear(node, PCIE_MSI_IRQS_NUM,
> &mtk_msi_bottom_domain_ops, pcie);
> if (!pcie->msi_bottom_domain) {
> dev_err(dev, "failed to create MSI bottom domain\n");
> ret = -ENODEV;
> goto err_msi_bottom_domain;
> }
>
> pcie->msi_domain = pci_msi_create_irq_domain(dev->fwnode,
> &mtk_msi_domain_info,
> pcie->msi_bottom_domain);
> if (!pcie->msi_domain) {
> dev_err(dev, "failed to create MSI domain\n");
> ret = -ENODEV;
> goto err_msi_domain;
> }
>
> return 0;
>
> err_msi_domain:
> irq_domain_remove(pcie->msi_bottom_domain);
> err_msi_bottom_domain:
> irq_domain_remove(pcie->intx_domain);
>
> return ret;
> }
>> --
>> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-28 9:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 11:02 [PATCH] PCI: mediatek-gen3: Fix refcount leak in mtk_pcie_init_irq_domains Miaoqian Lin
2022-05-26 18:44 ` Rob Herring
2022-05-27 8:45 ` Miles Chen
2022-05-28 9:19 ` Miaoqian Lin [this message]
2022-05-30 2:19 ` Miles Chen
2022-05-30 6:54 ` Miaoqian Lin
2022-05-30 7:35 ` Miles Chen
2022-05-31 14:01 ` Miaoqian Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd03ca71-1875-2e94-8040-533034f76ee5@gmail.com \
--to=linmq006@gmail.com \
--cc=bhelgaas@google.com \
--cc=jianjun.wang@mediatek.com \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=maz@kernel.org \
--cc=miles.chen@mediatek.com \
--cc=robh@kernel.org \
--cc=ryder.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).