From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53E28C433ED for ; Wed, 14 Apr 2021 09:21:10 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 10DFA60720 for ; Wed, 14 Apr 2021 09:21:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 10DFA60720 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=hisilicon.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dWhzQRcTjXXIwL03mozO8WzYVgLyf7aP71BC22+OPt4=; b=cjnEt0+tUdHaG2wo4PB3KHMQZ kiSr6ye8V7PpmrnXnyemQ1+dvGlfynZid4yzPwZPhstN6L4/8vo6PDwQ7bzynGsth3mPEmIyuH5Ju a4Loy/kslYLk6BJpQ0CU9VGGWPv5X3+H+zJqkqyHiBmTCECMoTSFHMyiuj7LRt5uZkhXM8258q3DG kyIBsloRsCDkX/m3wx602U2YU9oF7Hd1X/flSTkHNdDsIWCvfmwHCZRRBSQLIgqxzjmOAFs1IQKCh NwCBqUdzmMbnt3hgjIFZjKWoj5tdCgSCKdQdjKivMy0P9yeECmu14BjZuQrGmHnIOb6ZqKWoEE76t hfWgaifpQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lWbgP-00C7qv-LG; Wed, 14 Apr 2021 09:19:37 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWbgK-00C7ok-Tg for linux-arm-kernel@desiato.infradead.org; Wed, 14 Apr 2021 09:19:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:CC:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=mhTZCzNlhwxHcgmoqJ9EMvw9/NzJzvGA87GJpL9JUmw=; b=tyGKnYNOMBzicug8m80jrNWQMl sJ4An4yFa8/3mDHjzIf2WdTv3ypPRFTR1XOqsmhMb8+KQRwu1J3ZaMQTFjFFZejpnUPdFep/YAmHZ ZTnb5VI2j0/cfb6NpZ4LlWH/v64MzhovIsa8zrE3InLkE3hqVd7WSrnlndHeISCtZJ98A4LIVW7Tb fuY2bTO//HG+TchUTuXoa3R6LrjwuSDPO/PDBJecsfQ8rRBnOlTdL/ZrXoo/3w2jJLaspCPZlJQYP isjHH3PWhxRvv3y7D6xi9hSSqowJItEJrqRCAQwr1Mf7RfZID+6l5isCbRnulIMLkgSRSsBw/vzH3 xwN9BLVw==; Received: from szxga07-in.huawei.com ([45.249.212.35]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWbgH-007eGR-J9 for linux-arm-kernel@lists.infradead.org; Wed, 14 Apr 2021 09:19:31 +0000 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4FKxgb1xhRz9yZX; Wed, 14 Apr 2021 17:16:59 +0800 (CST) Received: from [127.0.0.1] (10.69.38.196) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.498.0; Wed, 14 Apr 2021 17:19:07 +0800 Subject: Re: [PATCH] i2c: I2C_HISI should depend on ARCH_HISI && ACPI To: Geert Uytterhoeven , Wei Xu , Wolfram Sang CC: Andy Shevchenko , Dmitry Osipenko , , , , Linuxarm References: <26db9291095c1dfd81c73b0f5f1434f9b399b1f5.1618316565.git.geert+renesas@glider.be> From: Yicong Yang Message-ID: Date: Wed, 14 Apr 2021 17:19:07 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <26db9291095c1dfd81c73b0f5f1434f9b399b1f5.1618316565.git.geert+renesas@glider.be> X-Originating-IP: [10.69.38.196] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210414_021930_067231_F7AC932B X-CRM114-Status: GOOD ( 17.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2021/4/13 20:26, Geert Uytterhoeven wrote: > The HiSilicon Kunpeng I2C controller is only present on HiSilicon > Kunpeng SoCs, and its driver relies on ACPI to probe for its presence. > Hence add dependencies on ARCH_HISI and ACPI, to prevent asking the user > about this driver when configuring a kernel without Hisilicon platform > or ACPI firmware support. > this is a public IP which doesn't specifically depend on ARCH_HISI. I'm not sure all the platform this IP on has ARCH_HISI configured. The driver will not be compiled by default config. This is not correct to have this dependence. > Fixes: d62fbdb99a85730a ("i2c: add support for HiSilicon I2C controller") > Signed-off-by: Geert Uytterhoeven > --- > drivers/i2c/busses/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig > index b5b4e0d0ff4dd0bc..3ead6d9e130b2ebc 100644 > --- a/drivers/i2c/busses/Kconfig > +++ b/drivers/i2c/busses/Kconfig > @@ -647,7 +647,7 @@ config I2C_HIGHLANDER > > config I2C_HISI > tristate "HiSilicon I2C controller" > - depends on ARM64 || COMPILE_TEST > + depends on (ARM64 && ARCH_HISI && ACPI) || COMPILE_TEST > help > Say Y here if you want to have Hisilicon I2C controller support > available on the Kunpeng Server. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel