From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0392EC32772 for ; Tue, 23 Aug 2022 10:26:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7hmb8E5BDF129QaQidtD+v3TCB+VojNvnB/ihBXTgT0=; b=RWUSyrkYZ6TxQO hlePNGhgGFlYevN1ZpvWYD2ktEJwn18g/mGyJRKmvQ8R6Kk1jE/bN3Xk0DOAK1LJkevLOHZ7Tbg91 0Wn2mF00UL1Z6ig5BoFOQclnx9/QHxoAThoRjBnEwDz9+k/2Yn9e0dA5sTVOSf4eU+6TrzymMTCM4 Y1qEa0CxseMcsqtndSwXIk6EAGwgsPcitjakcqoZ59F2Fw7xpBZpEAqa01Ypd6+lBMkk4aKICzOUY 4lrP3XwHSkRy4aKd8ood5kcOfHhwKgOd/UOQUXxfkkRMr09PibD+KkEuqdbxFXReP3AnDel+4UyS3 kwkHTexyXjDylCA1+1lA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQR5Y-004v52-QL; Tue, 23 Aug 2022 10:24:53 +0000 Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQR5I-004uxY-5V for linux-arm-kernel@lists.infradead.org; Tue, 23 Aug 2022 10:24:39 +0000 Received: by mail-lf1-x130.google.com with SMTP id m5so8374235lfj.4 for ; Tue, 23 Aug 2022 03:24:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=1E0cCe5cEaQJfe86WNnJmjkEbqjIELBXQL3k/KZdD48=; b=QSA3yhWCG+SVJuohL5IMAtHe2qODfXcRxnbjC0pXCGrCLc01hGLKlYJjItBNEgYh4P 2oqodZ1jRtDXD5Oc3bAfumtqxB5IQ6YdRiiPRZ7OrrnwI3Pu4U3mMOjhhgnvx877F1ch jtf1HReSx9JOob/Orgo1zPyhaK2lJsT7nxaXQsiraZ8a68CQwQp1q4W8+7L3CTN6YwC9 f8XJY2cEoQvDXtcfWF/QPBl1q54iQfuUwh4R3Gb7chQMxLr07oGYnUKawwkyE/qfQQIZ I640N+no44vjt4uJ172x7uqbiH+3N1d2WMGNnw+9A4G9Drc3v+qgsFLUOQuUs4rUYPET b7Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=1E0cCe5cEaQJfe86WNnJmjkEbqjIELBXQL3k/KZdD48=; b=D6D9qFUCF6/RYpYpaAuq4+arPSuvy163tR8ez3dtES6lWy3kZ6Xn2IaUBdLmlZeEzN NXNPaRfQy3gxRLqj1zSNV5OBtgvGr/th/jBgg9CRFbRl67+PvnZ8WA12X+KsS7Q3hAfj SQ7xEKUb+II3lDQTENprjYtCY6oGIXXundabrb0Gf42ikoXjQpEHT0AKtDDwHvFMj1ZS 4OyPF+jSZPjf4pCvqe5uS02I8Is1fmAtHXX+FD1dro27/AaA/ta894wxSBTJaTmSoN8B XpZ7d18m4spqAeJeJBusVhGB13XRI+U08/VH1d1nH7ZdL3QwJTthM3UtcjkYbCeikVdo UM9g== X-Gm-Message-State: ACgBeo2Ut2F2jVhJyW8UmzxIrQrV1toYxbEqbLdEfHIxJj/YQqiVsqDa OX1+jWSmUW7tpeY4xQL9lusJsw== X-Google-Smtp-Source: AA6agR6el3uDAHqHIosEoBa7BJJVdeCX9cSrpx/F0nnzHgPz/5FfAVCMOm6iQIFk/R8G13WzCYBggA== X-Received: by 2002:a05:6512:3e25:b0:492:db16:4636 with SMTP id i37-20020a0565123e2500b00492db164636mr4317221lfv.657.1661250271586; Tue, 23 Aug 2022 03:24:31 -0700 (PDT) Received: from [192.168.0.11] (89-27-92-210.bb.dnainternet.fi. [89.27.92.210]) by smtp.gmail.com with ESMTPSA id o3-20020ac24e83000000b00492d7a7b4e3sm1655294lfr.4.2022.08.23.03.24.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Aug 2022 03:24:31 -0700 (PDT) Message-ID: Date: Tue, 23 Aug 2022 13:24:30 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 2/7] dt-bindings: phy: mediatek,tphy: add property to set pre-emphasis Content-Language: en-US To: Chunfeng Yun , Vinod Koul , Rob Herring Cc: Kishon Vijay Abraham I , Krzysztof Kozlowski , Matthias Brugger , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Eddie Hung References: <20220819091344.2274-1-chunfeng.yun@mediatek.com> <20220819091344.2274-2-chunfeng.yun@mediatek.com> <438da392-f419-ad76-7e91-aa4aab36e12c@linaro.org> <816ecf6287533137b750c8bde9de5830e4229c56.camel@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <816ecf6287533137b750c8bde9de5830e4229c56.camel@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220823_032436_289247_F810DE73 X-CRM114-Status: GOOD ( 15.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 22/08/2022 10:07, Chunfeng Yun wrote: > On Fri, 2022-08-19 at 15:15 +0300, Krzysztof Kozlowski wrote: >> On 19/08/2022 12:13, Chunfeng Yun wrote: >>> Add a property to set usb2 phy's pre-emphasis. >>> >>> Signed-off-by: Chunfeng Yun >>> --- >>> Documentation/devicetree/bindings/phy/mediatek,tphy.yaml | 7 >>> +++++++ >>> 1 file changed, 7 insertions(+) >>> >>> diff --git >>> a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml >>> b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml >>> index 848edfb1f677..aee2f3027371 100644 >>> --- a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml >>> +++ b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml >>> @@ -219,6 +219,13 @@ patternProperties: >>> minimum: 1 >>> maximum: 15 >>> >>> + mediatek,pre-emphasis: >>> + description: >>> + The selection of pre-emphasis (U2 phy) >>> + $ref: /schemas/types.yaml#/definitions/uint32 >>> + minimum: 1 >>> + maximum: 3 >> >> Instead of hard-coding register values in bindings, you should rather >> describe here feature/effect. If it is in units, use unit suffixes. >> If >> it is some choice, usually string enum is appropriate. > How about changing description as bellow: > > "The level of pre-emphasis, increases one level, boosts the relative > amplitudes of signal's higher frequencies components about 4.16% (U2 > phy)" > Still the question is what is the unit. 4.16%? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel