From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 193CBC6FA82 for ; Tue, 13 Sep 2022 09:37:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FGZhLkGJBydb++5NMaED1ZDgqo1ua+XSIuQwJ4vKlOg=; b=VNn43sGQaaSv4p kWdKVWOqBZAUY/dYJKdw+h4MQ/jPMDQKVHS081Kc+P8UufhEP7ElbE1J3raexdmuyvSbQ1MN3nW/z u0rCfuBVQWIWW+DnBgqUE36HGpPWHLk6+EVwINCoOE82tgvJPKFSuIPx8AYLP7Wri9oTXrBL28zZA CYNkmOFkPrVZtWJe/FQK7CN+z/GIZLGFow2YTuMJIgXlgVnH/BSwqrdxrtva6HrLqxVaXqe46VVzc E6GKsKtvzUP/Bu3/1KmlqAqpnBGKg3VGdizVtGdXzRJAzajY1vDhrXowZ0OK4plGf2mR9FzKFg0aZ griI92gM5hHqcNFr0/yQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oY2KU-005J0q-MV; Tue, 13 Sep 2022 09:35:48 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oY2KN-005IxO-CF for linux-arm-kernel@lists.infradead.org; Tue, 13 Sep 2022 09:35:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1663061735; x=1694597735; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=6ubq+Nbr3qtwMAhkoqmZ0wYKd6J3dRuuusxNhyhXPNs=; b=lVC/5kHzMfO2cZQ0Esi7ufKHkwU46mznZm/e6KdPPDUT0ryE95GaCxdz j6PuCGF+BLTHlmdqLkZMdaGZI/RDzJaHkUakO8plf/+N9E8FGqeRKJ4My +99a7jHwK2fmtLpY0YFe6djK/3DQLDOMAManzdR884gC42Nb1yI4n1lQn Ag/vM0Vn4DtOKzKLBjXIpfOBbzQ3dUzBKozOi31qd7NcV/7SlchLc6FJQ wnQtPb4rGD9Tm49C5fEyn+9uO20BwkArsSjKcLKg6cK1PtmKkfIpjFmBR fpXnrY+OlOCf7+G8d7asiqm5s17aA3kEMJFsW1uvJ6fb+aTz0p9kg7n2Z Q==; X-IronPort-AV: E=Sophos;i="5.93,312,1654585200"; d="scan'208";a="180264256" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 13 Sep 2022 02:35:33 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Tue, 13 Sep 2022 02:35:32 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12 via Frontend Transport; Tue, 13 Sep 2022 02:35:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LeOozOhZnhvOBER+ghRl1juh+0VbuE6Y0pB3l6HxABmi3XYMx2yyp+6tIzRhm9gcedUZ3JUvLBRwimUx+0qYqsjyBYnlHpcfrDcFO6aFOl3JzydPZ69vc2pzdyOGgY2bR7ofPtZjDv95bnonU9e/eoQiPOEX/Ej3V4PkCpoV9QKa/e2u3xjeZGh2lbsRJC0E4GycuLM7l8a11/Tnfvo7O59bmV8OPlectwDbq7iHbgPv29caF6ETlsCRs07J/qJN07V75pdSeGpoO6orI8RJLlCjzIS0W5U2kwKegvR+e6Fzdt74/ocKZ4IE6aHBzMonJTFtb1u1FCTW68oC6QF/EA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6ubq+Nbr3qtwMAhkoqmZ0wYKd6J3dRuuusxNhyhXPNs=; b=oFkLI/ZPstwHgMcwBTADXmiPmBQi6LSt98guT8K3XUfGPL5js/tRfqOqh7G6kVOOuBc8hljXsVJoilqxGaiX9F5Z+g9BnOWBbtQ1myXu3X7rdL5NJrIRVNZlgs7gU8Z4CLoKSMD98SCSK8qMoqSlFP4e6LswJNm0hEyO5EetbCt6NSMR8wpCUtjjpOjMAK1i9G3pGSM1FpsfZ8GqTCcoazRSiaxH9+lEsK8HhQjBleULzEW26Q1BuITM7AOcAyk0r71de0+FUroR4x65i0WfULBPk5nbz15Fwj2sbb4MbJL346UfSi4NkfIskFXhJvA8dh7ZKTCKcvYAEL7pJT00LA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6ubq+Nbr3qtwMAhkoqmZ0wYKd6J3dRuuusxNhyhXPNs=; b=co14MTtj6IthUW0QrGPnpAJ/XrDNovj4nKoOC8uUtudT47XjM1rDKrYQj90WgGXUTpdtiEhyOurSTZT/XztnoOZBnbG4zNnh6/NhhA+wSlZB0X+SxSNbS0O6bwT27kUL2C7/CqF65/AVLJn5V1GszSQDbqTvVUKsCCIHGDK3rrk= Received: from BYAPR11MB2758.namprd11.prod.outlook.com (2603:10b6:a02:c9::11) by MW4PR11MB5871.namprd11.prod.outlook.com (2603:10b6:303:188::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Tue, 13 Sep 2022 09:35:28 +0000 Received: from BYAPR11MB2758.namprd11.prod.outlook.com ([fe80::e8ff:82ac:b76d:c61c]) by BYAPR11MB2758.namprd11.prod.outlook.com ([fe80::e8ff:82ac:b76d:c61c%4]) with mapi id 15.20.5612.022; Tue, 13 Sep 2022 09:35:28 +0000 From: To: , Subject: Re: [PATCH v2 06/13] dt-bindings: serial: atmel,at91-usart: Add SAM9260 compatibles to SAM9x60 Thread-Topic: [PATCH v2 06/13] dt-bindings: serial: atmel,at91-usart: Add SAM9260 compatibles to SAM9x60 Thread-Index: AQHYwfjCQbG755VmlEGUqK2TrhMH7a3VeaSAgAAuKICAAK1+AIAFHfCAgAAyC4CAACijAIABTCEAgAAF4YCAAAMZAIAAAVuA Date: Tue, 13 Sep 2022 09:35:27 +0000 Message-ID: References: <20220906135511.144725-1-sergiu.moga@microchip.com> <20220906135511.144725-7-sergiu.moga@microchip.com> <9aa29d74-b1fc-d00e-dee4-57f277a366ab@linaro.org> <20220909013644.GA3731620-robh@kernel.org> <77d38e3f-6d8c-dbb1-2e66-c768d95b5e35@microchip.com> <5f8ca612-5a89-db3a-42f3-a0613c192a87@linaro.org> <888b8ab9-f8cb-2e1f-465c-3cb97187fce0@microchip.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microchip.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR11MB2758:EE_|MW4PR11MB5871:EE_ x-ms-office365-filtering-correlation-id: 3d3e9886-25aa-4525-7421-08da956b4b10 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8iNt661UGAwEpBAqTSxAAHjUdwwgDKIkz95a4wYNcKSLXK5/X8KOXDDLi5mF9Ke0iFlnMs37CrQ9WZseKqPhuYqCTjOJgBut4urrVZCinwosJLXHDEsOsnjze2SaDxQ7oHml31T83/IONNRiqLt3ZAIuC6kJpOB/esS2AXKhG5dBnFXOHhvasghVASbpyRqg3uJLutN8nPNZ1yXlTuLTTiCOZAbHezRm4XSpipjGcII7SpfH5at7kMJbVvpUgNbtYdbIrExKFjel4QDTwDch4b4/As2OxFVh17KRVkgCW/LxkF+qJBEXfmurTLw+wAaWWV8BeOi901xaPlgDup41ZdE+pyLWGMUG6awBwSO3Nw8HjBdlcIlsYbR0Yn9BVDBAXipsnwJ8DSVD4tI+tm19dW2nc3v5dOSMIEgI9K2bpVpwbiPR8V8BkFzJr8aQNXzr3aNV3Ja73zBgFppAhXJoDnl/J4Noe0+OImLgq9L99aH2U4heEwKqDlosYwfhBq9+5NCX568WbuDRWJOWcu9AjrYkplDXWGMK8zVWWWfJIZWXq735ky2pMYrIu+qyDh8nWZBb+S+BSf8Npl7HaSBPFKrqugFAMcdRH4DamDr/nDG8gXKMOX+A3uRNbm7/pLxvh8Id0CalZUDjN1sf3bEBTijJjyhtQf44BmVt7rrsZ2E/tZswRx5zkugdJRgfETtfZwU2AznKPWazt9S9eeEi+WnJcveSpUrwHxgCTapbZnUtZlyvNTuiY0RtPtiXVpsyEFUiDIaoITa48YjPFA2qwCfmvBOHO5U+DR97BjX5i14= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR11MB2758.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(366004)(136003)(346002)(39860400002)(396003)(451199015)(4326008)(31686004)(71200400001)(122000001)(478600001)(6486002)(38100700002)(8936002)(5660300002)(6512007)(66476007)(186003)(66946007)(64756008)(26005)(66556008)(2616005)(110136005)(6506007)(7416002)(76116006)(38070700005)(53546011)(41300700001)(86362001)(31696002)(83380400001)(36756003)(8676002)(66446008)(91956017)(54906003)(2906002)(316002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RnhZVnlZRk5UeUZDSm1JTmxXRFZsUEtkNnR1Z3pnSm16QnJocE9sVFF6VndU?= =?utf-8?B?QTlDWlE2Mlk4ZXR6bFlzMW96V2JKd1ByY2tFWld0K29iQ3pNSElSTlJpbG9r?= =?utf-8?B?U1JFblBhSFpKVXQ5cTc5S3l2bC8zelZldzhsaWpTSXRabDlOcGorWkVndU9H?= =?utf-8?B?Y3BxNk9TZ0NzMEVxZDlnejROaUNqczNiTXlEa29CRDR5NmpyN2x0aTUva3Ey?= =?utf-8?B?RFQxTk9QQlNEN0NuOWRUOE5QQlVVZG1pN2IycVBDRkZMcjhYNTFhVEJ2RjdJ?= =?utf-8?B?MWJ3WXR3L2l4ZHNPZE0zVWNEb1BTQlpVa3FCaXRFYmlST2NBM0xzVXd4Z0Ni?= =?utf-8?B?MHRGVEJWaG5rdU1NbVRvK0NEYnlhczgvMVltdFlIVTA5U0M1bnFEWDY3amRH?= =?utf-8?B?ZUFzRUl5b0NMS3Btams1Q29vazJnR0hadkVOQzZUZmxibWM5Mm5sdjhRaVdz?= =?utf-8?B?YzBMY3Q4eXl3cFpwNGpUd3lOcWVsWjl3Rlc3SHk5cUMwVzNGSXpDN3JXWlRy?= =?utf-8?B?OFozTUJWMVZSSkhXT3dLa2szR3kzcXpQTk9EY2c0TXhHaXE3VmE5aFkvSnJJ?= =?utf-8?B?bThUeFZ0VGh5Nm9rbDkzekx2cFQraDBvZ05lOUZYUjh2S1dhSUtVSGJoZ0xp?= =?utf-8?B?ZElkUVNDK3RXVnpWeXRSZEZzaGwrNStnVnBDRnd4OGU4c0RFS0NWQjV0K244?= =?utf-8?B?eTR1ZzNEUnN3Q2VzdlZUcGE0Zm1WZU5NRWdqaG1WSGttQldrdFpJRDFFWDd1?= =?utf-8?B?WXlJNHVtdjZqR29vQVF5cWJnOHlaVHR0Rmg4S2lHMG1vYjVTWmJZR2VwL1pT?= =?utf-8?B?cXlDd2ppTFNINEszeG1ZSWN6RzllVWwyYjFtQ0V3anhtK3dUZXFyTUFPQnR5?= =?utf-8?B?anZjcGZoNW1LY09pbFRBVVh2UXdOSnF1WFhwYm01MjBEVGpQcG1rK1B5OC8z?= =?utf-8?B?Njg3QU1iUUJMNlVyZEFSUmNITkpKQ0k0WTV6NnZEaGFac2U3d0pHeE94UHQv?= =?utf-8?B?MThFWmhJVkZsZ2ZXdXlPL2hNaHVzbVREWE9NTE1Fa3F0ZTVzS25ZaE5keFhW?= =?utf-8?B?ZmFRM0U4ZHRaQWhjUjZmejd6eWZ1Wm52eGpLb09KKy96SXdNRUgzZkFaNnJq?= =?utf-8?B?Q2F3RzZXWnVVODVJZjVkTmRWWE9oNGk2TkV5YkVBVTRDTVlkSXhDUHFPTldu?= =?utf-8?B?OXFsSjUyZjhJMm4ycWdZNkJjOENOc3VYZmsrdE9qUGJZVktvb3RoOTZYcWhT?= =?utf-8?B?SGRoY21POU1Va0lJNS9DTktDRDdoV3hzSzZBNW5CbG9iYzZ4UnhXaGVQWENF?= =?utf-8?B?blNVZnQzSHFJdkZEcHVNamRJSC82Q1FTUHVjQ21Ed2tmM0Y2dkhyMHB2dlpW?= =?utf-8?B?aFdBRFJucGhURTB6U2c1dUh3d3JFVE16TUYrOWlZUllUMVlhcFNoQThzTXdD?= =?utf-8?B?Mm91Nk1xdStzd1kxVjVWVTlNZEF0a05QWkNBU1k1Q1lnNkJCL3FaOWRXWDNm?= =?utf-8?B?VVdhdWw3Y1hxUTRXMTB1WFVSVTFRVFNrNVJxSURtQlpVdytmY05oVU5YbXdR?= =?utf-8?B?c0FBVGduU0dUcXVNbWlNZW9tbFZ3ZVhOUzFOK05TOTI1T2dxVHB3RmgvOEpo?= =?utf-8?B?SDY2clZKaEs3dFc1RHhtUm9kbnE5cEJnZFFtQldJSUJpcDdUYUc5TTZ0QVZD?= =?utf-8?B?cEhPV1htMFkvdzVjcFNoNlRDQ3lEN3JBbWRMdFdUUmhEc2NOT2VKTGhqYzJk?= =?utf-8?B?aFBYZmkxZ21XZnpWcHhJWERLOUlyMWVILzRiVmgxc3hTcXpDMG5QbmNPZmtH?= =?utf-8?B?Umt4RlVrdTlESThEbXIyVE9hMUVnQlBIY1poTDZKTlFiZVk0eXFid29ZSGpp?= =?utf-8?B?V1N6UHViNlpNMUI0MCtpTnZlMjlUckJxMDNhZWRkMHpmNnRlZ0ROdHdWRm5p?= =?utf-8?B?VDZWanVJdnY5S3l6eld3N3Azb01ocTRQNWNDbUtQbVpGeU5CcHVLN211b0tu?= =?utf-8?B?aHVhbUJyMjFnMi8wdi9PWEFxSjJ1MFl0OERlT3NrK0d5Y1d0SFJvV1BFWWhT?= =?utf-8?B?dVlZaDJISDI5VmpBR0tKVVJPU3BGK2JhNi9kbmJqWUJndUo4MHF6L1FlbHNi?= =?utf-8?Q?UZ2L8/hpEazmkjeXYyJkRupeA?= Content-ID: <1E0DE51AB51E024085C466D33B77780C@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB2758.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3d3e9886-25aa-4525-7421-08da956b4b10 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Sep 2022 09:35:27.9286 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cxWwZPGVbyjZvGG2sh8UahuhUnv8xxQJah/j067zbTkcPngBs59lQEjCIa1XhzTSnTEp7sPK1qS5eqOGsQxQ8qnEQVSAOFNAiO39nMOLsDQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB5871 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220913_023535_478939_C7BB242A X-CRM114-Status: GOOD ( 18.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, linux-clk@vger.kernel.org, Kavyasree.Kotagiri@microchip.com, Tudor.Ambarus@microchip.com, richard.genoud@gmail.com, gregkh@linuxfoundation.org, radu_nicolae.pirea@upb.ro, lee@kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, mturquette@baylibre.com, broonie@kernel.org, admin@hifiphile.com, krzysztof.kozlowski+dt@linaro.org, linux-serial@vger.kernel.org, sboyd@kernel.org, jirislaby@kernel.org, Claudiu.Beznea@microchip.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 13.09.2022 12:30, Krzysztof Kozlowski wrote: > On 13/09/2022 11:19, Sergiu.Moga@microchip.com wrote: >>> >>> Let me rephrase it: >>> >>> What your commit is doing is requiring additional fallback compatibles. >>> Therefore the commit msg should answer - why do you require additional >>> fallback compatibles? >>> >> >> >> The additional fallback compatibles are required because the driver in >> question only knows about the atmel,at91sam9260-usart compatible. >> Furthermore, it is also a better representation of the fact that the >> serial IP of 9x60 is an improvement over the serial IP of 9260 (it >> contains more hardware features not yet implemented in the driver). >> >> >>> Incremental characteristics sound to me optional. I can increment >>> sam9x60 with something or I can skip it. But you are not doing it... >>> sam9x60 was already there and now you require a fallback. >>> >>> Best regards, >>> Krzysztof >> >> So, what is your opinion on the following commit message: >> >> "Fix sam9x60 compatible list by adding the sam9260 compatibles as >> fallback, since the atmel_serial driver only knows of the latter's >> compatible. The atmel_serial driver only has knowledge of the sam9260 >> compatible because it does not have the sam9x60's serial IP specific >> features implemented yet and adding an empty compatible without adding >> support specific to that compatible would be misleading. Thus prefer the >> fallback mechanism in the detriment of adding an empty compatible in the >> driver." > > It's fine. Also could work: > > "Require sam9260 fallback compatible for sam9x60, because sam9x60 is > fully compatible with sam9260 and Linux driver requires the latter." > This version looks better indeed. Sums it all up and is only 2 lines :). Thank you very much for the suggestion it is greatly appeciated. > If it fixes any observable issue like lack of driver binding to DTS, you > can also mention that. > > Best regards, > Krzysztof Thanks, Sergiu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel