From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ACACCC433FE for ; Wed, 19 Oct 2022 14:54:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JzOys61TzwzYE88zQF6+qpklX8BeWzVk+o87QP4EMjY=; b=2RqJcDwkW6j+qn /68oo6Wd1PeaoRxyO8BWAqwgo4dTOMe0mfgKZ9khnaooD2U/d0zH/fjXVHmViDdiiHcGYMC2YO5N6 PBXdK+sriiHa//HkMbjE0aQRRSY7P2hzCxt6pbwevcukNOaE9ouuHR8bX/qffkTCanguH0l790RJX a8X/sKIHWAukTw+RzltkfSwindzcLd0LgaVGPd1IHky+9zC4brSx73TxheUk6iRQEOkOsKr1RF/mo cRtRLTuLAXNb6P671TKdge5/eI0/nvGcrl3/6vbZuzmNG2zYIdPK59RWr5SCiF/WCBUMqlDeNHwj9 Y4UprKpZojr5JEGPpV3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1olAQv-002uaZ-1A; Wed, 19 Oct 2022 14:52:37 +0000 Received: from phobos.denx.de ([2a01:238:438b:c500:173d:9f52:ddab:ee01]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1olA8t-002oRT-6i for linux-arm-kernel@lists.infradead.org; Wed, 19 Oct 2022 14:34:00 +0000 Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 3F6718491C; Wed, 19 Oct 2022 16:33:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1666190035; bh=awwLFru55bPIwMLuVbQ5DyvBiqhLo35UcNGcYqGcjbc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Acr397ZbjAblbt8COdPevCB/mgp7sQ+M2yTR0XnG10bZ6DWROCCSorVyP5qQpYTLh u5FzYdTppotpcMjWLGMbT+KYfCFpWFDUY/brIY5o4mrTPNXi7M5TeN1nx/X5B3Q/TJ aq7ELpCWoI2Ha0t06nTjVr8npZe/j92PJuHyy/KvQI6X3RSufL+TkeZo6Tyu0y1qqF ClWpacD7kwyYj8cud4+hFF123MkZmTIX7TLBY1pb2tu8iO0lhI6j+fLUfIr6pV3W+W JiD8BvjPAMzx15dlCknSdpDZruFQFqq7U2ELslUWeTOXbnLmxJJCtFyGtRa9g+Psc5 o67gYCWMPtdng== Message-ID: Date: Wed, 19 Oct 2022 16:33:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v3 3/6] clk: imx: imx8mp: Add audiomix block control Content-Language: en-US To: Shengjiu Wang , Shengjiu Wang Cc: linux-clk@vger.kernel.org, abel.vesa@nxp.com, festevam@gmail.com, l.stach@pengutronix.de, laurent.pinchart@ideasonboard.com, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, mturquette@baylibre.com, ping.bai@nxp.com, sboyd@kernel.org, shawnguo@kernel.org References: <20220625013235.710346-1-marex@denx.de> <20220625013235.710346-3-marex@denx.de> <20220625013235.710346-3-marex@denx.de> From: Marek Vasut In-Reply-To: X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221019_073359_561452_60E842BE X-CRM114-Status: GOOD ( 10.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/14/22 03:53, Shengjiu Wang wrote: > Hi Marek Hi, [...] >> +static const struct clk_parent_data clk_imx8mp_audiomix_pll_parents[] = { >> + { .fw_name = "osc_24m", .name = "osc_24m" }, >> + { .name = "dummy" }, >> + { .name = "dummy" }, >> + { .name = "dummy" }, >> +}; >> + >> +static const struct clk_parent_data clk_imx8mp_audiomix_pll_bypass_sels[] >> = { >> + { .fw_name = "sai_pll", .name = "sai_pll" }, >> + { .fw_name = "sai_pll_ref_sel", .name = "sai_pll_ref_sel" }, >> +}; >> + >> +#define CLK_GATE(gname, cname) \ >> + { \ >> + gname"_cg", \ >> + IMX8MP_CLK_AUDIOMIX_##cname, \ >> + { .fw_name = "ahb", .name = "ahb" }, NULL, 1, \ >> >> { .fw_name = "audio_root_clk", .name = "audio_root_clk" }, NULL, 1, >> \ >> >> Should be the 'audio_root_clk' better? >> >> Then the 'clocks' and 'clock-names' can be removed in dts node? >> >> Will you continue to follow up this patch series? Sure. Did anyone from NXP finally test this patch series, and can provide useful review ? I am somewhat unhappy with the feedback I got thus far, which is based on downstream kernel fork, different power domain driver and different audiomix driver. I would really appreciate feedback for THIS driver instead. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel