From: Paul Kocialkowski <paul.kocialkowski@bootlin.com> To: Maxime Ripard <maxime.ripard@bootlin.com>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Sean Paul <seanpaul@chromium.org> Cc: bbrezillon@kernel.org, dri-devel@lists.freedesktop.org, Chen-Yu Tsai <wens@csie.org>, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Jagan Teki <jagan@openedev.com>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 3/8] drm/sun4i: dsi: Enforce boundaries on the start delay Date: Tue, 12 Feb 2019 16:30:33 +0100 Message-ID: <bf6176bef13d471a1fb829f918dbbe38de909e21.camel@bootlin.com> (raw) In-Reply-To: <c9889cf5f7a3d101ef380905900b45a182596f56.1549896081.git-series.maxime.ripard@bootlin.com> Hi, On Mon, 2019-02-11 at 15:41 +0100, Maxime Ripard wrote: > The Allwinner BSP makes sure that we don't end up with a null start delay > or with a delay larger than vtotal. > > The former condition is likely to happen now with the reworked start delay, > so make sure we enforce the same boundaries. > > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com> Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com> > --- > drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > index 9471fa695ec7..506f2e8cf454 100644 > --- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > +++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > @@ -358,8 +358,12 @@ static u16 sun6i_dsi_get_video_start_delay(struct sun6i_dsi *dsi, > struct drm_display_mode *mode) > { > u16 start = clamp(mode->vtotal - mode->vdisplay - 10, 8, 100); > + u16 delay = mode->vtotal - (mode->vsync_end - mode->vdisplay) + start; > > - return mode->vtotal - (mode->vsync_end - mode->vdisplay) + start; > + if (delay > mode->vtotal) > + delay = delay % mode->vtotal; I wonder whether delay == mode->vtotal would make sense at all. If not, then we can just apply the modulo unconditionally. But in doubt, let's keep things this way. Cheers, Paul > + > + return max_t(u16, delay, 1); > } > > static void sun6i_dsi_setup_burst(struct sun6i_dsi *dsi, -- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply index Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-11 14:41 [PATCH v3 0/8] drm/sun4i: dsi: Add burst mode support Maxime Ripard 2019-02-11 14:41 ` [PATCH v3 1/8] drm/sun4i: dsi: Restrict DSI tcon clock divider Maxime Ripard 2019-02-11 14:41 ` [PATCH v3 2/8] drm/sun4i: dsi: Change the start delay calculation Maxime Ripard 2019-02-12 15:28 ` Paul Kocialkowski 2019-02-12 15:45 ` Maxime Ripard 2019-02-11 14:41 ` [PATCH v3 3/8] drm/sun4i: dsi: Enforce boundaries on the start delay Maxime Ripard 2019-02-12 15:30 ` Paul Kocialkowski [this message] 2019-02-14 9:21 ` Maxime Ripard 2019-02-11 14:41 ` [PATCH v3 4/8] drm/sun4i: dsi: Fix front vs back porch calculation Maxime Ripard 2019-02-12 15:41 ` Paul Kocialkowski 2019-02-11 14:41 ` [PATCH v3 5/8] drm/sun4i: dsi: Fix DRQ calculation Maxime Ripard 2019-02-13 14:33 ` Paul Kocialkowski 2019-02-14 9:23 ` Maxime Ripard 2019-02-11 14:41 ` [PATCH v3 6/8] drm/sun4i: dsi: Rework a bit the hblk calculation Maxime Ripard 2019-02-13 14:41 ` Paul Kocialkowski 2019-02-11 14:41 ` [PATCH v3 7/8] drm/sun4i: dsi: Add burst support Maxime Ripard 2019-02-13 14:36 ` Paul Kocialkowski 2019-02-14 9:15 ` Maxime Ripard 2019-02-11 14:41 ` [PATCH v3 8/8] drm/panel: Add Ronbo RB070D30 panel Maxime Ripard 2019-02-11 15:13 ` Sam Ravnborg 2019-02-13 14:26 ` Paul Kocialkowski 2019-02-14 11:07 ` Re[2]: " Konstantin Sudakov 2019-02-12 10:32 ` [PATCH v3 0/8] drm/sun4i: dsi: Add burst mode support Jagan Teki 2019-02-15 14:12 ` Maxime Ripard [not found] ` <CAMty3ZAA90-fHPADJSE3ht9CiYWA3yBoyEy7wVv9=6C5JiaTVw@mail.gmail.com> 2019-02-15 17:07 ` Jagan Teki 2019-02-18 8:26 ` Paul Kocialkowski 2019-02-18 10:31 ` Jagan Teki 2019-02-20 16:35 ` Maxime Ripard 2019-02-26 6:48 ` Jagan Teki
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bf6176bef13d471a1fb829f918dbbe38de909e21.camel@bootlin.com \ --to=paul.kocialkowski@bootlin.com \ --cc=bbrezillon@kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=jagan@openedev.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=maarten.lankhorst@linux.intel.com \ --cc=maxime.ripard@bootlin.com \ --cc=seanpaul@chromium.org \ --cc=thomas.petazzoni@bootlin.com \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-ARM-Kernel Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \ linux-arm-kernel@lists.infradead.org public-inbox-index linux-arm-kernel Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git