From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DFA9C282C4 for ; Tue, 12 Feb 2019 15:30:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3BCAA2084E for ; Tue, 12 Feb 2019 15:30:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZvFdXJj9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3BCAA2084E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pnoEDzxsK3e9ABeRHAqneQHxLux9/dlFRGe+pD3GUPo=; b=ZvFdXJj9Ow9xBM 3otO/3TM5Y8+XHdpfxiAywHALKowhOcvs/b/nEh6G33D9egsvETpPkeLcZVLPbBSddQSRZzvIbVsv 5wEb8I8xeD852th9eiY20hF/GEA7vu8XEhoI8mM1Gexix2NZLX9WYmJDjJTP/n4z/qdo2OQJJt3vj 8+Bg0eaEMy9uxafe7GU75gnF1ofaIypR6SFBPuEpwM6Uaw1LQ17sm/hAgrmbEqK1DkxFgO/l9iG0v G9u1+jBpD7xK/23T3BTdsaNrR8R01sFGCkKu7QGFbIY5S60juF2Uhj4N0Hljzbv9jjV/l5AJGTzKe TAiOz5QoCwo5s+0sBigQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gta1H-0000CO-15; Tue, 12 Feb 2019 15:30:47 +0000 Received: from relay2-d.mail.gandi.net ([217.70.183.194]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gta1D-0000Bp-Bi for linux-arm-kernel@lists.infradead.org; Tue, 12 Feb 2019 15:30:45 +0000 X-Originating-IP: 90.88.30.68 Received: from aptenodytes (aaubervilliers-681-1-89-68.w90-88.abo.wanadoo.fr [90.88.30.68]) (Authenticated sender: paul.kocialkowski@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 8853A40012; Tue, 12 Feb 2019 15:30:33 +0000 (UTC) Message-ID: Subject: Re: [PATCH v3 3/8] drm/sun4i: dsi: Enforce boundaries on the start delay From: Paul Kocialkowski To: Maxime Ripard , Maarten Lankhorst , Sean Paul Date: Tue, 12 Feb 2019 16:30:33 +0100 In-Reply-To: References: Organization: Bootlin User-Agent: Evolution 3.30.5 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190212_073043_546105_C10F98B1 X-CRM114-Status: GOOD ( 16.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bbrezillon@kernel.org, dri-devel@lists.freedesktop.org, Chen-Yu Tsai , Thomas Petazzoni , Jagan Teki , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Mon, 2019-02-11 at 15:41 +0100, Maxime Ripard wrote: > The Allwinner BSP makes sure that we don't end up with a null start delay > or with a delay larger than vtotal. > > The former condition is likely to happen now with the reworked start delay, > so make sure we enforce the same boundaries. > > Signed-off-by: Maxime Ripard Reviewed-by: Paul Kocialkowski > --- > drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > index 9471fa695ec7..506f2e8cf454 100644 > --- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > +++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > @@ -358,8 +358,12 @@ static u16 sun6i_dsi_get_video_start_delay(struct sun6i_dsi *dsi, > struct drm_display_mode *mode) > { > u16 start = clamp(mode->vtotal - mode->vdisplay - 10, 8, 100); > + u16 delay = mode->vtotal - (mode->vsync_end - mode->vdisplay) + start; > > - return mode->vtotal - (mode->vsync_end - mode->vdisplay) + start; > + if (delay > mode->vtotal) > + delay = delay % mode->vtotal; I wonder whether delay == mode->vtotal would make sense at all. If not, then we can just apply the modulo unconditionally. But in doubt, let's keep things this way. Cheers, Paul > + > + return max_t(u16, delay, 1); > } > > static void sun6i_dsi_setup_burst(struct sun6i_dsi *dsi, -- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel