From: Phil Elwell <phil@raspberrypi.com>
To: Florian Fainelli <f.fainelli@gmail.com>,
"linus.walleij" <linus.walleij@linaro.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Cc: Stefan Wahren <stefan.wahren@i2se.com>,
Nicolas Saenz Julienne <nsaenzju@kernel.org>
Subject: Re: DTB backward/forward compatibility with "pinctrl: bcm2835: Change init order for gpio hogs"
Date: Tue, 25 Jan 2022 19:48:37 +0000 [thread overview]
Message-ID: <c04d26a5-16e9-44a7-8b75-a04df9f7bfb6@raspberrypi.com> (raw)
In-Reply-To: <6d6e5db3-8377-9389-6fb7-1f738a1c1b6e@gmail.com>
Florian,
On 25/01/2022 19:39, Florian Fainelli wrote:
> Hi,
>
> I am a bit frustrated by this commit, we picked it up via the stable 5.10 and
> 5.15 trees into our downstream tree, and in the absence of a suitable
> 'gpio-ranges' property for the GPIO controller, the SPI controller keeps getting
> -EPROBE_DEFER for its chip select. If the property is present, then all is well.
>
> Now the problem in my case is that the boot loader is responsible for providing
> the DTB to the kernel, and until recently, we did not update it to contain a
> suitable 'gpio-ranges' property. Now that it has been updated however, older
> kernels which *do not* have said change in the subject are also getting
> -EPROBE_DEFER for the SPI chip select.
>
> So this is just breaking backward/forward compatibility with the DTB unless both
> are updated in lock steps which is *extremely* inconvenient.
>
> This is death by a thousand cuts.
>
> So how do we remedy this?
It's unfortunate that both the DTS and driver were incorrect, and that the fixes
were inter-dependent. At Raspberry Pi we make a point of treating the DTBs as
part of the kernel, updating them at the same time. Is that not possible in your
situation? You don't specify which bootloader you are using (or even which
platform), but U-boot can be configured to use the DTB loaded and adjusted by
the firmware.
Phil
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-01-25 19:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 19:39 DTB backward/forward compatibility with "pinctrl: bcm2835: Change init order for gpio hogs" Florian Fainelli
2022-01-25 19:48 ` Phil Elwell [this message]
2022-01-25 19:58 ` Florian Fainelli
2022-01-26 1:33 ` Florian Fainelli
2022-01-27 16:31 ` Stefan Wahren
2022-03-06 15:03 ` Stefan Wahren
2022-03-06 16:54 ` Florian Fainelli
2022-03-06 17:58 ` Stefan Wahren
2022-03-07 11:38 ` Stefan Wahren
2022-03-08 19:13 ` Stefan Wahren
2022-03-09 1:10 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c04d26a5-16e9-44a7-8b75-a04df9f7bfb6@raspberrypi.com \
--to=phil@raspberrypi.com \
--cc=f.fainelli@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=nsaenzju@kernel.org \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).