From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61F82C352AA for ; Wed, 2 Oct 2019 05:32:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2CE742133F for ; Wed, 2 Oct 2019 05:32:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UJ2ZO2hN"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ysoft.com header.i=@ysoft.com header.b="lsWbrPuL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2CE742133F Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ysoft.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QEaYPlsxxizLVnigulIo0M2aJD43IM3dvN+ydpUMsrY=; b=UJ2ZO2hNww6HotPPmUmha1RAL WLHfxT+TWx+JDj0CZ2tQLZRqUFdZypkkJS18c6b9JEntQxULtAfLWaPukm9jRhlrnrTWuV3FbNOCl mImDgXssQ4sSQgwyZHwrAwPyLOkRfKfA0BH4C/ahCs/EKTcKxgjAanMD+s51gH3Itna85uDQmj2rd t1LLiAVGczvpqgQGpGar5/ljxo62acOeunlBB2bf2u4Yc1HVPLGWNVZ7sY7Po/isAGE5uuihrVuIa qbTnXLwcLZLWu9mQubY3vIrrc6xzyp/Grgmri41jtpehWbFx7if1rkfwM4aVzgYyv9lTeOW6QO4Lr KJHhLiYCQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iFXFs-00026z-Oe; Wed, 02 Oct 2019 05:32:52 +0000 Received: from uho.ysoft.cz ([81.19.3.130]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iFXFp-00025G-3V for linux-arm-kernel@lists.infradead.org; Wed, 02 Oct 2019 05:32:50 +0000 Received: from [10.1.8.111] (unknown [10.1.8.111]) by uho.ysoft.cz (Postfix) with ESMTP id 5B75DA211B; Wed, 2 Oct 2019 07:32:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ysoft.com; s=20160406-ysoft-com; t=1569994362; bh=5AcZEITR50EqYwQF+Thz3U0N2SH4PgzQ+ow4rmj91Wg=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=lsWbrPuLkR+N3vdIIaYAxfZVN32AeZZgTP8UbRtHXtoBUrJgnFuYMEy2S9OUTso8T 1z4bXsDQH6i4vGDDSf7ezji3fpLHRJtCjO4fOXpEYRDdFnBj6poSxwYp8A+Tws6ygP hQoYmypLsF0vX47CW19QH+//T2ypw15vsac5cLuo= Subject: Re: [PATCH] input: touchscreen: imx6ul_tsc: Use 'dev' instead of dereferencing it repeatedly To: Dmitry Torokhov , Anson Huang References: <1569315731-2387-1-git-send-email-Anson.Huang@nxp.com> <20190930230806.GX237523@dtor-ws> From: =?UTF-8?B?TWljaGFsIFZva8OhxI0=?= Message-ID: Date: Wed, 2 Oct 2019 07:32:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190930230806.GX237523@dtor-ws> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191001_223249_300216_3A82EB7B X-CRM114-Status: GOOD ( 10.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, swboyd@chromium.org, Linux-imx@nxp.com, kernel@pengutronix.de, linux-input@vger.kernel.org, festevam@gmail.com, mojha@codeaurora.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 01. 10. 19 1:08, Dmitry Torokhov wrote: > On Tue, Sep 24, 2019 at 05:02:11PM +0800, Anson Huang wrote: >> Add helper variable dev = &pdev->dev to simply the code. > > Do we get any code savings from this? I noticed Anson submitted similar patches into various other subsystems. Here [1] is a very detailed response from David Laight shedding some light on this topic. [1] https://lkml.org/lkml/2019/9/24/151 >> >> Signed-off-by: Anson Huang >> --- >> drivers/input/touchscreen/imx6ul_tsc.c | 37 +++++++++++++++++----------------- >> 1 file changed, 19 insertions(+), 18 deletions(-) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel