From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65BA1C433E0 for ; Thu, 11 Mar 2021 15:20:42 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CEE8564FAA for ; Thu, 11 Mar 2021 15:20:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CEE8564FAA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=foss.st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8M5tAEfbP+qbHxbJDNQzBs/gWQQYaEL4Esgnsjwbaj8=; b=OoZBQMk83KvghmXqULdc5+K+W AvDY0JUTnrdSBiiYO8eVDHr+JqQ6z04YEVIOba4gjRoBZnjbQ6hFAgfZwfmOD8WHjctdioBZFZfs8 e8iG5Qz2onhjNjzLwcNVVBQLOz/OwanohAI8uaxG/iRjZ+qLJ2rSzwgrlswufrqo4pXZsbzS1l1DZ OAgF1GRTn3hqg6jlwt4wGIXoa93522AO0Q8VidcN1+n0P3T7QXwE4CeX3Btt855Lv8y9o6/pe9ztV E4aBV11Po3GbFhn5SZj5sbqpxyZerJGijV+d+qL7GEPlIl/2sVOOfnVeFCAOjbz+MIqd8ZlscHWng iFJlLnnoQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lKN5W-009PUd-EF; Thu, 11 Mar 2021 15:18:58 +0000 Received: from mx08-00178001.pphosted.com ([91.207.212.93] helo=mx07-00178001.pphosted.com) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lKN5O-009PTQ-OG for linux-arm-kernel@lists.infradead.org; Thu, 11 Mar 2021 15:18:53 +0000 Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 12BF7Ffr006501; Thu, 11 Mar 2021 16:18:42 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=duXhnQrva9mfeXnZr0IndGHYsvfB2JHvMP8HhZLInq0=; b=0F9qwwyxUgjNE79IeDKhaqvdlqj7uHjhXERG4aoU4yT/q9UdmzGG1wgrsBGPif2H6rF6 nTrQkfOQlw+90vr/pGf2Duy3s1nXgCo2ZG1YvklqxIwxz7GuJN0fCDvs9DvLPU7Ol93z 5cnBCj+OmlXmSiTx/+jGpFEuDBeBY+3tIaTbdBg1yrNZxzF+iCDZmkLxnKz71aCUWkne x0cjiIHDGMsuvpzLMrJCaqKVIzGwc4wH+cgwbG/FdO7qw0wNiJtm+qDgKuDYUIW6YhOC Kk7ZDJuokGvEIhQucobYQZPeAAnZuR+KfopD9rmTb57sIUW8Yf+eREIVRDCAHNylZWng XQ== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 3741gpykjv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 11 Mar 2021 16:18:42 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id E96F010002A; Thu, 11 Mar 2021 16:18:40 +0100 (CET) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id CCAEB250E32; Thu, 11 Mar 2021 16:18:40 +0100 (CET) Received: from lmecxl0912.lme.st.com (10.75.127.49) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 11 Mar 2021 16:18:39 +0100 Subject: Re: [Linux-stm32] [PATCH v2 00/14] Introduce STM32MP1 RCC in secured mode To: Ahmad Fatoum , Marek Vasut , Alexandre TORGUE , Alex G. , Gabriel FERNANDEZ - foss , Michael Turquette , Stephen Boyd , Rob Herring , Maxime Coquelin , "Philipp Zabel" , Etienne CARRIERE CC: "devicetree@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-clk@vger.kernel.org" References: <20210126090120.19900-1-gabriel.fernandez@foss.st.com> <2e04f814-b694-119d-fe8a-13e6df129536@gmail.com> <463dafed-ec60-cd9a-33d2-ba118a6af629@foss.st.com> From: Alexandre TORGUE Message-ID: Date: Thu, 11 Mar 2021 16:18:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [10.75.127.49] X-ClientProxiedBy: SFHDAG2NODE3.st.com (10.75.127.6) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369, 18.0.761 definitions=2021-03-11_05:2021-03-10, 2021-03-11 signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210311_151851_352915_7E1D4C94 X-CRM114-Status: GOOD ( 24.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Ahmad On 3/11/21 3:41 PM, Ahmad Fatoum wrote: > Hello, > > On 11.03.21 15:02, Alexandre TORGUE wrote: >> On 3/11/21 12:43 PM, Marek Vasut wrote: >>> On 3/11/21 9:08 AM, Alexandre TORGUE wrote: >>>> 1- Break the current ABI: as soon as those patches are merged, stm32mp157c-dk2.dtb will impose to use >>>> A tf-a for scmi clocks. For people using u-boot spl, the will have to create their own "no-secure" devicetree. >>> >>> NAK, this breaks existing boards and existing setups, e.g. DK2 that does not use ATF. >>> >>>> 2-As you suggest, create a new "secure" dtb per boards (Not my wish for maintenance perspectives). >>> >>> I agree with Alex (G) that the "secure" option should be opt-in. >>> That way existing setups remain working and no extra requirements are imposed on MP1 users. Esp. since as far as I understand this, the "secure" part isn't really about security, but rather about moving clock configuration from Linux to some firmware blob. >>> >>>> 3- Keep kernel device tree as they are and applied this secure layer (scmi clocks phandle) thanks to dtbo in >>>> U-boot. >>> >>> Is this really better than >>> #include "stm32mp15xx-enable-secure-stuff.dtsi" >>> in a board DT ? Because that is how I imagine the opt-in "secure" option could work. >>> >> >> Discussing with Patrick about u-boot, we could use dtbo application thanks to extlinux.conf. BUT it it will not prevent other case (i.e. TF-A which jump directly in kernel@). So the "least worst" solution is to create a new "stm32mp1257c-scmi-dk2 board which will overload clock entries with a scmi phandle (as proposed by Alex). > > I raised this issue before with your colleagues. I still believe the correct way > would be for the TF-A to pass down either a device tree or an overlay with the > actual settings in use, e.g.: > > - Clocks/Resets done via SCMI > - Reserved memory regions > > If TF-A directly boots Linux, it can apply the overlay itself, otherwise it's > passed down to SSBL that applies it before booting Linux. Discussing with tf-a and u-boot guys, this solution could imply hard synchronization between tf-a/u-boot. The most simple remains a "secure" dts. regards Alex > Cheers, > Ahmad > >> >> Gabriel, can you wait a bit before sending something about SCMI in dtsi, I would like to align this strategy internally. >> >> Marek, Alex: thanks for your inputs. >> >> Regards >> Alex >> >>>> The third could be the less costly. >>> >>> [...] >> _______________________________________________ >> Linux-stm32 mailing list >> Linux-stm32@st-md-mailman.stormreply.com >> https://st-md-mailman.stormreply.com/mailman/listinfo/linux-stm32 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel