From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32092C4363D for ; Wed, 21 Oct 2020 02:50:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9832D22240 for ; Wed, 21 Oct 2020 02:50:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Cwit+S4l"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="r6fW1DVN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9832D22240 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:References: To:Subject:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3gIL5aZT2bUWijbXsNA4L5WH7E2EuClF/CfEml4nd+0=; b=Cwit+S4lnC7S5fJOxLdXoITyQ k49i1Ta2gw+5+TfTafrJLVp9QDNhZAmdTauy8LhtgpF6BPpZuU9e3stSnLiusLwFH2ZY8FHAS7mCY cCuVwapA5KlKqYEW2FLdyWujY2z4h4z47aWuoU0ISDOLFGLHiIx1zvMxHzoHXmf6nHYzrORv6rmQN 8xPUnsatbuL0bix6fvRtIv9DJZ5nFpABmqmp4/WacQFYQwlDgSoRIwEzF2n9yTecdattMcjecxkZ4 RKV/tc7NnJRuP8NwE5qgANwrG2BO9bsvbSwb6DS+8ZGtch2Wk3H5QdM8/GLiAjCmiIuwH5Zy19zP4 aZFcDxCmw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kV4Bs-00055N-O1; Wed, 21 Oct 2020 02:49:28 +0000 Received: from mail-qk1-x743.google.com ([2607:f8b0:4864:20::743]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kV4Bq-00054Q-4X for linux-arm-kernel@lists.infradead.org; Wed, 21 Oct 2020 02:49:27 +0000 Received: by mail-qk1-x743.google.com with SMTP id f21so981364qko.5 for ; Tue, 20 Oct 2020 19:49:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=jPDwSgLYvQCo/mG9InkCNxNQ0QGNMzzuKpyCjbVUMes=; b=r6fW1DVNYB8qqsQ8Q4CdElTaydx0rngT2GoaULeddh00abGzniECWUirF64S+NSj8O 2Xtpl1gyMMyIH7yPl1CthDj88CCORLsLDQDZRddwU7uFhNgiBsIZ0hQ8qyp9igYJvAGj sXTMkLIDh6X5X3n5gHh1FqYKVrgRsDNsmygU9awY1Qk0C3xM/CMDE87xcaiXkhoCBhTw RGWeEZe8E+ScCZ/1BrS3KBqgTHWoVg21g94rqrA4ZTq9ZxLlwQjRDc9oHyz4zbs5qGXh /hZzZHVxBEKf6LwYO3DYDY35alsLOo63Ioz2lDDjI/qPOMzGwBd1Ix81MhubSiPGqx3U 14Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jPDwSgLYvQCo/mG9InkCNxNQ0QGNMzzuKpyCjbVUMes=; b=Pv5nvUOcfrCThlS1Dxd6/dy+QWqoY9ZoadN4L51z90b2e9/ggqYbEnHvAmmTXS+Akg YuZECUM2VwDthembmycXtmk32DgeahouqGCdoETKygZey7lSQAKj0O+BQeQZfiLpQF+c tCugcxOk+F7b7xvDDPz9316PGaNGTCr2AHU7EqfBiVk4vAdODw2CvDHg+rz270XHRW1r uTawXwM3m16HHFhjYeFg7KFj9qCsyo6U38hPPxnGWIAe8+xnR/j+hfUGyHlEX8puw+yW uDuyKs1l8gNR4GcOQdddTCkuaXJRpH2uJLH+H4Hi8KqOxn5i0O4Vv7ygrle9L7ypiIN3 ot7g== X-Gm-Message-State: AOAM533fZABlmorS/L3fEUNlp9jreOtnew6QbC0jOubBdZOWQbya7iP7 3azjLKv6QBTUsidGmoBmhS+EaA== X-Google-Smtp-Source: ABdhPJwXXc2rVhCdAquB08vs9g2den0EbIzwEowgIegC2Lu7uqjztOb0FByPJpQCNJ5wBmXRZ7Jx3w== X-Received: by 2002:a05:620a:14a9:: with SMTP id x9mr1269165qkj.47.1603248564583; Tue, 20 Oct 2020 19:49:24 -0700 (PDT) Received: from [192.168.1.93] (pool-71-163-245-5.washdc.fios.verizon.net. [71.163.245.5]) by smtp.gmail.com with ESMTPSA id e188sm571784qkf.128.2020.10.20.19.49.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Oct 2020 19:49:23 -0700 (PDT) From: Thara Gopinath Subject: Re: [PATCH 10/11] [DEBUG] firmware: arm_scmi: add custom_dummy SCMI devname To: Cristian Marussi , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20201014150545.44807-1-cristian.marussi@arm.com> <20201014150545.44807-11-cristian.marussi@arm.com> Message-ID: Date: Tue, 20 Oct 2020 22:49:23 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201014150545.44807-11-cristian.marussi@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201020_224926_293610_79599054 X-CRM114-Status: GOOD ( 19.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: f.fainelli@gmail.com, vincent.guittot@linaro.org, sudeep.holla@arm.com, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, souvik.chakravarty@arm.com, etienne.carriere@linaro.org, lukasz.luba@arm.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/14/20 11:05 AM, Cristian Marussi wrote: > Add custom_dummy SCMI devname. > > Signed-off-by: Cristian Marussi > --- > drivers/firmware/arm_scmi/driver.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c > index 55df134c2338..5c39a738866a 100644 > --- a/drivers/firmware/arm_scmi/driver.c > +++ b/drivers/firmware/arm_scmi/driver.c > @@ -993,6 +993,7 @@ static struct scmi_prot_devnames devnames[] = { > { SCMI_PROTOCOL_CLOCK, { "clocks" },}, > { SCMI_PROTOCOL_SENSOR, { "hwmon" },}, > { SCMI_PROTOCOL_RESET, { "reset" },}, > + { SCMI_PROTOCOL_CUSTOM_DUMMY, { "custom_dummy" },}, Hi Cristian, Thanks for the sample dummy custom protocol and driver! The problem with adding scmi devname into the array is that every time a custom vendor protocol is added, the array has to be extended. Instead since the scmi spec supports the range 0x80-0xff for custom protocols, why not check for that range in scmi_create_protocol_devices and go ahead with registering the creating the protocol device via scmi_create_protocol_device? > }; > > static inline void > -- Warm Regards Thara _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel