From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2C20C4360C for ; Fri, 4 Oct 2019 16:08:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 84DCF20873 for ; Fri, 4 Oct 2019 16:08:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BT3vvTyv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 84DCF20873 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6bNVLti/xGrzNVu9qOc04uJqKa9+gxkEZehXQWj9Fp4=; b=BT3vvTyvfz0Uc+ VHc2EIIqklnq9JaUtYlAZoAkJPRxWrq5XUIhj+gfHwMAlOK/LjwzeDmV1haB9eQoykn5ny2to0rL6 ojMjOiP9n5fu/HFRDQ+IuU7EQDwk7z3ZoIp4w4eavzXOTjcsjeIoKH2PTbrnExoYu+YkIeOIew5+4 9pNjuvNgG/dkRzOyV6sPnebAITOEqUmvL4jZ7Q3Wpz3be+thYfojRsdq0/kgi2uuNg7BdYQNL04At XlivHrgAbjWTgwtvgHUewpzj85GcdUCsSLHJFSDpuSua5XZZcvAx9HNtU4+YtA1DLLNHaJWtJtH4J cPHuS0Jn0K6v4KHARhqQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iGQ7t-0006gQ-5M; Fri, 04 Oct 2019 16:08:17 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iGQ7p-0006g2-Rj for linux-arm-kernel@lists.infradead.org; Fri, 04 Oct 2019 16:08:15 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 22C931597; Fri, 4 Oct 2019 09:08:13 -0700 (PDT) Received: from [10.1.196.105] (eglon.cambridge.arm.com [10.1.196.105]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 53D153F68E; Fri, 4 Oct 2019 09:08:12 -0700 (PDT) Subject: Re: [PATCH 2/8] arm64: remove __exception annotations To: Masami Hiramatsu , Mark Rutland References: <20191003171642.135652-1-james.morse@arm.com> <20191003171642.135652-3-james.morse@arm.com> <20191004101717.GB34756@lakrids.cambridge.arm.com> <20191004231033.537af57806db6316b18cb0b5@kernel.org> From: James Morse Message-ID: Date: Fri, 4 Oct 2019 17:08:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191004231033.537af57806db6316b18cb0b5@kernel.org> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191004_090813_939280_BA7F2274 X-CRM114-Status: GOOD ( 15.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Will Deacon , Julien Thierry , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi guys, On 04/10/2019 15:10, Masami Hiramatsu wrote: > On Fri, 4 Oct 2019 11:17:17 +0100 > Mark Rutland wrote: >> On Thu, Oct 03, 2019 at 06:16:36PM +0100, James Morse wrote: >>> Since commit 732674980139 ("arm64: unwind: reference pt_regs via embedded >>> stack frame") arm64 has has not used the __exception annotation to dump >>> the pt_regs during stack tracing. in_exception_text() has no callers. >>> >>> This annotation is only used to blacklist kprobes, it means the same as >>> __kprobes. >>> >>> Section annotations like this require the functions to be grouped >>> together between the start/end markers, and placed according to >>> the linker script. For kprobes we also have NOKPROBE_SYMBOL() which >>> logs the symbol address in a section that kprobes parses and >>> blacklists at boot. >>> >>> Using NOKPROBE_SYMBOL() instead lets kprobes publish the list of >>> blacklisted symbols, and saves us from having an arm64 specific >>> spelling of __kprobes. >>> diff --git a/arch/arm64/include/asm/exception.h b/arch/arm64/include/asm/exception.h >>> index a17393ff6677..b0b3ba56e919 100644 >>> --- a/arch/arm64/include/asm/exception.h >>> +++ b/arch/arm64/include/asm/exception.h >> >> [...] >> >>> -asmlinkage void __exception do_debug_exception(unsigned long addr_if_watchpoint, >>> - unsigned int esr, >>> - struct pt_regs *regs) >>> +asmlinkage void do_debug_exception(unsigned long addr_if_watchpoint, >>> + unsigned int esr, struct pt_regs *regs) >>> { >>> const struct fault_info *inf = esr_to_debug_fault_info(esr); >>> unsigned long pc = instruction_pointer(regs); >> >> I assume you meant to add NOKPROBE_SYMBOL(do_debug_exception) here. >> >> Assuming so, and with that fixed up: >> >> Acked-by: Mark Rutland > > Good catch, if so, this looks good to me too. I should have noted it in the commit message, but the NOKPROBE_SYMBOL(do_debug_exception) is already there! Added by commit 2dd0e8d2d2a15 ("arm64: Kprobes with single stepping support"). (kprobing the debug handler is so bad, we blacklist it twice!) I'll fix the commit message. > with that fixed up: > > Acked-by: Masami Hiramatsu I assume you're both happy for me to apply these tags. Thanks, James _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel