linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: hgkr.klein@gmail.com (Helmut Klein)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2, 2/3] tty/serial: meson_uart: add documentation for the dt-bindings
Date: Tue, 28 Mar 2017 20:20:43 +0200	[thread overview]
Message-ID: <c233fb1c-7ae5-cfdf-938d-6e9dfa7bbcca@gmail.com> (raw)
In-Reply-To: <20170328100551.GA24221@leverpostej>

Hallo Mark,

i will add your text to the patch.

Helmut

On 28.03.2017 12:05, Mark Rutland wrote:
> On Tue, Mar 28, 2017 at 11:25:44AM +0200, Helmut Klein wrote:
>> Add the documentation for the device tree binding of meson_uart
>>
>> Signed-off-by: Helmut Klein <hgkr.klein@gmail.com>
>> ---
>>  .../bindings/serial/amlogic,meson_uart.txt         | 25 ++++++++++++++++++++++
>>  1 file changed, 25 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/serial/amlogic,meson_uart.txt
>>
>> diff --git a/Documentation/devicetree/bindings/serial/amlogic,meson_uart.txt b/Documentation/devicetree/bindings/serial/amlogic,meson_uart.txt
>> new file mode 100644
>> index 000000000000..6f94ba25760d
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/serial/amlogic,meson_uart.txt
>> @@ -0,0 +1,25 @@
>> +* Amlogic Meson UART, used in multiple SoCs (e.g. S905, s905X, ...)
>> +
>> +Required properties:
>> +- compatible	: "amlogic,meson-uart"
>> +- reg		: offset and length of the register set for the device.
>> +- interrupts	: device interrupt
>> +- clocks	: the baud rate clock for the UART and optionally the core clock for the none AO uarts
>> +e.g.
>> +uart_A: serial at 84c0 {
>> +	compatible = "amlogic,meson-uart";
>> +	reg = <0x0 0x84c0 0x0 0x14>;
>> +	pinctrl-0 = <&uart_a_pins &uart_a_cts_rts_pins>;
>> +	interrupts = <GIC_SPI 26 IRQ_TYPE_EDGE_RISING>;
>> +	clocks = <&xtal>, <&clkc CLKID_UART0>;
>> +	clock-names = "xtal", "core";
>
> Please define these explicitly above, e.g.
>
> - clocks: a list of phandle + clock-specifier pairs, one for each entry
>           in clock names.
> - clock-names: contains:
>   * "xtal" for the baud rate clock
>   * "core" for the non-AO UARTs (optional)
>
> Thanks,
> Mark.
>

  reply	other threads:[~2017-03-28 18:20 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-28  9:25 [PATCH v2, 0/3] tty/serial: meson_uart: add support for core clock handling Helmut Klein
2017-03-28  9:25 ` [PATCH v2,1/3] meson_uart: expose CLKID_UARTx Helmut Klein
2017-03-28 15:51   ` Jerome Brunet
2017-03-28 18:18     ` Helmut Klein
2017-03-28 19:14       ` Jerome Brunet
2017-03-28 21:24         ` Martin Blumenstingl
2017-03-29  6:21           ` Jerome Brunet
2017-03-29 20:21           ` Kevin Hilman
2017-03-31 15:37             ` Jerome Brunet
2017-03-31 17:03               ` Helmut Klein
2017-03-28  9:25 ` [PATCH v2, 2/3] tty/serial: meson_uart: add documentation for the dt-bindings Helmut Klein
2017-03-28 10:05   ` Mark Rutland
2017-03-28 18:20     ` Helmut Klein [this message]
2017-03-28  9:25 ` [PATCH v2, 3/3] tty/serial: meson_uart: add the core clock handling to the driver Helmut Klein
2017-03-28 19:16   ` Jerome Brunet
2017-03-29  9:47     ` Helmut Klein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c233fb1c-7ae5-cfdf-938d-6e9dfa7bbcca@gmail.com \
    --to=hgkr.klein@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).