From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55F38C2B9F8 for ; Tue, 25 May 2021 16:59:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 206D86141C for ; Tue, 25 May 2021 16:59:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 206D86141C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=acm.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=XJBRkbl1kHInx0TNNKkypncklPLIKvmpbs1+Cm4zvmU=; b=bOfCAqH2BrAJwP2MOb+467VLHl gEsl66b2pO20rxExrsRGLchMcepUZgGfH7yCQLbFvDFyKDBfcFuYSyPDn+325iQBJ5oLbkU8aXamd ksFjgLY802Xs+5wYG7ubXVcpM2QFelRnkL0N7av86/eNY2MfKpUeERiR/gAjVgXg2oZhxEhP6luKM nmQEOp6Vey84FgrBsPpVC8wsrudU7G9VB3EjzE4x2TKfv55XzNpNic3vqJg+O8HOFdZ9vvzBq7Pja JoHEbteYVMCp9B0N0YotcMexXuUowGsepuxqxNyWufK+YlBI9E362W093Mg+egYd2lnVXSdVAhyjV MKIjPLcw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1llaMm-006dtw-96; Tue, 25 May 2021 16:57:16 +0000 Received: from mail-pg1-f178.google.com ([209.85.215.178]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lla6i-006Vew-8i; Tue, 25 May 2021 16:40:41 +0000 Received: by mail-pg1-f178.google.com with SMTP id 6so23175157pgk.5; Tue, 25 May 2021 09:40:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6kZjbGQduH1O16Py6H5dph2xaDYJhSr3BHluI3PjlOA=; b=fPSsbQU5hpERdCCcdbKkQteHRYRLcgTKMEb8TEbfZGidGBBrtWP8/z+xDJbYNXix6J YT279gKrgbEIkfdEWnqlHKTbAVoB5JU3CzUNd8XAsPpAlNSuRlvIcXN9GWmkY8+wokDe a/+fbHFnXIMjtmpe5mgGnjRt1TUHjCZ7/bn96uhOc2DdORI3lWZkHoePNKCkb2w6zEXo +uS5uwveKN7siF4VUZwie9G03btHhQ2qqN0Udg8Jms2l1k/NG43mgCyYZF1ztDf1KWWI xUUdSpUkZEXWrqiR1w8psqBnocH7gMMQCyoR2aE/gdBOF11a2XLhzreEOOxcW0+5bqz8 B54g== X-Gm-Message-State: AOAM530zwQWNCup6emD1eRmcKSgkjv6U3325Hut0C82lfIKfgTA/eiAW s5EUPZpLR94PCQK76La3XOAkygLbuQY= X-Google-Smtp-Source: ABdhPJwUxMVTVripchYVIdxI3dqkr1pmOUf575UZmWTQuIyVLkEdUNT5IcevXy/8DJy9E0iX+RFPzw== X-Received: by 2002:a65:6156:: with SMTP id o22mr19679020pgv.71.1621960837224; Tue, 25 May 2021 09:40:37 -0700 (PDT) Received: from [192.168.3.217] (c-73-241-217-19.hsd1.ca.comcast.net. [73.241.217.19]) by smtp.gmail.com with ESMTPSA id i16sm12897203pji.30.2021.05.25.09.40.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 May 2021 09:40:36 -0700 (PDT) Subject: Re: [PATCH v1 2/3] scsi: ufs: Optimize host lock on transfer requests send/compl paths To: Can Guo Cc: asutoshd@codeaurora.org, nguyenb@codeaurora.org, hongwus@codeaurora.org, linux-scsi@vger.kernel.org, kernel-team@android.com, Stanley Chu , Alim Akhtar , Avri Altman , "James E.J. Bottomley" , "Martin K. Petersen" , Matthias Brugger , Bean Huo , Jaegeuk Kim , Adrian Hunter , Kiwoong Kim , Satya Tangirala , open list , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" References: <1621845419-14194-1-git-send-email-cang@codeaurora.org> <1621845419-14194-3-git-send-email-cang@codeaurora.org> <41a08b3e-122d-4f1a-abbd-4b5730f880b2@acm.org> <0cfbf580e340073ff972be493a59dbe7@codeaurora.org> From: Bart Van Assche Message-ID: Date: Tue, 25 May 2021 09:40:34 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <0cfbf580e340073ff972be493a59dbe7@codeaurora.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210525_094040_358477_4B2A141B X-CRM114-Status: GOOD ( 13.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/24/21 6:40 PM, Can Guo wrote: > Agree with all above, and what you ask is right what we are doing in > the 3rd change - get rid of host lock on dispatch and completion > paths. > > I agree with using dedicated spin locks for dedicated purposes in > UFS driver, e.g., clk gating has its own gating_lock and clk scaling > has its own scaling_lock. But this specific series is only for > improving performance. We will take your comments into consideration > and address it in future. Thanks! Bart. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel