From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B78EAC07E96 for ; Tue, 6 Jul 2021 21:05:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7182961C94 for ; Tue, 6 Jul 2021 21:05:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7182961C94 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6GZZ1c/WzZeKIlZmKJvug4AZN/AdnpNEQ2wcB4TtluA=; b=kUZvNlQmTk7gYkvLRw0Ehv/L1f YL7DyxkDAOJ80Tvi3CSn+dWJx4yh4fIWtzBQ+QnScq3KBYDMMDAXQ/KbXJ5bV4vR/RMybJUlt4g2G M3zilU0kOO/L8FghSDAIoiw0YyB0cqVa8MRNJMxwa3ULRp2YN+fhByt/v0yfT8TbZzDeYUoMgZO6X aerE3mCdn1g5z6XzO0JrgLwJ+w0clCVkUwdodTdGnKamySrBGHIoYNjrQr8LDPwQWZM5cE3qcew+n 9CdAWxs/1QVKdGG+MvfXVO1ED2ZRLE8mCrGhlz9+5Unq29jOUaXAXLQpENETYrznhZ9I4Mc09lRX9 Qso89OVQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m0sEp-00Cpxk-0m; Tue, 06 Jul 2021 21:04:15 +0000 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m0sEk-00CpvK-1J for linux-arm-kernel@lists.infradead.org; Tue, 06 Jul 2021 21:04:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625605443; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rq8U+vTL62FFXy3XaC+Iae121lZCkhh5N1dZH3VvP4o=; b=Wh+vhONp5PzAPv3IwYvi4OBQzrUW3sSalppeNyCvSp8+WhD1Zx6FcW6FojjNL8d4uyTERN 0VC8ZMmtm2thcEcgL0165zw4G3Szwa2nYN7uv8czZm4n8HqT2lCuVdgTLLYbXEtONHML0B s9462oOX70b6bTRd8r3UtB7nU6PtHAA= Received: from mail-oo1-f71.google.com (mail-oo1-f71.google.com [209.85.161.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-229-bHz1TfJHMauTP8a-muMnQg-1; Tue, 06 Jul 2021 17:04:02 -0400 X-MC-Unique: bHz1TfJHMauTP8a-muMnQg-1 Received: by mail-oo1-f71.google.com with SMTP id e36-20020a0568200624b029024c79ea65e1so11204332oow.11 for ; Tue, 06 Jul 2021 14:04:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=rq8U+vTL62FFXy3XaC+Iae121lZCkhh5N1dZH3VvP4o=; b=EpjWL9haEadtTqpOdeeqeWiZ5cHzrrrXpbVB6Bdbq768OhHAeYjNW0bjGJtm/EzAfn qTzTF3rSilSjld8/UoV5C9w3XrnhCe4dK7CkIMhapW+cpXvhhyPh7x1gm2Hgq1Pk2WAK zD4MdbKDehXKk6AuChdR1xjW8ZQohFQnQ63bP0dSnX4sn5Eb/bqn5FGfDMY5a2qxg93a bQ62m/3xEh7vDo08qjYLvOD6IT8mXhEqKa43sIFRhSo8KI0mxO2QajiupiLc/fu75VS5 HP8gZtEVW86T9ih4ktGkQC/t5b4U2yI3s9FkMK11j6vYbEiB7bdtuz6TtYuY4Q852NI4 KDrQ== X-Gm-Message-State: AOAM532nu4ecj2AMGvZydH/MKDT+4PtUMLzV393S2llO6/H933LLv2As 8nqAozlvYnV7tBqkffVnuA+AxHRvINi243QKeteN8xrbmdPCwcnwsGVSI2ZaIGG2C0MgilN4ALO H3oFEhAkgaiXQyoV684+opqFgLfAxBngCv24= X-Received: by 2002:a05:6808:1523:: with SMTP id u35mr3670296oiw.132.1625605440942; Tue, 06 Jul 2021 14:04:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx62HKLlemehPY2UyA8H0YEjxeJSEUxb/U3f7pKIm7DwzFJJAuko85berITKZR0ayBmECKR7w== X-Received: by 2002:a05:6808:1523:: with SMTP id u35mr3670283oiw.132.1625605440801; Tue, 06 Jul 2021 14:04:00 -0700 (PDT) Received: from localhost.localdomain (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id a7sm3074816ooo.9.2021.07.06.14.03.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Jul 2021 14:04:00 -0700 (PDT) Subject: Re: [PATCH v8 1/5] drivers: firmware: Add PDI load API support To: Nava kishore Manne , robh+dt@kernel.org, michal.simek@xilinx.com, mdf@kernel.org, arnd@arndb.de, rajan.vaja@xilinx.com, gregkh@linuxfoundation.org, amit.sunil.dhamne@xilinx.com, tejas.patel@xilinx.com, zou_wei@huawei.com, lakshmi.sai.krishna.potthuri@xilinx.com, ravi.patel@xilinx.com, iwamatsu@nigauri.org, wendy.liang@xilinx.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org, git@xilinx.com, chinnikishore369@gmail.com References: <20210626155248.5004-1-nava.manne@xilinx.com> <20210626155248.5004-2-nava.manne@xilinx.com> From: Tom Rix Message-ID: Date: Tue, 6 Jul 2021 14:03:57 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210626155248.5004-2-nava.manne@xilinx.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210706_140410_231654_A1384AF4 X-CRM114-Status: GOOD ( 23.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/26/21 8:52 AM, Nava kishore Manne wrote: > This patch adds load PDI API support to enable full/partial PDI loading > from linux. Programmable Device Image (PDI) is combination of headers, > images and bitstream files to be loaded. > > Signed-off-by: Nava kishore Manne > Reviewed-by: Moritz Fischer > --- > Changes for v2: > -Updated API Doc and commit msg. > No functional changes. > > Changes for v3: > -None. > > Changes for v4: > -Rebased the changes on linux-next. > No functional changes > > Changes for v5: > -None. > > Changes for v6: > -None. > > Changes for v7: > -None. > > Changes for v8: > -None. > > drivers/firmware/xilinx/zynqmp.c | 17 +++++++++++++++++ > include/linux/firmware/xlnx-zynqmp.h | 10 ++++++++++ > 2 files changed, 27 insertions(+) > > diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c > index 15b138326ecc..2db571da9ad8 100644 > --- a/drivers/firmware/xilinx/zynqmp.c > +++ b/drivers/firmware/xilinx/zynqmp.c > @@ -1011,6 +1011,23 @@ int zynqmp_pm_set_requirement(const u32 node, const u32 capabilities, > } > EXPORT_SYMBOL_GPL(zynqmp_pm_set_requirement); > > +/** > + * zynqmp_pm_load_pdi - Load and process PDI > + * @src: Source device where PDI is located > + * @address: PDI src address > + * > + * This function provides support to load PDI from linux > + * > + * Return: Returns status, either success or error+reason > + */ > +int zynqmp_pm_load_pdi(const u32 src, const u64 address) > +{ > + return zynqmp_pm_invoke_fn(PM_LOAD_PDI, src, > + lower_32_bits(address), > + upper_32_bits(address), 0, NULL); > +} > +EXPORT_SYMBOL_GPL(zynqmp_pm_load_pdi); > + > /** > * zynqmp_pm_aes - Access AES hardware to encrypt/decrypt the data using > * AES-GCM core. > diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux/firmware/xlnx-zynqmp.h > index 9d1a5c175065..56b426fe020c 100644 > --- a/include/linux/firmware/xlnx-zynqmp.h > +++ b/include/linux/firmware/xlnx-zynqmp.h > @@ -52,6 +52,10 @@ > #define ZYNQMP_PM_CAPABILITY_WAKEUP 0x4U > #define ZYNQMP_PM_CAPABILITY_UNUSABLE 0x8U > > +/* Loader commands */ > +#define PM_LOAD_PDI 0x701 This should be defined in enum pm_api_id > +#define PDI_SRC_DDR 0xF This is only used by versal_fpga_ops_write(), consider moving the #define to versal-fpga.c Tom > + > /* > * Firmware FPGA Manager flags > * XILINX_ZYNQMP_PM_FPGA_FULL: FPGA full reconfiguration > @@ -411,6 +415,7 @@ int zynqmp_pm_pinctrl_get_config(const u32 pin, const u32 param, > u32 *value); > int zynqmp_pm_pinctrl_set_config(const u32 pin, const u32 param, > u32 value); > +int zynqmp_pm_load_pdi(const u32 src, const u64 address); > #else > static inline int zynqmp_pm_get_api_version(u32 *version) > { > @@ -622,6 +627,11 @@ static inline int zynqmp_pm_pinctrl_set_config(const u32 pin, const u32 param, > { > return -ENODEV; > } > + > +static inline int zynqmp_pm_load_pdi(const u32 src, const u64 address) > +{ > + return -ENODEV; > +} > #endif > > #endif /* __FIRMWARE_ZYNQMP_H__ */ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel