From: mka@chromium.org (Matthias Kaehlcke)
To: linux-arm-kernel@lists.infradead.org
Subject: [v3,2/6] power: add power sequence library
Date: Fri, 29 Jul 2016 13:06:48 -0700 [thread overview]
Message-ID: <c2e3679b-4522-d403-0a98-eb09c5a2c02d@chromium.org> (raw)
In-Reply-To: <1469007629-31757-3-git-send-email-peter.chen@nxp.com>
Hi Peter,
Thanks for your work on this, a few comments inline
On 07/20/2016 02:40 AM, Peter Chen wrote:
> ...
>
> +static int pwrseq_generic_on(struct device_node *np, struct pwrseq *pwrseq)
> +{
>
> ...
>
> + if (gpiod_reset) {
> + u32 duration_us = 50;
> +
> + of_property_read_u32(np, "reset-duration-us",
> + &duration_us);
> + usleep_range(duration_us, duration_us + 10);
The end of the range could allow for more margin. Also consider busy
looping for very short delays as in
http://lxr.free-electrons.com/source/drivers/regulator/core.c#L2062
> ...
>
> +static int pwrseq_generic_get(struct device_node *np, struct pwrseq *pwrseq)
> +{
> + struct pwrseq_generic *pwrseq_gen = to_generic_pwrseq(pwrseq);
> + enum of_gpio_flags flags;
> + int reset_gpio, ret = 0;
> +
> + pwrseq_gen->clk = of_clk_get_by_name(np, NULL);
This only gets the first of potentially multiple clocks, is that intended?
next prev parent reply other threads:[~2016-07-29 20:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 9:40 [PATCH v3 0/6] power: add power sequence library Peter Chen
2016-07-20 9:40 ` [PATCH v3 1/6] binding-doc: power: pwrseq-generic: add binding doc for generic " Peter Chen
2016-07-29 2:09 ` Peter Chen
2016-07-29 21:09 ` Rob Herring
2016-07-20 9:40 ` [PATCH v3 2/6] power: add " Peter Chen
2016-07-29 20:06 ` Matthias Kaehlcke [this message]
2016-08-01 1:58 ` [v3,2/6] " Peter Chen
2016-08-02 3:32 ` Peter Chen
2016-07-20 9:40 ` [PATCH v3 3/6] binding-doc: usb: usb-device: add optional properties for power sequence Peter Chen
2016-07-29 21:11 ` Rob Herring
2016-07-20 9:40 ` [PATCH v3 4/6] usb: core: add power sequence handling for USB devices Peter Chen
2016-07-27 16:25 ` Joshua Clayton
2016-07-28 1:45 ` Peter Chen
2016-07-28 16:18 ` Joshua Clayton
2016-07-20 9:40 ` [PATCH v3 5/6] usb: chipidea: let chipidea core device of_node equal's glue layer device of_node Peter Chen
2016-07-21 9:14 ` Russell King - ARM Linux
2016-07-21 9:20 ` Peter Chen
2016-07-21 9:41 ` Russell King - ARM Linux
2016-07-21 10:12 ` Peter Chen
2016-07-20 9:40 ` [PATCH v3 6/6] ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property Peter Chen
2016-07-28 15:56 ` [PATCH v3 0/6] power: add power sequence library Joshua Clayton
2016-07-28 16:41 ` Fabio Estevam
2016-08-01 14:55 ` Joshua Clayton
2016-08-01 16:29 ` Fabio Estevam
2016-08-02 1:08 ` Peter Chen
2016-07-29 1:46 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2e3679b-4522-d403-0a98-eb09c5a2c02d@chromium.org \
--to=mka@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).