* [PATCH] soc: amlogic: meson-gx-socinfo: Add of_node_put() before return
@ 2019-08-19 7:27 Nishka Dasgupta
2019-08-19 8:05 ` Neil Armstrong
0 siblings, 1 reply; 3+ messages in thread
From: Nishka Dasgupta @ 2019-08-19 7:27 UTC (permalink / raw)
To: khilman, linux-arm-kernel, linux-amlogic; +Cc: Nishka Dasgupta
The variable np in function meson_gx_socinfo_init takes the return value
of of_find_compatible_node, which gets a node but does not put it. If
this node is not put it may cause a memory leak. Hence put np after its
usefulness has been exhausted.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
---
drivers/soc/amlogic/meson-gx-socinfo.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/soc/amlogic/meson-gx-socinfo.c b/drivers/soc/amlogic/meson-gx-socinfo.c
index bca34954518e..13695a72c695 100644
--- a/drivers/soc/amlogic/meson-gx-socinfo.c
+++ b/drivers/soc/amlogic/meson-gx-socinfo.c
@@ -138,8 +138,10 @@ static int __init meson_gx_socinfo_init(void)
}
/* check if chip-id is available */
- if (!of_property_read_bool(np, "amlogic,has-chip-id"))
+ if (!of_property_read_bool(np, "amlogic,has-chip-id")) {
+ of_node_put(np);
return -ENODEV;
+ }
/* node should be a syscon */
regmap = syscon_node_to_regmap(np);
--
2.19.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: amlogic: meson-gx-socinfo: Add of_node_put() before return
2019-08-19 7:27 [PATCH] soc: amlogic: meson-gx-socinfo: Add of_node_put() before return Nishka Dasgupta
@ 2019-08-19 8:05 ` Neil Armstrong
2019-08-20 21:55 ` Kevin Hilman
0 siblings, 1 reply; 3+ messages in thread
From: Neil Armstrong @ 2019-08-19 8:05 UTC (permalink / raw)
To: Nishka Dasgupta, khilman, linux-arm-kernel, linux-amlogic
On 19/08/2019 09:27, Nishka Dasgupta wrote:
> The variable np in function meson_gx_socinfo_init takes the return value
> of of_find_compatible_node, which gets a node but does not put it. If
> this node is not put it may cause a memory leak. Hence put np after its
> usefulness has been exhausted.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
> ---
> drivers/soc/amlogic/meson-gx-socinfo.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soc/amlogic/meson-gx-socinfo.c b/drivers/soc/amlogic/meson-gx-socinfo.c
> index bca34954518e..13695a72c695 100644
> --- a/drivers/soc/amlogic/meson-gx-socinfo.c
> +++ b/drivers/soc/amlogic/meson-gx-socinfo.c
> @@ -138,8 +138,10 @@ static int __init meson_gx_socinfo_init(void)
> }
>
> /* check if chip-id is available */
> - if (!of_property_read_bool(np, "amlogic,has-chip-id"))
> + if (!of_property_read_bool(np, "amlogic,has-chip-id")) {
> + of_node_put(np);
> return -ENODEV;
> + }
>
> /* node should be a syscon */
> regmap = syscon_node_to_regmap(np);
>
Thanks !
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Would need :
Fixes: a9daaba2965e ("soc: Add Amlogic SoC Information driver")
Neil
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: amlogic: meson-gx-socinfo: Add of_node_put() before return
2019-08-19 8:05 ` Neil Armstrong
@ 2019-08-20 21:55 ` Kevin Hilman
0 siblings, 0 replies; 3+ messages in thread
From: Kevin Hilman @ 2019-08-20 21:55 UTC (permalink / raw)
To: Neil Armstrong, Nishka Dasgupta, linux-arm-kernel, linux-amlogic
Neil Armstrong <narmstrong@baylibre.com> writes:
> On 19/08/2019 09:27, Nishka Dasgupta wrote:
>> The variable np in function meson_gx_socinfo_init takes the return value
>> of of_find_compatible_node, which gets a node but does not put it. If
>> this node is not put it may cause a memory leak. Hence put np after its
>> usefulness has been exhausted.
>> Issue found with Coccinelle.
>>
>> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
>> ---
>> drivers/soc/amlogic/meson-gx-socinfo.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/soc/amlogic/meson-gx-socinfo.c b/drivers/soc/amlogic/meson-gx-socinfo.c
>> index bca34954518e..13695a72c695 100644
>> --- a/drivers/soc/amlogic/meson-gx-socinfo.c
>> +++ b/drivers/soc/amlogic/meson-gx-socinfo.c
>> @@ -138,8 +138,10 @@ static int __init meson_gx_socinfo_init(void)
>> }
>>
>> /* check if chip-id is available */
>> - if (!of_property_read_bool(np, "amlogic,has-chip-id"))
>> + if (!of_property_read_bool(np, "amlogic,has-chip-id")) {
>> + of_node_put(np);
>> return -ENODEV;
>> + }
>>
>> /* node should be a syscon */
>> regmap = syscon_node_to_regmap(np);
>>
>
> Thanks !
>
> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
>
> Would need :
> Fixes: a9daaba2965e ("soc: Add Amlogic SoC Information driver")
Thanks.
Queued for v5.4 with Neil's tag and the Fixes tag.
Kevin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-20 21:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-19 7:27 [PATCH] soc: amlogic: meson-gx-socinfo: Add of_node_put() before return Nishka Dasgupta
2019-08-19 8:05 ` Neil Armstrong
2019-08-20 21:55 ` Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).