From: peda@axentia.se (Peter Rosin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] dt-bindings: i2c-omap: Add new compatible for AM654 SoCs
Date: Wed, 26 Sep 2018 16:44:50 +0200 [thread overview]
Message-ID: <c3421929-1c40-513a-5c14-73e132a11d0f@axentia.se> (raw)
In-Reply-To: <20180926115751.20421-2-vigneshr@ti.com>
On 2018-09-26 13:57, Vignesh R wrote:
> AM654 SoCs have similar I2C IP as OMAP SoCs. Add new compatible to
> handle AM654 SoCs.
>
> Signed-off-by: Vignesh R <vigneshr@ti.com>
> ---
> Documentation/devicetree/bindings/i2c/i2c-omap.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-omap.txt b/Documentation/devicetree/bindings/i2c/i2c-omap.txt
> index 7e49839d4124..11ce869d682d 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-omap.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-omap.txt
> @@ -2,7 +2,8 @@ I2C for OMAP platforms
>
> Required properties :
> - compatible : Must be "ti,omap2420-i2c", "ti,omap2430-i2c", "ti,omap3-i2c"
> - or "ti,omap4-i2c"
> + or "ti,omap4-i2c" for OMAP2+ SoCs
> +- compatible : Must "ti,am654-i2c", "ti,omap4-i2c" for AM654 SoCs
^
be
Also, it looks bad with two 'compatible' entries in the properties list.
I think the trend is to list one valid compatible (plus fallbacks)
per line. So, you should consider reformatting, possibly like so:
- compatible : Must be one of
"ti,omap2420-i2c"
"ti,omap2430-i2c"
"ti,omap3-i2c"
"ti,omap4-i2c"
"ti,am654-i2c", "ti,omap4-i2c"
Cheers,
Peter
> - ti,hwmods : Must be "i2c<n>", n being the instance number (1-based)
> - #address-cells = <1>;
> - #size-cells = <0>;
>
next prev parent reply other threads:[~2018-09-26 14:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 11:57 [PATCH 0/2] i2c-omap: Enable i2c-omap driver for AM654 SoCs Vignesh R
2018-09-26 11:57 ` [PATCH 1/2] dt-bindings: i2c-omap: Add new compatible " Vignesh R
2018-09-26 14:44 ` Peter Rosin [this message]
2018-09-28 5:27 ` Vignesh R
2018-09-26 11:57 ` [PATCH 2/2] i2c: busses: Kconfig: Enable I2C_OMAP for ARCH_K3 Vignesh R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3421929-1c40-513a-5c14-73e132a11d0f@axentia.se \
--to=peda@axentia.se \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).