From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 373BEC433E0 for ; Fri, 8 Jan 2021 10:49:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D1E10238A1 for ; Fri, 8 Jan 2021 10:49:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D1E10238A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kIWdu6fFixgccj+QAddyfbzw4CHw608xOGaakdaFklA=; b=EHaRy5CTa1lwWW6usRetoIx+R eYeqQ72LS5tn9FSyj0uUorCxW9GgeIPHyHJStHN5tpbuu4WzW4VX2TDh0OB5b7i3QjgdvLGIeT3ag 6p1LvC5UlIE+PM3Srhra+J/OJS5e/xyYfFvBquzUVqppTFbGhoTNcxUy3k77+lAy8D7ipYpfHxoGU wneRsflG0d9LC+oOcY61hs2zmp6Lzh93/OLe3+wwuxFXNWrp11+5i6Yo3ItmF3E050/JQVhziFovR WiHXc1otrq2fPW0v7caM9f7OO2ywXbFnfDohJ3HhDh30IT8UECDxQDV3FA7oG3Y26QNQgLGBonOyM VL2MBSFoA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxpIg-0004mS-56; Fri, 08 Jan 2021 10:47:22 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxpG1-0003se-8R for linux-arm-kernel@lists.infradead.org; Fri, 08 Jan 2021 10:44:38 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7E267D6E; Fri, 8 Jan 2021 02:44:36 -0800 (PST) Received: from [10.37.8.22] (unknown [10.37.8.22]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4F5D03F70D; Fri, 8 Jan 2021 02:44:34 -0800 (PST) Subject: Re: [PATCH 2/4] arm64: mte: Add asynchronous mode support To: Andrey Konovalov References: <20210106115519.32222-1-vincenzo.frascino@arm.com> <20210106115519.32222-3-vincenzo.frascino@arm.com> From: Vincenzo Frascino Message-ID: Date: Fri, 8 Jan 2021 10:48:15 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210108_054437_398971_E9DC3CBC X-CRM114-Status: GOOD ( 19.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Branislav Rankov , Marco Elver , Catalin Marinas , Evgenii Stepanov , Will Deacon , LKML , kasan-dev , Alexander Potapenko , Linux ARM , Andrey Ryabinin , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andrey, On 1/7/21 7:18 PM, Andrey Konovalov wrote: >> Boolean arguments are generally bad for legibility, hence I tend to avoid them. >> In this case exposing the constants does not seem a big issue especially because >> the only user of this code is "KASAN_HW_TAGS" and definitely improves its >> legibility hence I would prefer to keep it as is. > > I don't like that this spills KASAN internals to the arm64 code. Could you please elaborate a bit more on this? If I understand it correctly these enumerations I exposed are the direct representation of a kernel command line parameter which, according to me, should not be considered an internal interface. Seems that in general the kernel subsystems expose the interface for the architectures to consume which is the same design pattern I followed in this case. > Let's add another enum with two values and pass it as an argument then. > Something like: > > enum mte_mode { > ARM_MTE_SYNC, > ARM_MTE_ASYNC > } I had something similar at the beginning of the development but I ended up in a situation in which the generic kasan code had to know about "enum mte_mode", hence I preferred to keep kasan agnostic to the hw implementation details. What do you think? -- Regards, Vincenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel