From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 484FBC31E49 for ; Wed, 19 Jun 2019 10:46:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1DB5D21530 for ; Wed, 19 Jun 2019 10:46:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Sjb9iJPm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1DB5D21530 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Z4lC3NFwqLKLmBzrCIH6Tj5HAd4X1K6eVGX6O6JV8IE=; b=Sjb9iJPmFWxyspT4ka8sPjzuN cqt1y/kHIpKyxd6TQSgFilStBEDyYNHxO7tDDndHLS0FNZbfxd2RV7+vJf1eBBkTNRBM4MkMumyyW h15b57O65WjytT07DgZFbKD0JLwcZYV6elMELs44gRgLdEO70GA5iXhkS1ksbH5rlXlGF5HzlZ11r cryFFlUpMgsrCLDIIs7PnZVf3rWLtuz8pfA32I6hlWFsgnxlZGGMxCDESAIvUss3rC0HLQdtpMQCI 6ifZMD6GUj79v6gzUm1Z8nr7zmnT3hulWlRXYdwdbUezj4c6lxCR1MxY9pRPqbfY1arG3cK9f5Kzx o1v47sw+w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hdY6V-0007pV-N8; Wed, 19 Jun 2019 10:46:11 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hdY6T-0007p4-Bs for linux-arm-kernel@lists.infradead.org; Wed, 19 Jun 2019 10:46:10 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B3690C0A; Wed, 19 Jun 2019 03:46:08 -0700 (PDT) Received: from [10.1.196.93] (en101.cambridge.arm.com [10.1.196.93]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 714213F738; Wed, 19 Jun 2019 03:47:54 -0700 (PDT) Subject: Re: [PATCH v1 4/5] coresight: etm4x: improve clarity of etm4_os_unlock comment To: andrew.murray@arm.com, mathieu.poirier@linaro.org, alexander.shishkin@linux.intel.com References: <20190618125433.9739-1-andrew.murray@arm.com> <20190618125433.9739-5-andrew.murray@arm.com> From: Suzuki K Poulose Message-ID: Date: Wed, 19 Jun 2019 11:46:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190618125433.9739-5-andrew.murray@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190619_034609_452526_210405E1 X-CRM114-Status: GOOD ( 17.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 18/06/2019 13:54, Andrew Murray wrote: > To improve clarity, let's update the comment for etm4_os_unlock > to use the name of the register as per the ETM architecture > specification. nit: It also "fixes" the comment. Writing any value doesn't unlock the trace unit. It must be "0". > > Signed-off-by: Andrew Murray > --- > drivers/hwtracing/coresight/coresight-etm4x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c b/drivers/hwtracing/coresight/coresight-etm4x.c > index 885c4f2c691c..bda90d4cd62b 100644 > --- a/drivers/hwtracing/coresight/coresight-etm4x.c > +++ b/drivers/hwtracing/coresight/coresight-etm4x.c > @@ -47,7 +47,7 @@ static enum cpuhp_state hp_online; > > static void etm4_os_unlock(struct etmv4_drvdata *drvdata) > { > - /* Writing any value to ETMOSLAR unlocks the trace registers */ > + /* Writing 0 to TRCOSLAR unlocks the trace registers */ > writel_relaxed(0x0, drvdata->base + TRCOSLAR); > drvdata->os_unlock = true; > isb(); With the above : Reviewed-by: Suzuki K Poulose _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel