From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Vignesh Raghavendra <vigneshr@ti.com>, Nishanth Menon <nm@ti.com>,
Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Aswath Govindraju <a-govindraju@ti.com>,
Grygorii Strashko <grygorii.strashko@ti.com>
Subject: Re: [PATCH v2 2/2] arm64: dts: ti: k3-am625-sk: Enable on board peripherals
Date: Sat, 23 Apr 2022 12:32:53 +0200 [thread overview]
Message-ID: <c40a2dad-c7aa-f778-f1ac-971185691950@linaro.org> (raw)
In-Reply-To: <20220422065002.387753-3-vigneshr@ti.com>
On 22/04/2022 08:50, Vignesh Raghavendra wrote:
> Add nodes for I2C IO expander, OSPI Flash, Eth PHYs, SD and eMMC that
> are present on AM625 SK board.
>
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> Reviewed-by: Bryan Brattlof <bb@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-am625-sk.dts | 273 +++++++++++++++++++++++++
> 1 file changed, 273 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am625-sk.dts b/arch/arm64/boot/dts/ti/k3-am625-sk.dts
> index 0de4113ccd5de..5fc35898a1e2e 100644
> --- a/arch/arm64/boot/dts/ti/k3-am625-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am625-sk.dts
> @@ -9,6 +9,7 @@
>
> #include <dt-bindings/leds/common.h>
> #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/net/ti-dp83867.h>
> #include "k3-am625.dtsi"
>
> / {
> @@ -17,6 +18,12 @@ / {
>
> aliases {
> serial2 = &main_uart0;
> + mmc0 = &sdhci0;
> + mmc1 = &sdhci1;
> + mmc2 = &sdhci2;
> + spi0 = &ospi0;
> + ethernet0 = &cpsw_port1;
> + ethernet1 = &cpsw_port2;
> };
>
> chosen {
> @@ -87,6 +94,33 @@ vcc_3v3_sys: regulator-2 {
> regulator-boot-on;
> };
>
> + vdd_mmc1: fixed-regulator-sd {
Don't encode the type of binding into node name. Node name should be
generic, so either regulator-0 or regulator-sd.
> + /* TPS22918DBVR */
> + compatible = "regulator-fixed";
> + regulator-name = "vdd_mmc1";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-boot-on;
> + enable-active-high;
> + vin-supply = <&vcc_3v3_sys>;
> + gpio = <&exp1 3 GPIO_ACTIVE_HIGH>;
> + };
> +
> + vdd_sd_dv: gpio-regulator-TLV71033 {
The same + do not mix cases, so regulator-1 or regulator-tlv71033
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-23 10:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 6:50 [PATCH v2 0/2] arm64: ti: k3-am62: Introduce DT nodes for basic peripherals Vignesh Raghavendra
2022-04-22 6:50 ` [PATCH v2 1/2] arm64: dts: ti: k3-am62: Add more peripheral nodes Vignesh Raghavendra
2022-04-22 6:50 ` [PATCH v2 2/2] arm64: dts: ti: k3-am625-sk: Enable on board peripherals Vignesh Raghavendra
2022-04-23 10:32 ` Krzysztof Kozlowski [this message]
2022-04-25 9:22 ` Vignesh Raghavendra
2022-04-25 19:02 ` Krzysztof Kozlowski
2022-04-26 18:17 ` Vignesh Raghavendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c40a2dad-c7aa-f778-f1ac-971185691950@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=a-govindraju@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=grygorii.strashko@ti.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).