From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0919DC433EF for ; Wed, 16 Mar 2022 12:53:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZDyjCZHl7r6u8U0psXJaFYnVcde4c9mRiv4ohnvRoNk=; b=vz6brgQ+7x9U1E LtNOtjrcPB5X7rwgMydbVaalYWuVUZlD3hCX22QCPmK8zlxAZXfYlnj23njRvGK1pmt51hNeP/6/o tqDjYthD4oKWcaDuBEy6nosvuwp7mWgankguxuW7zZLi2NX8H/pO470GvgLpNNH95SbxmpktjOSnG tI9UqzwRFdwS3MG8KDH28nqNYyn7GsB0IdOcPdc9sOyy2tZWEnsQBI2SfX5bbDKYdhfTQ9R8KKFRL P7sSgZ2VnllewErJpdUNpbyHaf3l3ADvAxVcoLAjlOHG+BrImWLEh5a7f/P609Is8VVh9xsk95Mas Zhzzru9RaIjfEcmaOETg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUT8b-00Cpfs-VA; Wed, 16 Mar 2022 12:52:26 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUT8X-00Cpeq-5E; Wed, 16 Mar 2022 12:52:22 +0000 X-UUID: f94fc064aa1d4427b5b2ce0b7e05f377-20220316 X-UUID: f94fc064aa1d4427b5b2ce0b7e05f377-20220316 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 759919547; Wed, 16 Mar 2022 05:52:16 -0700 Received: from mtkmbs10n2.mediatek.inc (172.21.101.183) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 16 Mar 2022 05:52:14 -0700 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Wed, 16 Mar 2022 20:52:12 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 16 Mar 2022 20:52:12 +0800 Message-ID: Subject: Re: [V2: 1/1] dt-bindings: media: mtk-vcodec: Adds encoder dt-bindings for mt8186 From: Rex-BC Chen To: kyrie.wu , Hans Verkuil , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tzung-Bi Shih CC: , , , , , , Tomasz Figa , , , Date: Wed, 16 Mar 2022 20:52:12 +0800 In-Reply-To: <9b4deaeb6ab6baaaf771e817f9c2163111796bb9.camel@mediatek.com> References: <1647416417-15176-1-git-send-email-kyrie.wu@mediatek.com> <1647416417-15176-2-git-send-email-kyrie.wu@mediatek.com> <9b4deaeb6ab6baaaf771e817f9c2163111796bb9.camel@mediatek.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220316_055221_246349_6AE01168 X-CRM114-Status: GOOD ( 15.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2022-03-16 at 18:41 +0800, Rex-BC Chen wrote: > On Wed, 2022-03-16 at 15:40 +0800, kyrie.wu wrote: > > From: kyrie wu > > > > Adds encoder dt-bindings for mt8186. > > > > Signed-off-by: kyrie wu > > --- > > .../devicetree/bindings/media/mediatek,vcodec-encoder.yaml | > > 1 > > + > > 1 file changed, 1 insertion(+) > > > > diff --git > > a/Documentation/devicetree/bindings/media/mediatek,vcodec- > > encoder.yaml > > b/Documentation/devicetree/bindings/media/mediatek,vcodec- > > encoder.yaml > > index e7b65a91c92c..6d52947f30a5 100644 > > --- a/Documentation/devicetree/bindings/media/mediatek,vcodec- > > encoder.yaml > > +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec- > > encoder.yaml > > @@ -22,6 +22,7 @@ properties: > > - mediatek,mt8183-vcodec-enc > > - mediatek,mt8192-vcodec-enc > > - mediatek,mt8195-vcodec-enc > > + - mediatek,mt8186-vcodec-enc > > > > Hello Kyrie, > > As metioned in v1, I think it's better to move the 8186 below 8183. > > BRs, > Rex > > reg: > > maxItems: 1 > > Hello Kyrie, By the way, I see you re-use 8183 data in v1. I think the binding should be somthing like this: Before you send next patch, make sure you run the binding check. compatible: oneOf: -items: - enum: - mediatek,mt8173-vcodec-enc-vp8 - mediatek,mt8173-vcodec-enc - mediatek,mt8183-vcodec-enc - mediatek,mt8192-vcodec-enc - mediatek,mt8195-vcodec-enc -items: - enum: - mediatek,mt8186-vcodec-enc - const: mediatek,mt8183-vcodec-enc BRs, Rex _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel