From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E931DC2B9F4 for ; Mon, 28 Jun 2021 11:20:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AEA3E61919 for ; Mon, 28 Jun 2021 11:20:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AEA3E61919 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=s08qZJuQPckNCd11WOClGSYv4/HQPyb5n9+tHeD5j7Q=; b=w6hHEJLpLcdFEaRW4RL8ktRlH/ pz0qJqJChD2+NSQ7qMcjDwLq+9S/Rwz9RqiSXW9LWrGQ7Q03CGhCBLTWQyZInUxfuRhQUihFBELk8 bRmGPi3zsLsdS4EqJ8VTsi7hS/+a60H7YC3K2CNbw3/+iTtRVO3YD4qMcyfU54oqXH56sntFyi283 h1RfQPZymRTpctfRXeFvExAhoMOjaaNL7tadheeYa1CDmkUDt38g5TK0wEB3MXMAtOWdYpGpASjLI pNcizGCLCfGDIJIPBLOTrFlJmyiz5UusB/ERKQsbxLwS5hOMAp9eTXGBDge4n5DbutH4BOjuTu3Vw WQ5x9FuA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lxpHV-007jyC-6O; Mon, 28 Jun 2021 11:18:25 +0000 Received: from phobos.denx.de ([85.214.62.61]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lxpHQ-007jwo-V0 for linux-arm-kernel@lists.infradead.org; Mon, 28 Jun 2021 11:18:22 +0000 Received: from [IPv6:::1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 9F22082DAA; Mon, 28 Jun 2021 13:18:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1624879099; bh=qA45Pgs9vtEjSDKl0Lpxyl8donDg6Vmu3o01tms71Sw=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=u7ggcc7OjxDa6PZfbOhJG+MOyi+dIGDwtArvZ7C3dpiXocmniVH6ChlopUR8Vj/4K ppiB0mngIHTXKer5uR+TkReCVscDnvfd4yVlN6Mj76lMGuAfWk6jutC5Woug6YKwob wFxjQgq+1OH4SR84OUv2G7fmdaRZMc8FKyyUkVMzld1bOWWfyeyEV0f7moon1VLVC2 PKMw0ipUHlrhgmdb23gS0K7KUpFlmdZ49mb6JQ9ljD19nKPJjhYeLMuNAFNDPKnZec wSK5yFc0rhXOXthTT5oOLbtQCIT2REyfjJUWDoS6Z5X24TeJCZxt3/BNMnz7FG4mOZ WJZnkwtQ81Skg== Subject: Re: [PATCH V7 4/4] soc: imx: Add blk-ctl driver for i.MX8MM To: Peng Fan , Adam Ford , "Peng Fan (OSS)" Cc: Rob Herring , Shawn Guo , Sascha Hauer , Sascha Hauer , Fabio Estevam , dl-linux-imx , Philipp Zabel , Lucas Stach , Krzysztof Kozlowski , =?UTF-8?Q?Guido_G=c3=bcnther?= , Andrey Smirnov , devicetree , arm-soc , Linux Kernel Mailing List , Jacky Bai , Schrempf Frieder , Abel Vesa References: <20210612133134.2738-1-peng.fan@oss.nxp.com> <20210612133134.2738-5-peng.fan@oss.nxp.com> <2c39672b-780a-8e33-038e-0856e32ede7a@denx.de> From: Marek Vasut Message-ID: Date: Mon, 28 Jun 2021 13:18:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210628_041821_407561_65E516FB X-CRM114-Status: GOOD ( 18.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/28/21 1:14 PM, Peng Fan wrote: >> Subject: Re: [PATCH V7 4/4] soc: imx: Add blk-ctl driver for i.MX8MM >> >> On 6/14/21 8:07 PM, Adam Ford wrote: >>> On Sat, Jun 12, 2021 at 7:58 AM Peng Fan (OSS) >> wrote: >>>> >>>> From: Peng Fan >>>> >>>> The i.MX8MM SoC has dispmix BLK-CTL and vpumix BLK-CTL, so we add >>>> that support in this driver. >>>> >>>> Reviewed-by: Abel Vesa >>>> Signed-off-by: Peng Fan >>> >>> Maybe my TF-A is too old, but I am not able to wake the device from >>> suspend-to-ram with this series. I used the device tree from [1] to >>> enable both the GPCv2 and the blk-ctl stuff. >>> >>> [1] - >>> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc >>> >> hwork.kernel.org%2Fproject%2Flinux-arm-kernel%2Fpatch%2F20210604111 >> 005 >>> .6804-1-peng.fan%40oss.nxp.com%2F&data=04%7C01%7Cpeng.fan%4 >> 0nxp.co >>> >> m%7Ca4c06cfdf6314633c7c708d93a23cff0%7C686ea1d3bc2b4c6fa92cd99c >> 5c30163 >>> >> 5%7C0%7C0%7C637604747755701757%7CUnknown%7CTWFpbGZsb3d8eyJ >> WIjoiMC4wLjA >>> >> wMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&s >> data=0 >>> pDwVtfizZ7mZh9pSfy0bSbffOxP90AnaQrZ8i8cNv0%3D&reserved=0 >>> >>> I based both off Shawn's for-next branch. >> >> I also ran into issues with this, although it could also be related to GPCv2. On >> MX8MM , the system sometimes hangs when bringing up the GPCv2 power >> domain 6 (VPUMIX). It seems that the GPCv2 driver sets >> GPC_PU_PGC_SW_PUP_REQ register to 0x100 to bring up the VPUMIX and >> the bit never self-clears. After that, it seems the entire GPC locks up. >> Have you ever seen that kind of behavior ? > > Do you have clk enabled for vpumix? Is this issue happends every time? Or hard > to reproduce? Yes, DEC_ROOT is active, I also activated BUS. It happens sporadically (every 5 or so reboots), I have to reboot the machine a few times to trigger it. It happens during the kernel boot process in every few boots. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel