From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEB53C43381 for ; Tue, 26 Mar 2019 10:41:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7AFC720857 for ; Tue, 26 Mar 2019 10:41:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dyjTnNGL"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="D38VNIIZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7AFC720857 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=cogentembedded.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mWDsHe3SUL5f+vMWqj1NzuwsDohBymYosILbRLlBBcc=; b=dyjTnNGL0dqG0e ys8LKwJyi+1DYeZD81V8nVQBNFDUkJQymwiZFdikS6GkpxWWx7mCgQlxr0JxTseru1K4sxD+nuOGv +EUjRkNL+mnifbmpuCz/H5tmGQwMCduYNKiLqSfxuHkzsicM/d9gCHDKZeUB2AjB4fTNqnXuYRsr8 bDxiZwWzJUU13cyeXgCDJksFpwVfbfbMteOcM0ahkZPp+M3ccoVTpJhXhL6Uc+FrFP3s8b/2a03VF SE2BLqL0Yz5mA7W4y8os7kySxGRp9N2hfKQJS7mjkC/kFpFzeSsK8GGKwiQnDLWBGi0yMHp0WPX7q JjdEEKmoGaG9e+DaMb9Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8jVx-00005H-Qn; Tue, 26 Mar 2019 10:41:05 +0000 Received: from mail-lj1-x242.google.com ([2a00:1450:4864:20::242]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8jVo-0008P7-PL for linux-arm-kernel@lists.infradead.org; Tue, 26 Mar 2019 10:40:58 +0000 Received: by mail-lj1-x242.google.com with SMTP id h16so6157140ljg.11 for ; Tue, 26 Mar 2019 03:40:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2I5YsJACu9UfaNajNSsnu4SMBqpXNXMYkE2FLhEbmaM=; b=D38VNIIZKSqHTwYQUV29eGcZ8NlGzdsaUnYdDSoZDtO31XwJsUWJyWymp8fTPPG/fD rwsEzsp9AkLah4WMsvFs2MISy+ICJq/+JosWd4CVd/Hj2r2z1mAQ2uOcOP21LqVI4KLY S37K2mWVqHZVkmAPMbMbvHnlyqiPdCx7XX6Fh82useYa1LC8awRUV5whcKrbANFRmfJo 9lta8QAcnxOYRpHzDKWK+2lL3IcBc2DvymTvm0fKfNJfMdlm43G+/hAJzCZGrNscz1rE Tq7Ap2hFRyHXhoG0owTmAebzv+GM+IB/MJ85MS5AUOzxuYoonmB3K7NnX0W5RNl5qn1F 6Pfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=2I5YsJACu9UfaNajNSsnu4SMBqpXNXMYkE2FLhEbmaM=; b=ElbhkBgdC98GwsvNmiYS1/Rr4a50/5Y3NXPNpEEpsNvgpdOIxKwi5cC6NpI6qZ4334 r9MTKnKNOqPCrvYXqirtjBpifIH31tlUDS25n3V2EQiDAdFTsZ+nv6Vj7jrj93KoKYUU hc4ElJux9pC/YKqiU91Ns+H0IXjGdr+w329nhQhWq5SJajDCb7a8vbYbuKBqihyXzMEW uFLuRmUB1frGSESV2og2VR5r+J1dTTYPT5qXqY2G92TAf3a8fumJBKJfQG1OtlZ3orrd 3DmV7vMjkegd2DR7k+6Te6Cz+xoF6apauN5Se7pOSirUAyzTw/9ljdhANEQy2IH8VjUW ToXQ== X-Gm-Message-State: APjAAAVOrNk/SBomcPnGQh3Hpp2rH5zQjbpM6viCusH0rxdf/LqSLCch ht9XqNnSZ+LJLU4/zl1EpJ0OMQ== X-Google-Smtp-Source: APXvYqzvZnrjqonjXJsxQ53xUAesmAmpB0WB8n+Yl5J0VBvPLIe21YmezU7TOIGzp9ggl5FDeKpiLQ== X-Received: by 2002:a2e:8016:: with SMTP id j22mr4718280ljg.189.1553596847668; Tue, 26 Mar 2019 03:40:47 -0700 (PDT) Received: from wasted.cogentembedded.com ([31.173.80.243]) by smtp.gmail.com with ESMTPSA id f1sm3956556ljf.40.2019.03.26.03.40.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Mar 2019 03:40:47 -0700 (PDT) Subject: Re: [RFC PATCH v2 5/5] mtd: hyperbus: Add driver for TI's Hyperbus memory controller To: Vignesh Raghavendra , David Woodhouse , Brian Norris , Boris Brezillon , Marek Vasut , Richard Weinberger , Rob Herring References: <20190321174548.9288-1-vigneshr@ti.com> <20190321174548.9288-6-vigneshr@ti.com> From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: Date: Tue, 26 Mar 2019 13:40:45 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20190321174548.9288-6-vigneshr@ti.com> Content-Language: en-MW X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190326_034056_819460_7C690D5C X-CRM114-Status: GOOD ( 22.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Arnd Bergmann , tudor.ambarus@microchip.com, Greg Kroah-Hartman , nsekhar@ti.com, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, Mason Yang , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 03/21/2019 08:45 PM, Vignesh Raghavendra wrote: > Add driver for Hyperbus memory controller on TI's AM654 SoC. Programming > IP is pretty simple and provides direct memory mapped access to > connected Flash devices. > > Add basic support for the IP without DMA. Second ChipSelect is not > supported for now. > > Signed-off-by: Vignesh Raghavendra [...] > diff --git a/drivers/mtd/hyperbus/Makefile b/drivers/mtd/hyperbus/Makefile > index ca61dedd730d..24abd1d43ade 100644 > --- a/drivers/mtd/hyperbus/Makefile > +++ b/drivers/mtd/hyperbus/Makefile > @@ -1,3 +1,4 @@ > # SPDX-License-Identifier: GPL-2.0 > > obj-$(CONFIG_MTD_HYPERBUS) += hyperbus-core.o > +obj-$(CONFIG_HBMC_AM654) += hbmc_am654.o > diff --git a/drivers/mtd/hyperbus/hbmc_am654.c b/drivers/mtd/hyperbus/hbmc_am654.c > new file mode 100644 > index 000000000000..abf2b0959a35 > --- /dev/null > +++ b/drivers/mtd/hyperbus/hbmc_am654.c > @@ -0,0 +1,108 @@ > +// SPDX-License-Identifier: GPL-2.0 > +// > +// Copyright (C) 2019 Texas Instruments Incorporated - http://www.ti.com/ > +// Author: Vignesh Raghavendra > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +struct am654_hbmc_priv { > + struct hyperbus_ctlr ctlr; > + struct hyperbus_device hbdev; > + void __iomem *regbase; > +}; > + > +static const struct hyperbus_ops am654_hbmc_ops = { > + .calibrate = hyperbus_calibrate, > +}; > + > +static int am654_hbmc_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct am654_hbmc_priv *priv; > + struct resource *res; > + int ret; > + > + priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); > + if (!priv) > + return -ENOMEM; > + > + platform_set_drvdata(pdev, priv); > + > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + if (!res) { This is redundant as devm_ioremap_resource() checks for !res anyway. > + dev_err(&pdev->dev, "failed to get memory resource\n"); > + return -ENOENT; > + } > + > + priv->regbase = devm_ioremap_resource(dev, res); BTW, there's devm_platform_ioremap_resource() now... [...] MBR, Sergei _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel