From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87369C43603 for ; Mon, 16 Dec 2019 20:36:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A13B21835 for ; Mon, 16 Dec 2019 20:36:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VhZC9bo1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A13B21835 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=f4JFWFf5Yo6zbSW83S4Qk6F0A1acmu806zboRWa+zpU=; b=VhZC9bo1Fxp7caO+LNSK8eYMJ k9lIlRDbNMJvHuaV3PPxQSDdc56xQmHSIwS+FymFOWUsGmNuoaD6guhWc/ZDkGybcCFzQLT7Sooyj XDST88yTEsDRJURsZDiSOOYVg63MVxzPuug5pqFMJ6623c/R73XlITGxM1dzZDAURL+y6vDld6bm6 rFv/6jSyiD8NjOK5Qz8wvMRLLzmXkQSL5ZNfFZRT2n5Vpd3hEw7lhTgbOlf1ra1t0Gd4bAPKGrwZW E220XW6xW5maPOq8yZ2c1LRe82sfRWV8revYyZeQHujbI7jGxMB/Hui6KLjOupYz30Qlpp8hkbnTy hJQHYK9tQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1igx6X-000079-LT; Mon, 16 Dec 2019 20:36:33 +0000 Received: from mail-wr1-f68.google.com ([209.85.221.68]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1igx6U-00005o-Sz for linux-arm-kernel@lists.infradead.org; Mon, 16 Dec 2019 20:36:32 +0000 Received: by mail-wr1-f68.google.com with SMTP id g17so8917382wro.2 for ; Mon, 16 Dec 2019 12:36:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JF5j2QhBPiKVEsszO1fwNIEf5ztIBBW8hIVMIyB6TX8=; b=rHqSYEhzzwRDbh3+TC+QEt6dSHTd2brtkpzuLEh1REtqogd5q5pucSOHZ7CVQp/tz2 pmrN9ZFNdGmQfednLHLL0LV82Rwus/WQkFoE6z2A9Ig0Z2y2yZtFebmIITSz3TJxaGhd MiTbhCWnUo5ht2s1lnfbcJU4Ubji5sFHaKRJYjD1iwqzuheA6J/SP0EAXdE+7faKQYX3 VRcuXg115nEVhLatwP+8kU86u1e2JWif1sUclo+pGjFdbtL+h9JH07Y9pb0WLwswUo07 LMCSdzAemZlADmgC9iNOZnjmV8TfudUUhV7efrAWzr4xeyz96oLNKLPlVhAY+TxyjwCb XMLw== X-Gm-Message-State: APjAAAWlFXYZ0Er0QjPlFXDf5BPvwtyfDKEQR6BNSQIxcJPSYsMhlzGw Qbww6d/9ysaKi6KW20n7vm8= X-Google-Smtp-Source: APXvYqz9kOCrk7TdGWR+j99RWSQ6+KDeJJaAl/3DJBRD938fSrWXpjD853kqh1J0TmYUVY6y872K+A== X-Received: by 2002:a5d:6305:: with SMTP id i5mr33173920wru.119.1576528585567; Mon, 16 Dec 2019 12:36:25 -0800 (PST) Received: from a483e7b01a66.ant.amazon.com (cpc91200-cmbg18-2-0-cust94.5-4.cable.virginm.net. [81.100.41.95]) by smtp.gmail.com with ESMTPSA id v8sm22540503wrw.2.2019.12.16.12.36.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Dec 2019 12:36:24 -0800 (PST) Subject: Re: [PATCH v4 1/6] arm/arm64/xen: hypercall.h add includes guards To: Pavel Tatashin , jmorris@namei.org, sashal@kernel.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, steve.capper@arm.com, linux-arm-kernel@lists.infradead.org, maz@kernel.org, james.morse@arm.com, vladimir.murzin@arm.com, mark.rutland@arm.com, tglx@linutronix.de, gregkh@linuxfoundation.org, allison@lohutok.net, info@metux.net, alexios.zavras@intel.com, sstabellini@kernel.org, boris.ostrovsky@oracle.com, jgross@suse.com, stefan@agner.ch, yamada.masahiro@socionext.com, xen-devel@lists.xenproject.org, linux@armlinux.org.uk, andrew.cooper3@citrix.com References: <20191204232058.2500117-1-pasha.tatashin@soleen.com> <20191204232058.2500117-2-pasha.tatashin@soleen.com> From: Julien Grall Message-ID: Date: Mon, 16 Dec 2019 20:36:23 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <20191204232058.2500117-2-pasha.tatashin@soleen.com> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191216_123630_936185_CADECDC0 X-CRM114-Status: GOOD ( 15.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 04/12/2019 23:20, Pavel Tatashin wrote: > The arm and arm64 versions of hypercall.h are missing the include > guards. This is needed because C inlines for privcmd_call are going to > be added to the files. > > Also fix a comment. > > Signed-off-by: Pavel Tatashin > --- > arch/arm/include/asm/assembler.h | 2 +- > arch/arm/include/asm/xen/hypercall.h | 4 ++++ > arch/arm64/include/asm/xen/hypercall.h | 4 ++++ > include/xen/arm/hypercall.h | 6 +++--- > 4 files changed, 12 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/include/asm/assembler.h b/arch/arm/include/asm/assembler.h > index 99929122dad7..8e9262a0f016 100644 > --- a/arch/arm/include/asm/assembler.h > +++ b/arch/arm/include/asm/assembler.h > @@ -480,7 +480,7 @@ THUMB( orr \reg , \reg , #PSR_T_BIT ) > .macro uaccess_disable, tmp, isb=1 > #ifdef CONFIG_CPU_SW_DOMAIN_PAN > /* > - * Whenever we re-enter userspace, the domains should always be > + * Whenever we re-enter kernel, the domains should always be This feels unrelated from the rest of the patch and probably want an explanation. So I think this want to be in a separate patch. The rest of the patch looks good to me. Cheers, -- Julien Grall _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel