On Mon, 2019-12-02 at 12:20 +0000, Andrew Murray wrote: > On Mon, Dec 02, 2019 at 10:59:36AM +0100, Nicolas Saenz Julienne wrote: > > Hi Andrew, > > > > On Fri, 2019-11-29 at 15:46 +0000, Andrew Murray wrote: > > > On Tue, Nov 26, 2019 at 10:19:43AM +0100, Nicolas Saenz Julienne wrote: > > > > From: Jim Quinlan > > > > > > > > This adds MSI support to the Broadcom STB PCIe host controller. The MSI > > > > controller is physically located within the PCIe block, however, there > > > > is no reason why the MSI controller could not be moved elsewhere in the > > > > future. MSIX is not supported by the HW. > > > > > > > > Since the internal Brcmstb MSI controller is intertwined with the PCIe > > > > controller, it is not its own platform device but rather part of the > > > > PCIe platform device. > > > > > > > > Signed-off-by: Jim Quinlan > > > > Co-developed-by: Nicolas Saenz Julienne > > > > Signed-off-by: Nicolas Saenz Julienne > > > > Reviewed-by: Marc Zyngier > > > > > > > > --- > > > > > > > > Changes since v2 (kept Marc's Reviewed-by as changes didn't affect irq > > > > subsystem stuff or seem petty enough): > > > > - Use standard APIs on register operations > > > > - Get rid of revision code > > > > > > Do any RPI4's have a HW revision of less than 33? > > > > No, IIRC it's actually revision 34. I had left that bit of code in, > > following > > the same train of thought as with the of_data on the device-tree part of the > > driver: "It's harmless and should make accomodating other devices easier." > > It > > turned out not to be such a great approach. Lesson's learned. So I decided > > to > > remove it. > > OK you can add my: > > Reviewed-by: Andrew Murray > > Thanks, > > Andrew Murray Thanks!