From: Javier Martinez Canillas <javierm@redhat.com>
To: Thomas Zimmermann <tzimmermann@suse.de>, linux-kernel@vger.kernel.org
Cc: Albert Ou <aou@eecs.berkeley.edu>,
David Airlie <airlied@linux.ie>,
Catalin Marinas <catalin.marinas@arm.com>,
Russell King <linux@armlinux.org.uk>,
dri-devel@lists.freedesktop.org,
Hans de Goede <hdegoede@redhat.com>,
linux-efi@vger.kernel.org, Palmer Dabbelt <palmer@dabbelt.com>,
Peter Robinson <pbrobinson@gmail.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
linux-riscv@lists.infradead.org, Will Deacon <will@kernel.org>,
Ard Biesheuvel <ardb@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] drivers/firmware: consolidate EFI framebuffer setup for all arches
Date: Fri, 28 May 2021 10:03:04 +0200 [thread overview]
Message-ID: <c6c6b686-6e13-2f1a-0310-b558428304c1@redhat.com> (raw)
In-Reply-To: <e23a44ba-5e9d-d27b-b5e8-0cce3b158ed7@suse.de>
Hello Thomas,
On 5/22/21 7:14 AM, Thomas Zimmermann wrote:
[snip]
>> --- a/arch/arm/Kconfig
>> +++ b/arch/arm/Kconfig
>> @@ -127,6 +127,7 @@ config ARM
>> select PERF_USE_VMALLOC
>> select RTC_LIB
>> select SET_FS
>> + select SYSFB
>
> Don't select this as part of the architecture. Rather make an option for
> SYSFB that depends in the architectures that supports it.
>
Thanks a lot for the suggestion! I did this by making SYSFB's Kconfig option
to be default y and depends on the supported architectures as you mentioned.
This not only is a cleaner approach but also will allow to not touch all the
architectures platform code.
I'll wait for a few more days in case someone else has feedback and post a v2.
> Best regards
> Thomas
>
>
Best regards,
--
Javier Martinez Canillas
Software Engineer
New Platform Technologies Enablement team
RHEL Engineering
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-05-28 8:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 19:37 [PATCH 2/2] drivers/firmware: consolidate EFI framebuffer setup for all arches Javier Martinez Canillas
2021-05-22 5:14 ` Thomas Zimmermann
2021-05-28 8:03 ` Javier Martinez Canillas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6c6b686-6e13-2f1a-0310-b558428304c1@redhat.com \
--to=javierm@redhat.com \
--cc=airlied@linux.ie \
--cc=aou@eecs.berkeley.edu \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=pbrobinson@gmail.com \
--cc=tzimmermann@suse.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).