From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B97FC31E46 for ; Wed, 12 Jun 2019 11:53:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB9B020896 for ; Wed, 12 Jun 2019 11:53:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pUMTKQrG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB9B020896 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8Rae+Xw4cY/Dm5lhhDRHU7IRhmhQdi6wtXxFFoq7aIw=; b=pUMTKQrGFL1O42 o1/BTY1Czp7UZCzox/jYaVBywn3SRnsrMjmT3Vz+ehbLf4BuGEUd+ZuE6mv4q1EILkXyiVGoORA9J 7E3JesCNa2aKbt7h00Q6TidmwUo+cqUX7Tl0JiJggoJNLpAg2I5nuzDc8VeTHo6H+sg1DcqLfZyQf GX1n3Og9gOmbrXrPWT3Am/QksHRSnoFwXs7Kk6IqH6znIrHoCnap8L7fZMGfQAVxHkHGukgCtsC8C eeB5Yh4wmauBgMl15JlVWDfxqZvY45es8LslmSHAGBfyXWi+lbmgY+6POqEvgCxVqaqjDjwHM71t0 xQD2kMk52SAYzRs3Jimw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hb1oK-0007Sj-Oi; Wed, 12 Jun 2019 11:53:00 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hb1oH-0007SF-8y for linux-arm-kernel@lists.infradead.org; Wed, 12 Jun 2019 11:52:58 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 78BEC28; Wed, 12 Jun 2019 04:52:55 -0700 (PDT) Received: from [10.1.196.72] (e119884-lin.cambridge.arm.com [10.1.196.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2E9883F246; Wed, 12 Jun 2019 04:54:33 -0700 (PDT) Subject: Re: [PATCH v16 02/16] arm64: untag user pointers in access_ok and __uaccess_mask_ptr To: Catalin Marinas References: <4327b260fb17c4776a1e3c844f388e4948cfb747.1559580831.git.andreyknvl@google.com> <20190610175326.GC25803@arrakis.emea.arm.com> <20190611145720.GA63588@arrakis.emea.arm.com> <20190612093158.GG10165@c02tf0j2hf1t.cambridge.arm.com> From: Vincenzo Frascino Message-ID: Date: Wed, 12 Jun 2019 12:52:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190612093158.GG10165@c02tf0j2hf1t.cambridge.arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190612_045257_410174_32EA0E09 X-CRM114-Status: GOOD ( 20.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , kvm@vger.kernel.org, Christian Koenig , Szabolcs Nagy , Will Deacon , dri-devel@lists.freedesktop.org, linux-mm@kvack.org, Khalid Aziz , Lee Smith , linux-kselftest@vger.kernel.org, Jacob Bramley , Leon Romanovsky , linux-rdma@vger.kernel.org, amd-gfx@lists.freedesktop.org, Christoph Hellwig , Jason Gunthorpe , linux-arm-kernel@lists.infradead.org, Dave Martin , Evgeniy Stepanov , linux-media@vger.kernel.org, Kees Cook , Ruben Ayrapetyan , Andrey Konovalov , Kevin Brodsky , Alex Williamson , Mauro Carvalho Chehab , Dmitry Vyukov , Kostya Serebryany , Greg Kroah-Hartman , Felix Kuehling , linux-kernel@vger.kernel.org, Jens Wiklander , Ramana Radhakrishnan , Alexander Deucher , Andrew Morton , enh , Robin Murphy , Yishai Hadas , Luc Van Oostenryck Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Catalin, On 12/06/2019 10:32, Catalin Marinas wrote: > Hi Vincenzo, > > On Tue, Jun 11, 2019 at 06:09:10PM +0100, Vincenzo Frascino wrote: >>> diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c >>> index 3767fb21a5b8..69d0be1fc708 100644 >>> --- a/arch/arm64/kernel/process.c >>> +++ b/arch/arm64/kernel/process.c >>> @@ -30,6 +30,7 @@ >>> #include >>> #include >>> #include >>> +#include >>> #include >>> #include >>> #include >>> @@ -323,6 +324,7 @@ void flush_thread(void) >>> fpsimd_flush_thread(); >>> tls_thread_flush(); >>> flush_ptrace_hw_breakpoint(current); >>> + clear_thread_flag(TIF_TAGGED_ADDR); >> >> Nit: in line we the other functions in thread_flush we could have something like >> "tagged_addr_thread_flush", maybe inlined. > > The other functions do a lot more than clearing a TIF flag, so they > deserved their own place. We could do this when adding MTE support. I > think we also need to check what other TIF flags we may inadvertently > pass on execve(), maybe have a mask clearing. > Agreed. All the comments I provided are meant to simplify the addition of MTE support. >>> diff --git a/include/uapi/linux/prctl.h b/include/uapi/linux/prctl.h >>> index 094bb03b9cc2..2e927b3e9d6c 100644 >>> --- a/include/uapi/linux/prctl.h >>> +++ b/include/uapi/linux/prctl.h >>> @@ -229,4 +229,9 @@ struct prctl_mm_map { >>> # define PR_PAC_APDBKEY (1UL << 3) >>> # define PR_PAC_APGAKEY (1UL << 4) >>> >>> +/* Tagged user address controls for arm64 */ >>> +#define PR_SET_TAGGED_ADDR_CTRL 55 >>> +#define PR_GET_TAGGED_ADDR_CTRL 56 >>> +# define PR_TAGGED_ADDR_ENABLE (1UL << 0) >>> + >>> #endif /* _LINUX_PRCTL_H */ >>> diff --git a/kernel/sys.c b/kernel/sys.c >>> index 2969304c29fe..ec48396b4943 100644 >>> --- a/kernel/sys.c >>> +++ b/kernel/sys.c >>> @@ -124,6 +124,12 @@ >>> #ifndef PAC_RESET_KEYS >>> # define PAC_RESET_KEYS(a, b) (-EINVAL) >>> #endif >>> +#ifndef SET_TAGGED_ADDR_CTRL >>> +# define SET_TAGGED_ADDR_CTRL(a) (-EINVAL) >>> +#endif >>> +#ifndef GET_TAGGED_ADDR_CTRL >>> +# define GET_TAGGED_ADDR_CTRL() (-EINVAL) >>> +#endif >>> >>> /* >>> * this is where the system-wide overflow UID and GID are defined, for >>> @@ -2492,6 +2498,16 @@ SYSCALL_DEFINE5(prctl, int, option, unsigned long, arg2, unsigned long, arg3, >>> return -EINVAL; >>> error = PAC_RESET_KEYS(me, arg2); >>> break; >>> + case PR_SET_TAGGED_ADDR_CTRL: >>> + if (arg3 || arg4 || arg5) >>> + return -EINVAL; >>> + error = SET_TAGGED_ADDR_CTRL(arg2); >>> + break; >>> + case PR_GET_TAGGED_ADDR_CTRL: >>> + if (arg2 || arg3 || arg4 || arg5) >>> + return -EINVAL; >>> + error = GET_TAGGED_ADDR_CTRL(); >>> + break; >> >> Why do we need two prctl here? We could have only one and use arg2 as set/get >> and arg3 as a parameter. What do you think? > > This follows the other PR_* options, e.g. PR_SET_VL/GET_VL, > PR_*_FP_MODE. We will use other bits in arg2, for example to set the > precise vs imprecise MTE trapping. > Indeed. I was not questioning the pre-existing interface definition, but trying more to reduce the changes to the ABI to the minimum since: - prctl does not mandate how to use the arg[2-5] - prctl interface is flexible enough for the problem to be solved with only one PR_ command. I agree on reusing the interface for MTE for the purposes you specified. -- Regards, Vincenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel