From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5ED56C433E3 for ; Mon, 13 Jul 2020 11:55:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2C7CA2072D for ; Mon, 13 Jul 2020 11:55:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TGN1HjNz"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=toradex.com header.i=@toradex.com header.b="aF5ymyb6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2C7CA2072D Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=toradex.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9EIHOItdS6SJzaLIwku2uJ2vitcue8ado+rUg3/tDGQ=; b=TGN1HjNzk2Z1cLl9AorRV8u/E CZJnsvrQ8/5W5Sqibgj9e+l1engJAalkVborFq5+S1khvoZYDmTSVBBoqzNMugzvdoZx/9vi3gafB VOd/XDG5FDpOS+SYm/14NKEU6HJNFNViImsOkghbYIAjuw1TUDN3n0gl6N/ZfR90rK55/G0SlY7Ks x7iHJZMdCgGhU7glT+gX/HyUo4UVCNILup3bNRrRjsoJH/2Vo+YVdqiW1ELvrR4cKthwf3CexmP+p +zM009ZQsSRSr0VYWRlXGaS4Kt6FyrrnG10B7zwNB/LlhhIGhnB6uEy4G4vNuKpQG4Gi+9sdPiHic 8ok/hfyDg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jux2B-0004pd-CD; Mon, 13 Jul 2020 11:54:11 +0000 Received: from mail-vi1eur05on2121.outbound.protection.outlook.com ([40.107.21.121] helo=EUR05-VI1-obe.outbound.protection.outlook.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jux29-0004ny-0x for linux-arm-kernel@lists.infradead.org; Mon, 13 Jul 2020 11:54:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EdwWzLcDO+Oz9WhWtfUJ63HzlvwrzMhQgLRoQCCC80j5FHGrZPan5d3znjULt/+GWt5xM73EZDm1aZYB3Vx1/SYjppFLY4Xk1Fx/uMxzMVdcBJNDtOAqWqF2LsPkG4IgHmL6J85/CtGvuVc5Sa/abcoHWqyX1qJ9mC8FdFKiioxgMTMwbnOWNqSQvSNg7st2OfzEn/fJ9iJWlXU8Sjm0LZ+jGtLnfcuT64FRBDN/qNpwMUa/zRNXEXOFii+tiNKmicNLMvE+fgArCbc0whwk54aqy5nKY7lYKxb+f6eOgPV4Pz51wD4qG35nVI4DJuNbrAWZY78NFIu8JozIYWG74g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EdsE6j6dUjw3aV9Rc0azsl7B5uTW+zuUl6suh82K40A=; b=nUHRAVNcXeVemtOUjRminvZK+LKH4PYN4iOFyIEgGAxXP3WGvxv6d6DBj+L9wVD1HSV46Wcu49uivMR0iJmfl318zmIC3ysbHsX3toKVDQLGaG193W03qm2LzhbIYpj2OzGgAopnIxTBbGyJ9Nmyxu9yW13zfQw/I7Ff4i6i0HHJw7HyJ2F5F37s3nnk//EUijRUj1Gbi+ObwTcqy2vhQdHO6/nwYOuQQNK75ygsn6lWBSeqKKi10ANksBIWwupTpzGEovuDHISJege/TGuZ/E54MPr0sPvhQglfl7WcJBbivDva5kxYBdrLHd6VTX4wwWdGmGKxCbImrdJFPJUyWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=toradex.com; dmarc=pass action=none header.from=toradex.com; dkim=pass header.d=toradex.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toradex.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EdsE6j6dUjw3aV9Rc0azsl7B5uTW+zuUl6suh82K40A=; b=aF5ymyb60iBxbTWwTu0Oumkh/Gd9AXk5rwnl5I+UtYTwzvdTQGq6zjVhVVWAwnD+EI398f7iSw2HmFM4B52Ka8OYeXtrUwAAR/5aLCE0WiZabcrQIvAeHLrLrsdPvPcEtgBPVYfLIS3npnhXdZaIYhDuhcDMrd7OCi+lK3MM7dg= Received: from AM6PR05MB6120.eurprd05.prod.outlook.com (2603:10a6:20b:a8::25) by AM7PR05MB7058.eurprd05.prod.outlook.com (2603:10a6:20b:1ab::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.22; Mon, 13 Jul 2020 11:53:56 +0000 Received: from AM6PR05MB6120.eurprd05.prod.outlook.com ([fe80::1d81:6a9b:8c26:3b7d]) by AM6PR05MB6120.eurprd05.prod.outlook.com ([fe80::1d81:6a9b:8c26:3b7d%4]) with mapi id 15.20.3174.025; Mon, 13 Jul 2020 11:53:56 +0000 From: Philippe Schenker To: "devicetree@vger.kernel.org" , "a.fatoum@pengutronix.de" , "shawnguo@kernel.org" Subject: Re: [PATCH 3/3] ARM: dts: colibri-imx7: add usb dual-role switch capability Thread-Topic: [PATCH 3/3] ARM: dts: colibri-imx7: add usb dual-role switch capability Thread-Index: AQHWVr15sZvxLwnO3E+b+KcqajdLWakFR14AgAAjuQA= Date: Mon, 13 Jul 2020 11:53:56 +0000 Message-ID: References: <20200710132423.497230-1-philippe.schenker@toradex.com> <20200710132423.497230-3-philippe.schenker@toradex.com> <73240ab0-5069-40c5-4ade-7fcc2207dfaf@pengutronix.de> In-Reply-To: <73240ab0-5069-40c5-4ade-7fcc2207dfaf@pengutronix.de> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.36.3 authentication-results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=toradex.com; x-originating-ip: [31.10.206.124] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b14ada26-8e83-4170-d27e-08d827236c6c x-ms-traffictypediagnostic: AM7PR05MB7058: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Ij+W7air9s/kEB2bArfX9ruaDuswsR35GLwV5RfPYjsXZmkK+L4f5TP3Vc+0gm4lCWlnEAp4NUgqk7Rx4eMO+tB63Licr71chFxcaR7OdLSFjzSEjiofAv42K+XgTJc0WsXMOoByxdTwX7PxS8hItfjdjI9Wv72694tRkFa+Y0YiVtEz0uf10CgycdrZC3IavQ7p+8x57cdXrrXxBWNfxO9vH0v32exhYfuD6woJhRG0F0EaYB8dpVjscDDsy1LAItpjbGoEtdUp0+u8eJgTWQAbvzkl9YavYlGHLjR4EIldB5etO/g5LO4MfhiVvlUHlL42rrU3cucLeG7YBHegJA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR05MB6120.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(376002)(136003)(346002)(366004)(39840400004)(66446008)(4326008)(26005)(316002)(64756008)(6512007)(71200400001)(8676002)(8936002)(186003)(83380400001)(6486002)(86362001)(2616005)(44832011)(478600001)(110136005)(66556008)(66476007)(54906003)(66946007)(2906002)(6506007)(91956017)(76116006)(53546011)(7416002)(36756003)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: Mdzd/gmYKCYCzcxe6ig3G9lIZfBd68xSmlZUPhvfkCROo2QxmO2bPksZNkeMbpaPKJkfAjMwqUlrfldw6XFP1G+d2WItlytCjMKsb/fhJ8itpg7XCSyepxpaKBn+YQoJEqmIqCNlpq/q/zXf7IqL65/rKpSw+Re9SYs1eJq6UlNp4nnQHZpG9r5zO8Zzk79z5nBOchtur7xwcoX1vSnQZi9Ri8OaJgd0zAeYjwSUW/By7lnKz2FpIG7iRiVV3yn/NqXoTAmgVn6T8kWXneRSPz975LxY3ioHmp7dX6dr+j6nzbrzBYueOLQNFgEwsCWofcKK1ArJ0npuSYAeYMngHVq5IKGWZ0xA2bP7C4C4O2eqjMq9uGk7a0YNdE2qeqcqw5pbvzuPCpWdNk+6bqEC17us/tQtJ0dF/4pN4GxNnrd74OL3GW44kjIQXN2a37kK2sr2CSffzz/vPerkwDTEiqLGKys9CtJwLYraebUgcvQ= x-ms-exchange-transport-forked: True Content-ID: <8064FA273BFAA841AC63E113A8B17019@eurprd05.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: toradex.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM6PR05MB6120.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b14ada26-8e83-4170-d27e-08d827236c6c X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2020 11:53:56.8785 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d9995866-0d9b-4251-8315-093f062abab4 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7Fp7GyqaXroRjWYG7iARvmKmMa98peHMkPdSYm0ArwUyhNc18lP+QlFus1GvyJcMdJhP7tWtixOf288d8baiGkUgtRlTRjIu1RqBZcrisFE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR05MB7058 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200713_075409_088324_65D2668D X-CRM114-Status: GOOD ( 19.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "s.hauer@pengutronix.de" , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "linux-imx@nxp.com" , "kernel@pengutronix.de" , "festevam@gmail.com" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 2020-07-13 at 11:46 +0200, Ahmad Fatoum wrote: > Hello Philippe, > > On 7/10/20 3:24 PM, Philippe Schenker wrote: > > Since the runtime-pm wakeup bug was fixed in > > drivers/usb/chipidea/core.c usb dual-role host/device switching is > > working. So make use of it. > > > > Signed-off-by: Philippe Schenker > > > > --- > > > > arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi | 9 +++++++++ > > arch/arm/boot/dts/imx7-colibri.dtsi | 4 ++-- > > 2 files changed, 11 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi > > b/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi > > index 97601375f264..db56a532a34a 100644 > > --- a/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi > > +++ b/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi > > @@ -20,6 +20,14 @@ clk16m: clk16m { > > clock-frequency = <16000000>; > > }; > > > > + extcon_usbc_det: usbc_det { > > + compatible = "linux,extcon-usb-gpio"; > > According to 4602f3bff266 ("usb: common: add USB GPIO based connection > detection driver"): > "the old way using extcon to support USB Dual-Role switch is now > deprecated > when use Type-B connector." > > Have you considered using a compatible = "gpio-usb-b-connector" child > node instead? > > Cheers, > Ahmad Thanks for the Hint Ahmad, I already tried and just now tried again but it doesn't work on our hardware. Are you sure this works with chipidea driver? Should this new usb-connector stuff work in general with every old driver? Philippe > > > + id-gpio = <&gpio7 14 GPIO_ACTIVE_HIGH>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_usbc_det>; > > + }; > > + > > + > > gpio-keys { > > compatible = "gpio-keys"; > > pinctrl-names = "default"; > > @@ -174,6 +182,7 @@ &uart3 { > > }; > > > > &usbotg1 { > > + extcon = <0>, <&extcon_usbc_det>; > > status = "okay"; > > }; > > > > diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi > > b/arch/arm/boot/dts/imx7-colibri.dtsi > > index e18e89dec879..caea90d2421f 100644 > > --- a/arch/arm/boot/dts/imx7-colibri.dtsi > > +++ b/arch/arm/boot/dts/imx7-colibri.dtsi > > @@ -457,7 +457,7 @@ &uart3 { > > }; > > > > &usbotg1 { > > - dr_mode = "host"; > > + dr_mode = "otg"; > > }; > > > > &usdhc1 { > > @@ -486,7 +486,7 @@ &usdhc3 { > > &iomuxc { > > pinctrl-names = "default"; > > pinctrl-0 = <&pinctrl_gpio1 &pinctrl_gpio2 &pinctrl_gpio3 > > &pinctrl_gpio4 > > - &pinctrl_gpio7 &pinctrl_usbc_det>; > > + &pinctrl_gpio7>; > > > > pinctrl_gpio1: gpio1-grp { > > fsl,pins = < > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel