From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7FFC4C433F5 for ; Mon, 3 Oct 2022 01:48:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jRTp1O1cFg0XJ7QAFCy1nHfpqLaXKjaV/sdqfS2YBIs=; b=TQ/b3VaZfkPBoa +aZHVh2s9TXuTFP0o8+eiY5yprd4mv0sE2mrkJbwJ9kKWO4jq5sJbG9f1VbrPs1imsUexP/Gn8r0D G6n3ypaIhBtEvMF7ztV55Xd9CVWPgqrRYgF9XDQKxPmauXyhw/p5W8EKajXa8n+Ch8vkeYv1c1tb8 yAmSosaq0ZUxt2UO03QR43F1rC8MNSX9wE2r7HMAe7/+ZYaGKCoM3J3L6R5HrcZjpALZj5ooHn3Sw fbD8us3UDRQzUh4xAufnGPBgFAAy9a0xDLcmUaG6nRKyyjQfsO5lWwe1vFcvB2hvD9YvNu9Swb5QZ fOzF2dZ2kFNn9nkM48IQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ofAXf-003Os4-Ju; Mon, 03 Oct 2022 01:46:47 +0000 Received: from smtprelay0011.hostedemail.com ([216.40.44.11] helo=relay.hostedemail.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ofAXb-003OrB-J8 for linux-arm-kernel@lists.infradead.org; Mon, 03 Oct 2022 01:46:45 +0000 Received: from omf02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 71710C0802; Mon, 3 Oct 2022 01:46:38 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf02.hostedemail.com (Postfix) with ESMTPA id A5C348000E; Mon, 3 Oct 2022 01:46:31 +0000 (UTC) Message-ID: Subject: new checkpatch flexible array test ? (was Re: [PATCH v4 12/14] gunyah: rsc_mgr: Add RPC for console services) From: Joe Perches To: Greg Kroah-Hartman , Elliot Berman , Andrew Morton Cc: Bjorn Andersson , Murali Nalajala , Trilok Soni , Srivatsa Vaddagiri , Carl van Schaik , Andy Gross , Dmitry Baryshkov , Jassi Brar , linux-arm-kernel@lists.infradead.org, Mark Rutland , Lorenzo Pieralisi , Sudeep Holla , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Jonathan Corbet , Will Deacon , Catalin Marinas , Arnd Bergmann , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sun, 02 Oct 2022 18:46:30 -0700 In-Reply-To: References: <20220928195633.2348848-1-quic_eberman@quicinc.com> <20220928195633.2348848-13-quic_eberman@quicinc.com> User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-Stat-Signature: s8bxywehf4i6ap8qz4d4zh7cgy8f5nng X-Rspamd-Server: rspamout05 X-Rspamd-Queue-Id: A5C348000E X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1+OfeghBDJYxV12c+mletSZVAMPeQeBrtw= X-HE-Tag: 1664761591-583478 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221002_184643_707616_779CBE8F X-CRM114-Status: GOOD ( 18.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2022-09-30 at 14:22 +0200, Greg Kroah-Hartman wrote: > On Wed, Sep 28, 2022 at 12:56:31PM -0700, Elliot Berman wrote: > > Gunyah resource manager defines a simple API for virtual machine log > > sharing with the console service. [] > > diff --git a/include/linux/gunyah_rsc_mgr.h b/include/linux/gunyah_rsc_mgr.h [] > > +struct gh_rm_notif_vm_console_chars { > > + u16 vmid; > > + u16 num_bytes; > > + u8 bytes[0]; > > Please do not use [0] for new structures, otherwise we will just have to > fix them up again as we are trying to get rid of all of these from the > kernel. Just use "bytes[];" instead. Maybe a checkpatch addition like: --- scripts/checkpatch.pl | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 2737e4ced5745..187ed84c1f80a 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3948,6 +3948,17 @@ sub process { } } +# check for zero length array declarations in likely structs + if ($line =~ /^\+\t($Declare\s*$Ident)\s*\[\s*0\s*\]\s*;\s*$/ && + defined $lines[$linenr] && + $lines[$linenr] =~ /^[\+ ]\}\s*(?:__\w+\s*(?:$balanced_parens)?)\s*;\s*$/) { + if (WARN("FLEXIBLE_ARRAY_ZERO", + "Prefer flexible length array declarations with [] over [0]\n" . $herecurr) && + $fix) { + $fixed[$fixlinenr] =~ s/\[\s*0\s*\]/[]/; + } + } + # check for multiple consecutive blank lines if ($prevline =~ /^[\+ ]\s*$/ && $line =~ /^\+\s*$/ && _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel