From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A33C6C31E5B for ; Mon, 17 Jun 2019 17:07:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D553208E4 for ; Mon, 17 Jun 2019 17:07:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ILEA6664" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D553208E4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3tTsSQyPyXcP9shfG+PDb5DVV4S+tsdPbiHaPCzgV1E=; b=ILEA6664hyAVHg B184FmCGsFes5d7rFuL0r+CFGh7xndh5NBpoB4AkG45yPA0Qid3r/hpVyPYuIUpjExMGzhkjWdBYy 09M9l49a7qDAheOWBjJb4hR33ZpgnZkDCX391ikscON2vmMaOYezrJvKEMQ3q7kEyHiePh/64mHCg 6phy2bbuwcRar+AFWzZKjKFCWF2HTdXvfZzpUk38q/KbbmIJOLQqyjC+wAqiFrOw4MnPUpX7ViFt8 wE56BA317VyQip7v23mQiRnbULFu54+6DD+dnZzlT4oaSjaD+rBCldgD0Z1o6eYZdJezjaUAfEOtG ttOxrLGj4rycF6TggGsg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hcv6W-0004lS-3H; Mon, 17 Jun 2019 17:07:36 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hcv6S-0004l0-VI for linux-arm-kernel@lists.infradead.org; Mon, 17 Jun 2019 17:07:34 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 592E228; Mon, 17 Jun 2019 10:07:32 -0700 (PDT) Received: from [10.1.194.37] (e113632-lin.cambridge.arm.com [10.1.194.37]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F412C3F246; Mon, 17 Jun 2019 10:07:30 -0700 (PDT) Subject: Re: [PATCH] sched/topology: remove unused sd param from arch_scale_cpu_capacity() To: Vincent Guittot , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux@armlinux.org.uk, gregkh@linuxfoundation.org, rafael@kernel.org, viresh.kumar@linaro.org, mingo@redhat.com, peterz@infradead.org References: <1560783617-5827-1-git-send-email-vincent.guittot@linaro.org> From: Valentin Schneider Message-ID: Date: Mon, 17 Jun 2019 18:07:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <1560783617-5827-1-git-send-email-vincent.guittot@linaro.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190617_100733_051453_BB6BD01B X-CRM114-Status: GOOD ( 10.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: quentin.perret@arm.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 17/06/2019 16:00, Vincent Guittot wrote: > struct sched_domain *sd parameter is not used anymore in > arch_scale_cpu_capacity() so we can remove it. > I think it can't hurt to give a bit of background. The *sd parameter used to be there for smt_gain, which got snipped out by: 765d0af19f5f ("sched/topology: Remove the ::smt_gain field from 'struct sched_domain'") I'd appreciate having that commit mentioned in the log. > Signed-off-by: Vincent Guittot Other than that, the changes look fine to me. Reviewed-by: Valentin Schneider [...] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel