From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7A6CC43381 for ; Fri, 22 Feb 2019 15:53:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 94E6C2070B for ; Fri, 22 Feb 2019 15:53:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oOSBLtGF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 94E6C2070B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=L2jSlKYaozMznF5+ocbP1w3FF5zHC45z1wm0tF5Umag=; b=oOSBLtGFzKm+O7QeMqae48/nB 1d/oaUqhGiUiULaG2bKONKdhL0fLhwyvvBv2plAeqMjxVWWqfJ7uS+7DNGBZghO+jq1xnZIVNxxXH 4DBsWuR1BJ983QWkg1ck6zxpoipsJPCP/xwOtQMknZYRchoxqiSz5utty8vd4y/9/JlNIRGAuqriE cyPHA/RpfDvMRS3a5+6vD+awhz81rFBYjtD2w891+SNa6H8mCHlozRooKNthvyQ0VWOxiIs0sbM9y zPGD5965fUf+bdfixZ+beJ/865LkmleyRZTtazczM8nx4ap6o2H78UmXlKdKdzdziT9BNC1EXK5rT 7xGm+CHeQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gxD8L-0003UN-Nm; Fri, 22 Feb 2019 15:53:05 +0000 Received: from mail-wr1-f67.google.com ([209.85.221.67]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gxD8G-0003Sj-52 for linux-arm-kernel@lists.infradead.org; Fri, 22 Feb 2019 15:53:03 +0000 Received: by mail-wr1-f67.google.com with SMTP id q1so2888971wrp.7 for ; Fri, 22 Feb 2019 07:52:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=AZYdSOHGWNBLDvrIWESUusBFRwe2FmDybRbSvegjMko=; b=qG7rzF7UpAUPN+8/qUNOjjK/pvNp1/uNoIDXTF1k/L5ZiMYdHMiH1tyOsdoPeztGf+ FEaYCcvBzmO4DFv3JblwRrmbXG3JJDR/yV8gAiiDnTIhrYDkO1teT+KMcKM0jfHPYNZk RJSG7hBPwvGUIS+b8ep8xd0Y/pz5AOWuVVTNCs+lCoZwlsDkpyqb/9RhSd0meRQMQjae TVjIM3tDsnFglrM5/qcQ/rEh0DCKdVvGFOJGz0TkGD5UsYk82rjx9gh2FBlYp8NIHYkC 8y6EHjwIYk/Lw8i1CtkHBPVVZEJOim+6aipz4gw844o/hXNiN4LOU0voTjdbCyADDxnA 7xkA== X-Gm-Message-State: AHQUAuaHhXRidKyIhEgV1G6oesTnHzczl1Br7o8UwSEPpKrtjY1WNZji OPthSzWa4Xuoa75XPvx+S6oHTA== X-Google-Smtp-Source: AHgI3IamC9lexkG+lnPbxDTafmNENafS3Ar1Z0zbKq2cs/eas3e/pG8idwzLwNKo/80DPlvdd4ahoA== X-Received: by 2002:adf:8447:: with SMTP id 65mr3291503wrf.328.1550850778169; Fri, 22 Feb 2019 07:52:58 -0800 (PST) Received: from dhcp-44-202.space.revspace.nl ([2a01:4f8:1c0c:6c86:46e0:a7ad:5246:f04d]) by smtp.gmail.com with ESMTPSA id x12sm3019425wrs.84.2019.02.22.07.52.56 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Fri, 22 Feb 2019 07:52:57 -0800 (PST) Subject: Re: [PATCH 2/5] ata: libahci_platform: Support per-port interrupts To: Miquel Raynal References: <20190222145356.23072-1-miquel.raynal@bootlin.com> <20190222145356.23072-3-miquel.raynal@bootlin.com> <5040d4cf-7da1-eefa-a8a3-bc4054d528da@redhat.com> <20190222163114.0f4488fe@xps13> From: Hans de Goede Message-ID: Date: Fri, 22 Feb 2019 16:52:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190222163114.0f4488fe@xps13> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190222_075300_189503_F8F56950 X-CRM114-Status: GOOD ( 23.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Andrew Lunn , Jason Cooper , devicetree@vger.kernel.org, Marc Zyngier , Gregory Clement , Maxime Chevallier , Nadav Haklai , linux-ide@vger.kernel.org, Rob Herring , Antoine Tenart , Jens Axboe , Thomas Petazzoni , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 2/22/19 4:31 PM, Miquel Raynal wrote: > Hi Hans, > > Hans de Goede wrote on Fri, 22 Feb 2019 16:26:01 > +0100: > >> Hi, >> >> On 2/22/19 3:53 PM, Miquel Raynal wrote: >>> Right now the ATA core only allows IPs to use a single interrupt. Some >>> of them (for instance the Armada-CP110 one) actually has one interrupt >>> per port. Add some logic to support such situation. >>> >>> We consider that either there is one single interrupt declared in the >>> main IP node, or there are per-port interrupts, each of them being >>> declared in the port sub-nodes. >>> >>> Signed-off-by: Miquel Raynal >>> --- >>> drivers/ata/acard-ahci.c | 2 +- >>> drivers/ata/ahci.c | 2 +- >>> drivers/ata/ahci.h | 3 +- >>> drivers/ata/libahci.c | 2 +- >>> drivers/ata/libahci_platform.c | 66 ++++++++++++++++++++++++++++------ >>> drivers/ata/sata_highbank.c | 2 +- >>> 6 files changed, 61 insertions(+), 16 deletions(-) >>> >>> diff --git a/drivers/ata/acard-ahci.c b/drivers/ata/acard-ahci.c >>> index 583e366be7e2..9414b81e994c 100644 >>> --- a/drivers/ata/acard-ahci.c >>> +++ b/drivers/ata/acard-ahci.c >>> @@ -434,7 +434,7 @@ static int acard_ahci_init_one(struct pci_dev *pdev, const struct pci_device_id >>> if (!hpriv) >>> return -ENOMEM; >>> > - hpriv->irq = pdev->irq; >>> + hpriv->irqs[0] = pdev->irq; >>> hpriv->flags |= (unsigned long)pi.private_data; >>> >> What code-path is going to alloc hpriv->irqs for drivers using this code-path >> which are not using libahci_platform .c ? > > I don't understand the question (or the remark behind the question), > can you explain a little bit more what you have in mind? Sorry I got the code context wrong I meant to put that comment below this chunk: > diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c > index 021ce46e2e57..18bce556d85f 100644 > --- a/drivers/ata/ahci.c > +++ b/drivers/ata/ahci.c > @@ -1817,7 +1817,7 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) > /* legacy intx interrupts */ > pci_intx(pdev, 1); > } > - hpriv->irq = pci_irq_vector(pdev, 0); > + hpriv->irqs[0] = pci_irq_vector(pdev, 0); > > if (!(hpriv->cap & HOST_CAP_SSS) || ahci_ignore_sss) > host->flags |= ATA_HOST_PARALLEL_SCAN; Which AFAIK is a common code-path also used by ahci drivers not using libahci_platform, and in that case hpriv->irqs will be NULL as nothing initializes it. Regards, Hans _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel