From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 972E6C2B9F4 for ; Mon, 14 Jun 2021 15:17:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5741F610A2 for ; Mon, 14 Jun 2021 15:17:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5741F610A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Gp3zmXSlea2qgWHCz49UCHMEr9xQtZ6MPLapJGZYaI8=; b=IkhzV4d+t9SsWUHJVOIQvfLMSy 3EhCKSe90sPvAvkINBPrwEHZM+e20GBarUtBSo02IQnymPUiBxULBhk4mR/dCv8/UYDxwamczrlz9 PeJngvHm9FGj+cE9MO8EoHlPEzTurRL7Rk1xZutFaYXaDAIWHC88cJa0jvbJsuP5ycg1pkNBEQVvr OOwD+bvpMW7i91TeRHyLX4U4eXl3WOsPrBmX1Y28vxtgfgRxtDgM8+aLAc64Tyzzkkp4oKVZz5WV/ OCY1I/SumoELvGJphovnUz4AWNwdZj8JMfvvpiw2pWvl2GUc89QeRmbzfdwTiDqbQF/ctPu1/7urN kT4a6EAA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lsoJr-00Egjj-6A; Mon, 14 Jun 2021 15:16:07 +0000 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lsoJn-00Egj1-Ef for linux-arm-kernel@lists.infradead.org; Mon, 14 Jun 2021 15:16:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623683761; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tseWl+ar2j5bgA3GbFaHmCrYs1B8K7aJoZuY0R4FknU=; b=jRKTkPmebdaCTSWIHPH94/pSdNuJswldeCO0XwDD3fZRK68XByvvCjgpCWFQn34LNLo+9F DTCIFYBLCyh/T88fEq77tfC0YAFJodBJVh3uSin65tR34N1Jmh3W16tRKoe2k9uyT2v2Wh 6XXbbal/U4rLOUub2KtHdJfomLR2zI4= Received: from mail-oo1-f71.google.com (mail-oo1-f71.google.com [209.85.161.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-169-4tD3uxlWPR--1j-qNPqiWw-1; Mon, 14 Jun 2021 11:15:59 -0400 X-MC-Unique: 4tD3uxlWPR--1j-qNPqiWw-1 Received: by mail-oo1-f71.google.com with SMTP id r130-20020a4a37880000b029024987ad471cso7110328oor.17 for ; Mon, 14 Jun 2021 08:15:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=tseWl+ar2j5bgA3GbFaHmCrYs1B8K7aJoZuY0R4FknU=; b=qWzsEU0cAqIjAe4w8kajFQd8z4fVVYK71WY/5ve92yl/Hu7etjBEOzRcxUjDGUK81+ UPGM5OdbCwTCoxiZx9i2DjBLGn3dUCdmxKkGL1va+LjU1udzBsUObDVFbOan9a0bE4mk MIL1dwdn4Q8omZXARkcXZiWvStS+4odzWkRaBOH0t8wq+40MpzpwoCUFiwaNH6C7+PcP qjSSIWWB7NvC1djZjdLlRkqtsotfpD+OPHJjh/eA2vVqpGwrdetvZMbu+aqWOPCy9cqB PDpoJS2VjKfM3LaRznVc9zmQa/kRhRzYsK7fy7fohqQ2JKZ/DfDdaXPv/8oip30RFMP3 VEQQ== X-Gm-Message-State: AOAM531WgS7djCCyDJ/d1WYvUoPU/lbiX3L96s9JU2rageUUEgfI4jOe MN8I6GE6W212YpHZPgAsOQF5zJXMG0lkD1Fqd6/eek6CjfkwQG14GewMH7+tgF5EcrmLXkCV6jR aZHvjUuf//1EJIdDzDV0AoEqZMfLR3kLA1nQzDxk+HeGBIaGUTJ56gU1g/487BR/2wRXeTWOyt3 U6z6Th6Q== X-Received: by 2002:a9d:4d12:: with SMTP id n18mr14245644otf.128.1623683759026; Mon, 14 Jun 2021 08:15:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwcaCZ7HY5QTYsEFbkVzcsOtHFA2QLCLpRc2qiT/TOz9XlKqbbHHsOe3awXHQkzSxP0bJe4eQ== X-Received: by 2002:a9d:4d12:: with SMTP id n18mr14245619otf.128.1623683758789; Mon, 14 Jun 2021 08:15:58 -0700 (PDT) Received: from localhost.localdomain (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id a24sm3365436otr.3.2021.06.14.08.15.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Jun 2021 08:15:58 -0700 (PDT) Subject: Re: [PATCH v3 1/4] fpga: dfl: reorganize to subdir layout To: Luca Ceresoli , mdf@kernel.org, hao.wu@intel.com, michal.simek@xilinx.com, gregkh@linuxfoundation.org, krzysztof.kozlowski@canonical.com, dinguyen@kernel.org, nava.manne@xilinx.com, yilun.xu@intel.com, davidgow@google.com, fpacheco@redhat.com, richard.gong@intel.com Cc: linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20210611162129.3203483-1-trix@redhat.com> <20210611162129.3203483-3-trix@redhat.com> <3e83dee8-4746-b22b-c032-1d73364f9cb7@lucaceresoli.net> From: Tom Rix Message-ID: Date: Mon, 14 Jun 2021 08:15:55 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <3e83dee8-4746-b22b-c032-1d73364f9cb7@lucaceresoli.net> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210614_081603_622919_E57669EE X-CRM114-Status: GOOD ( 21.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/14/21 2:28 AM, Luca Ceresoli wrote: > Hi Tom, > > On 11/06/21 18:21, trix@redhat.com wrote: >> From: Tom Rix >> >> Follow drivers/net/ethernet/ which has control configs >> NET_VENDOR_BLA that map to drivers/net/ethernet/bla >> Since fpgas do not have many vendors, drop the 'VENDOR' and use >> FPGA_BLA. >> >> There are several new subdirs >> altera/ >> dfl/ >> lattice/ >> xilinx/ >> >> Each subdir has a Kconfig that has a new/reused >> >> if FPGA_BLA >> ... existing configs ... >> endif FPGA_BLA >> >> Which is sourced into the main fpga/Kconfig >> >> Each subdir has a Makefile whose transversal is controlled in the >> fpga/Makefile by >> >> obj-$(CONFIG_FPGA_BLA) += bla/ >> >> This is the dfl/ subdir part. >> >> Create a dfl/ subdir >> Move dfl-* files to it. >> Add a Kconfig and Makefile >> >> Because FPGA_DFL is now used in dfl/Kconfig in a if/endif >> block, all the other configs in dfl/Kconfig implicitly depend >> on FPGA_DFL. So the explicit dependence can be removed. Also >> since FPGA_DFL depends on HAS_IOMEM, it can be removed from the >> other configs. >> >> Signed-off-by: Tom Rix >> --- >> MAINTAINERS | 2 +- >> drivers/fpga/Kconfig | 80 +------------------- >> drivers/fpga/Makefile | 18 +---- >> drivers/fpga/dfl/Kconfig | 83 +++++++++++++++++++++ >> drivers/fpga/dfl/Makefile | 16 ++++ >> drivers/fpga/{ => dfl}/dfl-afu-dma-region.c | 0 >> drivers/fpga/{ => dfl}/dfl-afu-error.c | 0 >> drivers/fpga/{ => dfl}/dfl-afu-main.c | 0 >> drivers/fpga/{ => dfl}/dfl-afu-region.c | 0 >> drivers/fpga/{ => dfl}/dfl-afu.h | 0 >> drivers/fpga/{ => dfl}/dfl-fme-br.c | 0 >> drivers/fpga/{ => dfl}/dfl-fme-error.c | 0 >> drivers/fpga/{ => dfl}/dfl-fme-main.c | 0 >> drivers/fpga/{ => dfl}/dfl-fme-mgr.c | 0 >> drivers/fpga/{ => dfl}/dfl-fme-perf.c | 0 >> drivers/fpga/{ => dfl}/dfl-fme-pr.c | 0 >> drivers/fpga/{ => dfl}/dfl-fme-pr.h | 0 >> drivers/fpga/{ => dfl}/dfl-fme-region.c | 0 >> drivers/fpga/{ => dfl}/dfl-fme.h | 0 >> drivers/fpga/{ => dfl}/dfl-n3000-nios.c | 0 >> drivers/fpga/{ => dfl}/dfl-pci.c | 0 >> drivers/fpga/{ => dfl}/dfl.c | 0 >> drivers/fpga/{ => dfl}/dfl.h | 0 >> 23 files changed, 102 insertions(+), 97 deletions(-) >> create mode 100644 drivers/fpga/dfl/Kconfig >> create mode 100644 drivers/fpga/dfl/Makefile >> rename drivers/fpga/{ => dfl}/dfl-afu-dma-region.c (100%) >> rename drivers/fpga/{ => dfl}/dfl-afu-error.c (100%) >> rename drivers/fpga/{ => dfl}/dfl-afu-main.c (100%) >> rename drivers/fpga/{ => dfl}/dfl-afu-region.c (100%) >> rename drivers/fpga/{ => dfl}/dfl-afu.h (100%) >> rename drivers/fpga/{ => dfl}/dfl-fme-br.c (100%) >> rename drivers/fpga/{ => dfl}/dfl-fme-error.c (100%) >> rename drivers/fpga/{ => dfl}/dfl-fme-main.c (100%) >> rename drivers/fpga/{ => dfl}/dfl-fme-mgr.c (100%) >> rename drivers/fpga/{ => dfl}/dfl-fme-perf.c (100%) >> rename drivers/fpga/{ => dfl}/dfl-fme-pr.c (100%) > You should update Documentation/fpga/dfl.rst too as it mentions > "drivers/fpga/dfl-fme-pr.c". This update was in your initial patch 5 so > it's lost now, but it really should be in this patch. > >> rename drivers/fpga/{ => dfl}/dfl-fme-pr.h (100%) >> rename drivers/fpga/{ => dfl}/dfl-fme-region.c (100%) >> rename drivers/fpga/{ => dfl}/dfl-fme.h (100%) >> rename drivers/fpga/{ => dfl}/dfl-n3000-nios.c (100%) >> rename drivers/fpga/{ => dfl}/dfl-pci.c (100%) >> rename drivers/fpga/{ => dfl}/dfl.c (100%) > Same as above. Yes to both, will be fixed in v4 Tom > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel