From: Gavin Shan <gshan@redhat.com>
To: Tian Tao <tiantao6@hisilicon.com>,
catalin.marinas@arm.com, will@kernel.org, rppt@kernel.org,
akpm@linux-foundation.org, zhangpan26@huawei.com,
broonie@kernel.org, linux-arm-kernel@lists.infradead.org
Cc: linuxarm@huawei.com
Subject: Re: [PATCH] arm64: mm: Fix missing-prototypes in pageattr.c
Date: Wed, 16 Sep 2020 13:34:07 +1000 [thread overview]
Message-ID: <c930a3ed-ee25-0952-b001-b6454b45929b@redhat.com> (raw)
In-Reply-To: <1600222847-56792-1-git-send-email-tiantao6@hisilicon.com>
On 9/16/20 12:20 PM, Tian Tao wrote:
> Fix the following warnings.
> arch/arm64/mm/pageattr.c:138:5: warning: no previous prototype for
> ‘set_memory_valid’ [-Wmissing-prototypes]
> int set_memory_valid(unsigned long addr, int numpages, int enable)
> ^
> arch/arm64/mm/pageattr.c:150:5: warning: no previous prototype for
> ‘set_direct_map_invalid_noflush’ [-Wmissing-prototypes]
> int set_direct_map_invalid_noflush(struct page *page)
> ^
> arch/arm64/mm/pageattr.c:165:5: warning: no previous prototype for
> ‘set_direct_map_default_noflush’ [-Wmissing-prototypes]
> int set_direct_map_default_noflush(struct page *page)
> ^
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> ---
Reviewed-by: Gavin Shan <gshan@redhat.com>
> arch/arm64/mm/pageattr.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/mm/pageattr.c b/arch/arm64/mm/pageattr.c
> index 23f648c..1b94f5b 100644
> --- a/arch/arm64/mm/pageattr.c
> +++ b/arch/arm64/mm/pageattr.c
> @@ -8,6 +8,7 @@
> #include <linux/sched.h>
> #include <linux/vmalloc.h>
>
> +#include <asm/cacheflush.h>
> #include <asm/set_memory.h>
> #include <asm/tlbflush.h>
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-16 3:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 2:20 [PATCH] arm64: mm: Fix missing-prototypes in pageattr.c Tian Tao
2020-09-16 3:34 ` Gavin Shan [this message]
2020-09-18 16:17 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c930a3ed-ee25-0952-b001-b6454b45929b@redhat.com \
--to=gshan@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linuxarm@huawei.com \
--cc=rppt@kernel.org \
--cc=tiantao6@hisilicon.com \
--cc=will@kernel.org \
--cc=zhangpan26@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).